Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0054511 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [POS2] Core | major | have not tried | 2023-12-20 11:51 | 2024-02-13 13:51 | |||
| Reporter | marvintm | View Status | public | |||||
| Assigned To | Triage Platform Base | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | 24Q1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0054511: It should be possible to prevent undo from being available for specific state actions over an undoable model | |||||||
| Description | Currently the infrastructure allows to flag a state model as undoable. This is used for the Ticket model in POS mainly at the moment. Once the model is undoable, then the infrastructure keeps the previous state for model-specific actions, so that if undo is triggered, this state can be recovered and replaces the current one. This is possible currently for all actions for the undoable model. However, we have identified some specific actions for which undo should not be possible, as functionally it doesn't make sense, and causes data integrity problems. We need a way to notify the infrastructure this, so that it automatically disables the undo in case these particular actions are triggered | |||||||
| Steps To Reproduce | . | |||||||
| Proposed Solution | Ideally, it would be great if it would be possible to flag some specific action when it is being registered, so that its execution disables the undo. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0159968) hgbot (developer) 2024-01-31 08:49 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/657 [^] |
|
(0159969) hgbot (developer) 2024-01-31 08:50 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1454 [^] |
|
(0160688) hgbot (developer) 2024-02-13 13:51 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/657 [^] |
|
(0160689) hgbot (developer) 2024-02-13 13:51 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: 02b25ec124671b8d65a54fb6fa7c4666cfa8a121 Author: Gonzalo Fernández García <gonzalo.fernandez@openbravo.com> Date: 13-02-2024 12:51:15 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/02b25ec124671b8d65a54fb6fa7c4666cfa8a121 [^] Fixes ISSUE-54511: Changes the State API to support not undoable user actions Now undoable models can define some of their actions to be non-undoable by using the following API: OB.App.StateAPI.Ticket.registerAction('deletePayment', { isUndoable: false, implementation: (ticket, payload) => { ... } } --- M web-test/model/application-state/StateUndo.functional.test.js M web/org.openbravo.mobile.core/app/model/application-state/State.js M web/org.openbravo.mobile.core/app/model/application-state/StateAPI.js --- |
|
(0160690) hgbot (developer) 2024-02-13 13:51 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 64457254a70255511e78415b0cb2124e0c2f448e Author: Gonzalo Fernández García <gonzalo.fernandez@openbravo.com> Date: 13-02-2024 12:51:18 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/64457254a70255511e78415b0cb2124e0c2f448e [^] Relatead to ISSUE-54511: Sets addPayment and deletePayment user actions as not undoable --- M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/AddPayment.js M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/DeletePayment.js --- |
|
(0160691) hgbot (developer) 2024-02-13 13:51 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1454 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-01-31 08:44 | AugustoMauch | Type | feature request => backport |
| 2024-01-31 08:44 | AugustoMauch | Target Version | => 24Q1 |
| 2024-01-31 08:49 | hgbot | Note Added: 0159968 | |
| 2024-01-31 08:50 | hgbot | Note Added: 0159969 | |
| 2024-02-13 13:51 | hgbot | Note Added: 0160688 | |
| 2024-02-13 13:51 | hgbot | Resolution | open => fixed |
| 2024-02-13 13:51 | hgbot | Status | scheduled => closed |
| 2024-02-13 13:51 | hgbot | Fixed in Version | => RR24Q1 |
| 2024-02-13 13:51 | hgbot | Note Added: 0160689 | |
| 2024-02-13 13:51 | hgbot | Note Added: 0160690 | |
| 2024-02-13 13:51 | hgbot | Note Added: 0160691 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |