Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0054176
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[POS2] Coremajorhave not tried2023-12-20 11:512024-01-31 08:47
ReportermarvintmView Statuspublic 
Assigned Togonzalo_fernandez 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0054176: It should be possible to prevent undo from being available for specific state actions over an undoable model

DescriptionCurrently the infrastructure allows to flag a state model as undoable. This is used for the Ticket model in POS mainly at the moment.

Once the model is undoable, then the infrastructure keeps the previous state for model-specific actions, so that if undo is triggered, this state can be recovered and replaces the current one. This is possible currently for all actions for the undoable model.

However, we have identified some specific actions for which undo should not be possible, as functionally it doesn't make sense, and causes data integrity problems. We need a way to notify the infrastructure this, so that it automatically disables the undo in case these particular actions are triggered
Steps To Reproduce.
Proposed SolutionIdeally, it would be great if it would be possible to flag some specific action when it is being registered, so that its execution disables the undo.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 005451124Q1 closedTriage Platform Base POS2 It should be possible to prevent undo from being available for specific state actions over an undoable model 
related to defect 0053889 closedmalsasua Retail Modules Payment is deleted but removePayment function is not executed 

-  Notes
(0158764)
hgbot (developer)
2024-01-02 12:55

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1439 [^]
(0158765)
hgbot (developer)
2024-01-02 12:55

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/650 [^]
(0159530)
hgbot (developer)
2024-01-19 12:52

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/650 [^]
(0159531)
hgbot (developer)
2024-01-19 12:52

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 17d44894d3675bf7c939f8d041eb238fde56b5c1
Author: Gonzalo Fernández García <gonzalo.fernandez@openbravo.com>
Date: 17-01-2024 09:16:28
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/17d44894d3675bf7c939f8d041eb238fde56b5c1 [^]

Fixes ISSUE-54176: Changes the State API to support not undoable user actions

Now undoable models can define some of their actions to be non-undoable by using the following API:

  OB.App.StateAPI.Ticket.registerAction('deletePayment', {
    isUndoable: false,
    implementation: (ticket, payload) => {
      ...
    }
  }

---
M web-test/model/application-state/StateUndo.functional.test.js
M web/org.openbravo.mobile.core/app/model/application-state/State.js
M web/org.openbravo.mobile.core/app/model/application-state/StateAPI.js
---
(0159532)
hgbot (developer)
2024-01-19 12:52

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1439 [^]
(0159533)
hgbot (developer)
2024-01-19 12:52

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: c1e16a4d4423dd94792127dea45990b76f2a9ddd
Author: Gonzalo Fernández García <gonzalo.fernandez@openbravo.com>
Date: 19-01-2024 11:51:58
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/c1e16a4d4423dd94792127dea45990b76f2a9ddd [^]

Relatead to ISSUE-54176: Sets addPayment and deletePayment user actions as not undoable

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/AddPayment.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/DeletePayment.js
---

- Issue History
Date Modified Username Field Change
2023-12-20 11:51 marvintm New Issue
2023-12-20 11:51 marvintm Assigned To => Triage Platform Base
2023-12-20 11:51 marvintm OBNetwork customer => No
2023-12-20 11:51 marvintm Triggers an Emergency Pack => No
2024-01-02 12:55 hgbot Merge Request Status => open
2024-01-02 12:55 hgbot Note Added: 0158764
2024-01-02 12:55 hgbot Note Added: 0158765
2024-01-17 09:31 hgbot Merge Request Status open => approved
2024-01-19 12:52 hgbot Note Added: 0159530
2024-01-19 12:52 hgbot Resolution open => fixed
2024-01-19 12:52 hgbot Status new => closed
2024-01-19 12:52 hgbot Fixed in Version => RR24Q2
2024-01-19 12:52 hgbot Note Added: 0159531
2024-01-19 12:52 hgbot Note Added: 0159532
2024-01-19 12:52 hgbot Note Added: 0159533
2024-01-31 07:21 guillermogil Relationship added related to 0053889
2024-01-31 08:43 AugustoMauch Status closed => new
2024-01-31 08:43 AugustoMauch Resolution fixed => open
2024-01-31 08:43 AugustoMauch Fixed in Version RR24Q2 =>
2024-01-31 08:44 AugustoMauch Status new => scheduled
2024-01-31 08:44 AugustoMauch Status scheduled => resolved
2024-01-31 08:44 AugustoMauch Resolution open => fixed
2024-01-31 08:44 AugustoMauch Status resolved => closed
2024-01-31 08:47 AugustoMauch Assigned To Triage Platform Base => gonzalo_fernandez
2024-01-31 08:47 AugustoMauch Assigned To gonzalo_fernandez => AugustoMauch
2024-01-31 08:47 AugustoMauch Assigned To AugustoMauch => gonzalo_fernandez

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker