0054476: Loss of connection - Slow scan on Count - AWO

Description

In some clients there are constant connection losses when scanning when doing an inventory, in addition to the slowness of reading.

Checking we have detected that in the ProductSelector.java class when reading only by upc (parameter "onlyUPC") a like is done. This causes the query to fire in time.

We have changed it to "=" and now it seems to work fine and the query is fast.

Steps To Reproduce

Access to AWO
Create a new inventory
Search for a product

Current result : Disconnected from AWO and no result displayed

Expected result : The search result appears without going offline

Proposed Solution

Attached is a patch that modifies the like by an "=" with the UPC/EAN value since these codes are usually unique, which speeds up the search.

Tags

No tags attached.

Attached Files

bugFixEscaneoLento.diff [^] (907 bytes) 2024-01-25 23:20 [Show Content] [Hide Content]

--- a/modules/org.openbravo.warehouse.advancedwarehouseoperations/src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/datasources/ProductSelector.java	2024-01-22 11:01:17.438145000 +0100
+++ b/modules/org.openbravo.warehouse.advancedwarehouseoperations/src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/datasources/ProductSelector.java	2024-01-22 11:02:38.124965000 +0100
@@ -179,7 +179,7 @@
     if (jsonsent.has("filterText") && !StringUtils.isEmpty(jsonsent.getString("filterText"))) {
       if (OBMOBCUtils.isJsonObjectPropertyStringPresentNotNullAndNotEmptyString(
           jsonsent.getJSONObject("extraParams"), "onlyUPC")) {
-        hql += " and upper(pr.uPCEAN) like :filterParam ";
+        hql += " and upper(pr.uPCEAN) = '" + jsonsent.getString("filterText").toUpperCase() + "' ";
       } else {
         // Product: SearchKey/UPC/Name
         // Locator: SearchKey

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

0053369

closed

AtulOpenbravo

Openbravo ERP

RM-8085 [DO OTF] Disconnected after search a product in DO OTF

Notes
(0160343) hgbot (developer) 2024-02-07 14:12	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/217 [^]

(0160613) ludmila_ursu (developer) 2024-02-12 12:02	Related Jira: https://openbravo.atlassian.net/browse/RM-11582 [^] Proof of testing: https://docs.google.com/spreadsheets/d/1t-tj99NgzoPguBnNbp34gy-G5kyDkc4xxSlCO5UWWOk/edit#gid=0 [^]

(0160708) hgbot (developer) 2024-02-14 00:36	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations [^] Changeset: 11b13e17d125fb3d5209aa369258bfbe357534eb Author: Ludmila Ursu <ludmila.ursu@openbravo.com> Date: 07-02-2024 14:05:37 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/commit/11b13e17d125fb3d5209aa369258bfbe357534eb [^] Fixes ISSUE-54476: use "=" when scanning ("onlyUPC"), instead of like --- M src/org/openbravo/warehouse/advancedwarehouseoperations/mobile/datasources/ProductSelector.java ---

(0160709) hgbot (developer) 2024-02-14 00:36	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations/-/merge_requests/217 [^]

Issue History
Date Modified	Username	Field	Change
2024-01-25 23:20	axelmercado	New Issue
2024-01-25 23:20	axelmercado	Assigned To	=> Triage Omni WMS
2024-01-25 23:20	axelmercado	File Added: bugFixEscaneoLento.diff
2024-01-25 23:21	axelmercado	Relationship added	related to 0053369
2024-01-26 06:40	Practics	Issue Monitored: Practics
2024-02-07 14:12	hgbot	Note Added: 0160343
2024-02-12 12:02	ludmila_ursu	Note Added: 0160613
2024-02-12 12:02	ludmila_ursu	Assigned To	Triage Omni WMS => ludmila_ursu
2024-02-14 00:36	hgbot	Resolution	open => fixed
2024-02-14 00:36	hgbot	Status	new => closed
2024-02-14 00:36	hgbot	Note Added: 0160708
2024-02-14 00:36	hgbot	Note Added: 0160709