Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0054354 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] A. Platform | minor | have not tried | 2024-01-12 15:13 | 2024-01-22 16:51 | |||
| Reporter | caristu | View Status | public | |||||
| Assigned To | Triage Platform Base | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | PR24Q1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | 2023-10-17 | |||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | https://gitlab.com/openbravo/product/openbravo/-/commit/276992c1ff21c2babfa16573c66be987965afdd2 [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0054354: Some computed column fields are displayed as editable for automatic roles | |||||||
| Description | Fields backed by computed columns and not explicitly marked as read only are displayed as editable for automatic roles. By definition, this kind of fields must always be displayed as read only. Note: this issue can be easily workarounded by explicitly marking the field as read only | |||||||
| Steps To Reproduce | 1) Create a computed column[1]. Leave the column definition as updateable. 2) Create a field for the new computed column. Do not explicitly mark it as read only, it should not be necessary 3) Access to the window with the new field, with an automatic role. Note that the computed column is displayed as non read only. [1] http://wiki.openbravo.com/wiki/How_to_create_a_Computed_Column [^] | |||||||
| Proposed Solution | The source of the problem is here[1]. Now that code is causing the getFieldLevelRoles method to be executed always when accessing to a window with an automatic role. This did not happen before. It must be checked if this is correct or not. If the previous is correct, one possible solution could be just to add here[2] this check: field.getColumn().getSqllogic() == null [1] https://gitlab.com/openbravo/product/openbravo/-/blob/master/modules/org.openbravo.client.application/src/org/openbravo/client/application/WindowSettingsActionHandler.java#L172 [^] [2] https://gitlab.com/openbravo/product/openbravo/-/blob/master/modules/org.openbravo.client.application/src/org/openbravo/client/application/WindowSettingsActionHandler.java#L209 [^] | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0159489) hgbot (developer) 2024-01-18 17:27 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1109 [^] |
|
(0159492) hgbot (developer) 2024-01-18 17:34 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 72f09ab285fce6dfda62af4af756e8f45c7a509e Author: Adrián Blasco <adrian.blasco@openbravo.com> Date: 18-01-2024 16:34:47 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/72f09ab285fce6dfda62af4af756e8f45c7a509e [^] Fixes ISSUE-54354: Computed Column Fields are displayed as Editable for Auto Roles --- M modules/org.openbravo.client.application/src/org/openbravo/client/application/WindowSettingsActionHandler.java --- |
|
(0159493) hgbot (developer) 2024-01-18 17:34 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1109 [^] |
|
(0159606) hgbot (developer) 2024-01-22 16:51 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: aa6c6d11d8608bd5d24a5b837a0e34545eaa7a77 Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 22-01-2024 16:51:14 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/aa6c6d11d8608bd5d24a5b837a0e34545eaa7a77 [^] Fixes ISSUE-54354: Adds support for extra chip overflow types --- A web-jspack/org.openbravo.core2/src/assets/icons/iconMultipleItems.svg A web-jspack/org.openbravo.core2/src/assets/icons/iconMultipleUsers.svg M web-jspack/org.openbravo.core2/src/assets/style/iconography.scss M web-jspack/org.openbravo.core2/src/components/BaseChip/BaseChip.scss M web-jspack/org.openbravo.core2/src/components/ChipList/ChipList.jsx M web-jspack/org.openbravo.core2/src/components/ChipList/ChipList.scss M web-jspack/org.openbravo.core2/src/components/ChipList/ShowAllChipsDialog/ShowAllChipsDialog.jsx M web-jspack/org.openbravo.core2/src/components/ChipList/__test__/ChipList.test.jsx M web-jspack/org.openbravo.core2/src/components/ChipList/stories/ChipList.stories.jsx M web-jspack/org.openbravo.core2/src/components/ChipList/stories/ChipList.stories.scss --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2024-01-16 10:00 | cberner | Type | defect => backport |
| 2024-01-16 10:00 | cberner | Target Version | => PR24Q1 |
| 2024-01-18 17:27 | hgbot | Note Added: 0159489 | |
| 2024-01-18 17:34 | hgbot | Resolution | open => fixed |
| 2024-01-18 17:34 | hgbot | Status | scheduled => closed |
| 2024-01-18 17:34 | hgbot | Fixed in Version | => PR24Q1 |
| 2024-01-18 17:34 | hgbot | Note Added: 0159492 | |
| 2024-01-18 17:34 | hgbot | Note Added: 0159493 | |
| 2024-01-22 16:51 | hgbot | Fixed in Version | PR24Q1 => 24Q2 |
| 2024-01-22 16:51 | hgbot | Note Added: 0159606 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |