0054354: Some computed column fields are displayed as editable for automatic roles

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0054354

Openbravo ERP

A. Platform

public

2024-01-12 15:13

2024-01-22 16:51

Reporter

caristu

Assigned To

Triage Platform Base

Priority

urgent

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

PR24Q1

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Regression date

2023-10-17

Regression introduced in release

Regression introduced by commit

https://gitlab.com/openbravo/product/openbravo/-/commit/276992c1ff21c2babfa16573c66be987965afdd2 [^]

Triggers an Emergency Pack

Summary

0054354: Some computed column fields are displayed as editable for automatic roles

Description

Fields backed by computed columns and not explicitly marked as read only are displayed as editable for automatic roles. By definition, this kind of fields must always be displayed as read only.

Note: this issue can be easily workarounded by explicitly marking the field as read only

Steps To Reproduce

1) Create a computed column[1]. Leave the column definition as updateable.
2) Create a field for the new computed column. Do not explicitly mark it as read only, it should not be necessary
3) Access to the window with the new field, with an automatic role. Note that the computed column is displayed as non read only.

[1] http://wiki.openbravo.com/wiki/How_to_create_a_Computed_Column [^]

Proposed Solution

The source of the problem is here[1]. Now that code is causing the getFieldLevelRoles method to be executed always when accessing to a window with an automatic role. This did not happen before. It must be checked if this is correct or not.

If the previous is correct, one possible solution could be just to add here[2] this check: field.getColumn().getSqllogic() == null

[1] https://gitlab.com/openbravo/product/openbravo/-/blob/master/modules/org.openbravo.client.application/src/org/openbravo/client/application/WindowSettingsActionHandler.java#L172 [^]
[2] https://gitlab.com/openbravo/product/openbravo/-/blob/master/modules/org.openbravo.client.application/src/org/openbravo/client/application/WindowSettingsActionHandler.java#L209 [^]

Additional Information