Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0054168 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | always | 2023-12-19 18:06 | 2024-03-18 16:36 | |||
| Reporter | malsasua | View Status | public | |||||
| Assigned To | caristu | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | alostale | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0054168: module org.openbravo.mobile.core.transformjrxmltopdf/ should be adapted to jasper cache | |||||||
| Description | In the issue https://issues.openbravo.com/view.php?id=37741 [^] was implemented a functionality to cache the jasper files. the module org.openbravo.mobile.core.transformjrxmltopdf is not using this jasper cache and it could cause memory problems: https://gitlab.com/openbravo/customers/SHARED/org.openbravo.mobile.core.transformjrxmltopdf/-/blob/master/src/org/openbravo/mobile/core/transformjrxmltopdf/JasperParser.java#L294 [^] SHU notes about this topic: We 'discovered' that repeated compilation + classloading of i.e. jrxml template Causes quite some metaspace usage (apart from being slow) Where in backoffice we have code to cache the compiled templates (in memory) to avoid doing that repeatedly (while tomcat is running) Doing that the below case came in in this module which was never contributed: https://gitlab.com/openbravo/customers/SHARED/org.openbravo.mobile.core.transformjrxmltopdf/-/blob/master/src/org/openbravo/mobile/core/transformjrxmltopdf/JasperParser.java#L291 [^] Looking at this again: - Line 291 does NOT use backoffice jasper-cache - Line 308 seems to implement some cache in that module on its own https://gitlab.com/openbravo/customers/SHARED/org.openbravo.mobile.core.transformjrxmltopdf/-/blob/master/src/org/openbravo/mobile/core/transformjrxmltopdf/JasperParser.java#L308 [^] But looking at the usage of this: here in line 216 https://gitlab.com/openbravo/customers/SHARED/org.openbravo.mobile.core.transformjrxmltopdf/-/blob/master/src/org/openbravo/mobile/core/transformjrxmltopdf/JasperParser.java#L216 [^] Apparently it uses fillReport method passing 'String' of filename of compiled .jasper file to it While that cache (line 308) avoids the compilation overhead is just runs that fullReport with filename over and over again | |||||||
| Steps To Reproduce | n/a | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0161472) hgbot (developer) 2024-03-01 08:49 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1157 [^] |
|
(0161473) hgbot (developer) 2024-03-01 08:56 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2467 [^] |
|
(0162289) hgbot (developer) 2024-03-18 16:20 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2467 [^] |
|
(0162290) hgbot (developer) 2024-03-18 16:20 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 0eb8be6220634254d1648aede267d6108469284a Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 18-03-2024 15:19:57 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0eb8be6220634254d1648aede267d6108469284a [^] related to BUG-54168: delete files also when sending the email fails --- M src/org/openbravo/pos2/mailing/SendEmailLoader.java --- |
|
(0162291) hgbot (developer) 2024-03-18 16:32 |
Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 678b9fbc049e2208cb4fbae1d0450dab96243f4e Author: Carlos Aristu <carlos.aristu@openbravo.com> Date: 18-03-2024 13:06:33 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/678b9fbc049e2208cb4fbae1d0450dab96243f4e [^] related to BUG-54168: improve jasper cache API to compile from the report desing content --- M modules/org.openbravo.client.application/src/org/openbravo/client/application/report/CompiledReportManager.java M modules/org.openbravo.client.application/src/org/openbravo/client/application/report/ReportingUtils.java M src-test/src/org/openbravo/test/reporting/ReportingUtilsTest.java --- |
|
(0162292) hgbot (developer) 2024-03-18 16:32 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1157 [^] |
|
(0162293) caristu (developer) 2024-03-18 16:36 |
Merge request merged: https://gitlab.com/openbravo/customers/SHARED/org.openbravo.mobile.core.transformjrxmltopdf/-/merge_requests/3 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2023-12-19 18:06 | malsasua | New Issue | |
| 2023-12-19 18:06 | malsasua | Assigned To | => Triage Platform Base |
| 2023-12-19 18:06 | malsasua | Modules | => Core |
| 2023-12-19 18:06 | malsasua | Triggers an Emergency Pack | => No |
| 2024-01-08 14:03 | malsasua | Description Updated | View Revisions |
| 2024-02-09 09:01 | adrianromero | Assigned To | Triage Platform Base => Triage Platform Conn |
| 2024-02-12 16:17 | adrianromero | Description Updated | View Revisions |
| 2024-03-01 08:49 | hgbot | Note Added: 0161472 | |
| 2024-03-01 08:56 | hgbot | Note Added: 0161473 | |
| 2024-03-01 13:45 | adrianromero | Assigned To | Triage Platform Conn => caristu |
| 2024-03-01 13:45 | adrianromero | Status | new => scheduled |
| 2024-03-18 16:20 | hgbot | Note Added: 0162289 | |
| 2024-03-18 16:20 | hgbot | Note Added: 0162290 | |
| 2024-03-18 16:32 | hgbot | Note Added: 0162291 | |
| 2024-03-18 16:32 | hgbot | Note Added: 0162292 | |
| 2024-03-18 16:35 | caristu | Status | scheduled => resolved |
| 2024-03-18 16:35 | caristu | Fixed in SCM revision | => 14b311cf |
| 2024-03-18 16:35 | caristu | Resolution | open => fixed |
| 2024-03-18 16:36 | caristu | Fixed in SCM revision | 14b311cf => |
| 2024-03-18 16:36 | caristu | Review Assigned To | => alostale |
| 2024-03-18 16:36 | caristu | Note Added: 0162293 | |
| 2024-03-18 16:36 | caristu | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |