Openbravo Issue Tracking System - Openbravo ERP | |||||
View Issue Details | |||||
ID | Project | Category | View Status | Date Submitted | Last Update |
0054168 | Openbravo ERP | A. Platform | public | 2023-12-19 18:06 | 2024-03-18 16:36 |
Reporter | malsasua | ||||
Assigned To | caristu | ||||
Priority | high | Severity | major | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Platform | OS | 5 | OS Version | ||
Product Version | |||||
Target Version | Fixed in Version | ||||
Merge Request Status | |||||
Review Assigned To | alostale | ||||
OBNetwork customer | |||||
Web browser | |||||
Modules | Core | ||||
Support ticket | |||||
Regression level | |||||
Regression date | |||||
Regression introduced in release | |||||
Regression introduced by commit | |||||
Triggers an Emergency Pack | No | ||||
Summary | 0054168: module org.openbravo.mobile.core.transformjrxmltopdf/ should be adapted to jasper cache | ||||
Description | In the issue https://issues.openbravo.com/view.php?id=37741 [^] was implemented a functionality to cache the jasper files. the module org.openbravo.mobile.core.transformjrxmltopdf is not using this jasper cache and it could cause memory problems: https://gitlab.com/openbravo/customers/SHARED/org.openbravo.mobile.core.transformjrxmltopdf/-/blob/master/src/org/openbravo/mobile/core/transformjrxmltopdf/JasperParser.java#L294 [^] SHU notes about this topic: We 'discovered' that repeated compilation + classloading of i.e. jrxml template Causes quite some metaspace usage (apart from being slow) Where in backoffice we have code to cache the compiled templates (in memory) to avoid doing that repeatedly (while tomcat is running) Doing that the below case came in in this module which was never contributed: https://gitlab.com/openbravo/customers/SHARED/org.openbravo.mobile.core.transformjrxmltopdf/-/blob/master/src/org/openbravo/mobile/core/transformjrxmltopdf/JasperParser.java#L291 [^] Looking at this again: - Line 291 does NOT use backoffice jasper-cache - Line 308 seems to implement some cache in that module on its own https://gitlab.com/openbravo/customers/SHARED/org.openbravo.mobile.core.transformjrxmltopdf/-/blob/master/src/org/openbravo/mobile/core/transformjrxmltopdf/JasperParser.java#L308 [^] But looking at the usage of this: here in line 216 https://gitlab.com/openbravo/customers/SHARED/org.openbravo.mobile.core.transformjrxmltopdf/-/blob/master/src/org/openbravo/mobile/core/transformjrxmltopdf/JasperParser.java#L216 [^] Apparently it uses fillReport method passing 'String' of filename of compiled .jasper file to it While that cache (line 308) avoids the compilation overhead is just runs that fullReport with filename over and over again | ||||
Steps To Reproduce | n/a | ||||
Proposed Solution | |||||
Additional Information | |||||
Tags | No tags attached. | ||||
Relationships | |||||
Attached Files | |||||
Issue History | |||||
Date Modified | Username | Field | Change | ||
2023-12-19 18:06 | malsasua | New Issue | |||
2023-12-19 18:06 | malsasua | Assigned To | => Triage Platform Base | ||
2023-12-19 18:06 | malsasua | Modules | => Core | ||
2023-12-19 18:06 | malsasua | Triggers an Emergency Pack | => No | ||
2024-01-08 14:03 | malsasua | Description Updated | bug_revision_view_page.php?rev_id=27302#r27302 | ||
2024-02-09 09:01 | adrianromero | Assigned To | Triage Platform Base => Triage Platform Conn | ||
2024-02-12 16:17 | adrianromero | Description Updated | bug_revision_view_page.php?rev_id=27495#r27495 | ||
2024-03-01 08:49 | hgbot | Note Added: 0161472 | |||
2024-03-01 08:56 | hgbot | Note Added: 0161473 | |||
2024-03-01 13:45 | adrianromero | Assigned To | Triage Platform Conn => caristu | ||
2024-03-01 13:45 | adrianromero | Status | new => scheduled | ||
2024-03-18 16:20 | hgbot | Note Added: 0162289 | |||
2024-03-18 16:20 | hgbot | Note Added: 0162290 | |||
2024-03-18 16:32 | hgbot | Note Added: 0162291 | |||
2024-03-18 16:32 | hgbot | Note Added: 0162292 | |||
2024-03-18 16:35 | caristu | Status | scheduled => resolved | ||
2024-03-18 16:35 | caristu | Fixed in SCM revision | => 14b311cf | ||
2024-03-18 16:35 | caristu | Resolution | open => fixed | ||
2024-03-18 16:36 | caristu | Fixed in SCM revision | 14b311cf => | ||
2024-03-18 16:36 | caristu | Review Assigned To | => alostale | ||
2024-03-18 16:36 | caristu | Note Added: 0162293 | |||
2024-03-18 16:36 | caristu | Status | resolved => closed |
Notes | |||||
|
|||||
|
|
||||
|
|||||
|
|
||||
|
|||||
|
|
||||
|
|||||
|
|
||||
|
|||||
|
|
||||
|
|||||
|
|
||||
|
|||||
|
|