Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0054137
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2023-12-14 15:442024-01-12 12:46
ReporteraxelmercadoView Statuspublic 
Assigned Tosreehari 
PriorityhighResolutionfixedFixed in VersionRR24Q2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0054137: Problem with flag 'generateExternalInvoice' in externalOrderLoader

DescriptionWhen the flag 'generateExternalInvoice' is set in the JSON of an order sent by the API, it is not taken into account since it is overridden in the externalOrderLoader.java file, as it is always set to 'True'.
Steps To Reproduce1- Set in the JSON of the order the flag 'generateExternalInvoice' with value 'N' so that the invoice is not generated.
2- Send the JSON by API.
3- Verify that for the created order, the invoice has been generated anyway.
Proposed SolutionIf the ExternalOrderLoader request contains the generateExternalInvoice flag, it should be left as it is. Otherwise, if should be forcefully set to "true" in the ExternalOrderLoader as it currently happens, so that this is the default value in case it is not specified.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0158381)
hgbot (developer)
2023-12-20 06:07

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1432 [^]
(0159259)
hgbot (developer)
2024-01-12 12:46

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: be30bd13c6ce0cd15aee4f84506721ce43bdd722
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 12-01-2024 11:46:34
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/be30bd13c6ce0cd15aee4f84506721ce43bdd722 [^]

Fixes ISSUE-54137: Added conditions to use generateExternalInvoice if in payload

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0159260)
hgbot (developer)
2024-01-12 12:46

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1432 [^]

- Issue History
Date Modified Username Field Change
2023-12-14 15:44 axelmercado New Issue
2023-12-14 15:44 axelmercado Assigned To => Retail
2023-12-14 15:44 axelmercado Triggers an Emergency Pack => No
2023-12-14 17:52 marvintm Proposed Solution updated
2023-12-15 06:58 sreehari Assigned To Retail => sreehari
2023-12-16 08:25 sreehari Status new => scheduled
2023-12-20 06:07 hgbot Note Added: 0158381
2024-01-12 12:46 hgbot Resolution open => fixed
2024-01-12 12:46 hgbot Status scheduled => closed
2024-01-12 12:46 hgbot Fixed in Version => RR24Q2
2024-01-12 12:46 hgbot Note Added: 0159259
2024-01-12 12:46 hgbot Note Added: 0159260


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker