Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0054137Retail ModulesWeb POSpublic2023-12-14 15:442024-01-12 12:46
Reporteraxelmercado 
Assigned Tosreehari 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR24Q2 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0054137: Problem with flag 'generateExternalInvoice' in externalOrderLoader
DescriptionWhen the flag 'generateExternalInvoice' is set in the JSON of an order sent by the API, it is not taken into account since it is overridden in the externalOrderLoader.java file, as it is always set to 'True'.
Steps To Reproduce1- Set in the JSON of the order the flag 'generateExternalInvoice' with value 'N' so that the invoice is not generated.
2- Send the JSON by API.
3- Verify that for the created order, the invoice has been generated anyway.
Proposed SolutionIf the ExternalOrderLoader request contains the generateExternalInvoice flag, it should be left as it is. Otherwise, if should be forcefully set to "true" in the ExternalOrderLoader as it currently happens, so that this is the default value in case it is not specified.
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-12-14 15:44axelmercadoNew Issue
2023-12-14 15:44axelmercadoAssigned To => Retail
2023-12-14 15:44axelmercadoTriggers an Emergency Pack => No
2023-12-14 17:52marvintmProposed Solution updated
2023-12-15 06:58sreehariAssigned ToRetail => sreehari
2023-12-16 08:25sreehariStatusnew => scheduled
2023-12-20 06:07hgbotNote Added: 0158381
2024-01-12 12:46hgbotResolutionopen => fixed
2024-01-12 12:46hgbotStatusscheduled => closed
2024-01-12 12:46hgbotFixed in Version => RR24Q2
2024-01-12 12:46hgbotNote Added: 0159259
2024-01-12 12:46hgbotNote Added: 0159260

Notes
(0158381)
hgbot   
2023-12-20 06:07   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1432 [^]
(0159259)
hgbot   
2024-01-12 12:46   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: be30bd13c6ce0cd15aee4f84506721ce43bdd722
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 12-01-2024 11:46:34
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/be30bd13c6ce0cd15aee4f84506721ce43bdd722 [^]

Fixes ISSUE-54137: Added conditions to use generateExternalInvoice if in payload

---
M src/org/openbravo/retail/posterminal/ExternalOrderLoader.java
---
(0159260)
hgbot   
2024-01-12 12:46   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1432 [^]