Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0053769
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Gift cards and gift vouchersmajoralways2023-10-26 12:032023-11-21 11:43
ReporterngarciaView Statuspublic 
Assigned Tosreehari 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0053769: Gift Card is consumed although it is removed with the Undo button

DescriptionGift Card is consumed although it is removed with the Undo button, the empty gift card transaction (without sales order) is not removed from the Gift Card Instance
Steps To ReproduceIn https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.retail.posterminal/?terminal=VBS-1: [^]

Add a product
Click on Total
Select More - Gift Card Payment Method
Pay Total
Look for TestGC0001
Apply

In the backoffice, check the gift card transaction has been created

In the POS:
Click on Scan and then Undo button
Check the gift card is removed from the ticket

In the backoffice, check the gift card transaction still exists and it shouldn't
TagsNo tags attached.
Attached Filesdiff file icon Backport-22Q2.diff [^] (4,702 bytes) 2023-11-21 11:43 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
has duplicate defect 0053496 closeddcontrera POS2 Wrong Consumption of Gift Card when Undo 

-  Notes
(0156585)
hgbot (developer)
2023-11-01 06:44

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/276 [^]
(0157330)
hgbot (developer)
2023-11-20 09:11

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 94e8e11e086f7c32362f2867b70ef06ad99f4446
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 16-11-2023 16:53:34
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/94e8e11e086f7c32362f2867b70ef06ad99f4446 [^]

Fixes ISSUE-53769: Added action preparation for add product
*this cancels the giftcard when undo action removes the giftcard consumed line and the consumed amount is reverted
*Optimized code for deleteLine action

---
M web/org.openbravo.retail.giftcards/app/model/business-object/ticket/actions/AddProductActionPreparations.js
M web/org.openbravo.retail.giftcards/app/model/business-object/ticket/actions/DeleteLineActionPreparations.js
---
(0157331)
hgbot (developer)
2023-11-20 09:11

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/276 [^]

- Issue History
Date Modified Username Field Change
2023-10-26 12:03 ngarcia New Issue
2023-10-26 12:03 ngarcia Assigned To => Retail
2023-10-26 12:03 ngarcia Triggers an Emergency Pack => No
2023-10-26 12:04 ngarcia Relationship added related to 0053496
2023-10-26 12:21 Practics Issue Monitored: Practics
2023-10-27 06:45 sreehari Assigned To Retail => sreehari
2023-10-27 08:44 sreehari Status new => scheduled
2023-11-01 06:44 hgbot Note Added: 0156585
2023-11-20 09:11 hgbot Resolution open => fixed
2023-11-20 09:11 hgbot Status scheduled => closed
2023-11-20 09:11 hgbot Note Added: 0157330
2023-11-20 09:11 hgbot Note Added: 0157331
2023-11-21 11:43 sreehari File Added: Backport-22Q2.diff
2023-11-27 07:50 marvintm Relationship replaced has duplicate 0053496


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker