Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053769Retail ModulesGift cards and gift voucherspublic2023-10-26 12:032023-11-21 11:43
Reporterngarcia 
Assigned Tosreehari 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053769: Gift Card is consumed although it is removed with the Undo button
DescriptionGift Card is consumed although it is removed with the Undo button, the empty gift card transaction (without sales order) is not removed from the Gift Card Instance
Steps To ReproduceIn https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/web/org.openbravo.retail.posterminal/?terminal=VBS-1: [^]

Add a product
Click on Total
Select More - Gift Card Payment Method
Pay Total
Look for TestGC0001
Apply

In the backoffice, check the gift card transaction has been created

In the POS:
Click on Scan and then Undo button
Check the gift card is removed from the ticket

In the backoffice, check the gift card transaction still exists and it shouldn't
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
has duplicate defect 0053496 closed dcontrera POS2 Wrong Consumption of Gift Card when Undo 
Attached Filesdiff Backport-22Q2.diff (4,702) 2023-11-21 11:43
https://issues.openbravo.com/file_download.php?file_id=19163&type=bug
Issue History
Date ModifiedUsernameFieldChange
2023-10-26 12:03ngarciaNew Issue
2023-10-26 12:03ngarciaAssigned To => Retail
2023-10-26 12:03ngarciaTriggers an Emergency Pack => No
2023-10-26 12:04ngarciaRelationship addedrelated to 0053496
2023-10-26 12:21PracticsIssue Monitored: Practics
2023-10-27 06:45sreehariAssigned ToRetail => sreehari
2023-10-27 08:44sreehariStatusnew => scheduled
2023-11-01 06:44hgbotNote Added: 0156585
2023-11-20 09:11hgbotResolutionopen => fixed
2023-11-20 09:11hgbotStatusscheduled => closed
2023-11-20 09:11hgbotNote Added: 0157330
2023-11-20 09:11hgbotNote Added: 0157331
2023-11-21 11:43sreehariFile Added: Backport-22Q2.diff
2023-11-27 07:50marvintmRelationship replacedhas duplicate 0053496

Notes
(0156585)
hgbot   
2023-11-01 06:44   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/276 [^]
(0157330)
hgbot   
2023-11-20 09:11   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 94e8e11e086f7c32362f2867b70ef06ad99f4446
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 16-11-2023 16:53:34
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/94e8e11e086f7c32362f2867b70ef06ad99f4446 [^]

Fixes ISSUE-53769: Added action preparation for add product
*this cancels the giftcard when undo action removes the giftcard consumed line and the consumed amount is reverted
*Optimized code for deleteLine action

---
M web/org.openbravo.retail.giftcards/app/model/business-object/ticket/actions/AddProductActionPreparations.js
M web/org.openbravo.retail.giftcards/app/model/business-object/ticket/actions/DeleteLineActionPreparations.js
---
(0157331)
hgbot   
2023-11-20 09:11   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/276 [^]