Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0053749
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] A. Platformmajorhave not tried2023-10-11 11:102023-10-27 11:43
ReportercbernerView Statuspublic 
Assigned Tocberner 
PrioritynormalResolutionfixedFixed in VersionPR23Q4
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget VersionPR23Q4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression levelProduction - QA Approved
Regression date2023-09-21
Regression introduced in releasePR23Q3
Regression introduced by commithttps://gitlab.com/openbravo/product/openbravo/-/commit/03fa452e48c60b06e2f1a70f29a093bbf07004d0 [^]
Triggers an Emergency PackNo
Summary

0053749: EDL in initial or processing state indefinitely when role has no access to Import Entry table

DescriptionWhen an EDL is launched by a user role or context that has no access to the C_IMPORT_ENTRY table it fails due to some checks that are done for non-blocking and are not inside Admin Mode contexts.
Steps To ReproducePrepare an environment with Web POS and Retail API modules. It is also reproduceable in livebuilds: https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi [^]

1. Login backend as White Valley Admin
2. Go to Role Access window and add a new record for Vall Blanca User.
  - Table: C_IMPORT_ENTRY
  - Excluded: Checked
2.1. Save this record.
3. Go to External System window and add a new record:
  - Name: TestingExtSystem
  - Protocol: HTTP - Backend
3.1. Save and add a new record in subtab HTTP:
  - URL: Add the url generated in this page[1] or a local webserver for testing.
  - Username: anything
  - Password: anything
  - Leave the rest of the fields with default values, then save.
4. Go to Events Subscription window and add a new record:
  - Event: Web POS Order Creation
  - External System: TestingExtSystem
5. Go to EDL Configuration window and add a new record:
  - EDL Process: Send Business API Event
5.1. In subtab Output add a new record with default values and save.
6. Open WebPOS and login as vallblanca user.
7. Add any product to the ticket and try to complete/pay it.
8. Go to backoffice and login as White Valley Admin, then go to the EDL Request window.
9. Check that the request is either in initial or processing and it doesn't change. In tomcat log we will see the following error:
org.openbravo.base.exception.OBSecurityException: Entity C_IMPORT_ENTRY is not directly readable, only id and identifier properties are readable, property C_IMPORT_ENTRY.isnonblocking is neither of these.


[1] https://webhook.site/#!/d6299bb1-4671-47e7-9488-98388cf8d389/a01672e6-9ac1-45f3-937a-4c232243995b/1 [^]
Proposed SolutionAdd setAdminMode where required to not fail because of missing permissions on the user launching the EDL.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by feature request 0052614 closedcberner There should be a mechanism to have non-blocking async EDL Requests 
blocks defect 0053639 closedcberner EDL in initial or processing state indefinitely when role has no access to Import Entry table 

-  Notes
(0156243)
hgbot (developer)
2023-10-24 17:21

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/merge_requests/31 [^]
(0156244)
hgbot (developer)
2023-10-24 17:23

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1026 [^]
(0156256)
hgbot (developer)
2023-10-24 23:49

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration [^]
Changeset: 2e203be4a9a8985136505e28b12de05974d89ba2
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 24-10-2023 21:48:54
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/commit/2e203be4a9a8985136505e28b12de05974d89ba2 [^]

Fixes ISSUE-53749: EDL in initial or processing state indefinitely when role has no access to Import Entry table

---
M src/org/openbravo/externaldata/integration/process/EDLImportEntryProcessor.java
---
(0156257)
hgbot (developer)
2023-10-24 23:49

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/merge_requests/31 [^]
(0156258)
hgbot (developer)
2023-10-24 23:49

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1026 [^]
(0156259)
hgbot (developer)
2023-10-24 23:49

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: d8de2ee77f68ad735d6178ae5ca475458deac8ea
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 24-10-2023 17:22:16
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/d8de2ee77f68ad735d6178ae5ca475458deac8ea [^]

Fixes ISSUE-53749: EDL in initial or processing state indefinitely when role has no access to Import Entry table

---
M src/org/openbravo/service/importprocess/NonBlockingImportEntryProcessRunnable.java
---

- Issue History
Date Modified Username Field Change
2023-10-24 16:26 cberner Type defect => backport
2023-10-24 16:26 cberner Target Version => PR23Q4
2023-10-24 17:21 hgbot Note Added: 0156243
2023-10-24 17:23 hgbot Note Added: 0156244
2023-10-24 23:49 hgbot Resolution open => fixed
2023-10-24 23:49 hgbot Status scheduled => closed
2023-10-24 23:49 hgbot Note Added: 0156256
2023-10-24 23:49 hgbot Note Added: 0156257
2023-10-24 23:49 hgbot Note Added: 0156258
2023-10-24 23:49 hgbot Fixed in Version => PR23Q4
2023-10-24 23:49 hgbot Note Added: 0156259
2023-10-27 10:26 AugustoMauch Relationship added caused by 0052614
2023-10-27 11:43 ivancaceres Issue Monitored: ivancaceres

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker