Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0053639
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2023-10-11 11:102024-02-22 00:01
ReportercbernerView Statuspublic 
Assigned Tocberner 
PrioritynormalResolutionfixedFixed in VersionPR24Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression levelProduction - QA Approved
Regression date2023-09-21
Regression introduced in releasePR23Q3
Regression introduced by commithttps://gitlab.com/openbravo/product/openbravo/-/commit/03fa452e48c60b06e2f1a70f29a093bbf07004d0 [^]
Triggers an Emergency PackNo
Summary

0053639: EDL in initial or processing state indefinitely when role has no access to Import Entry table

DescriptionWhen an EDL is launched by a user role or context that has no access to the C_IMPORT_ENTRY table it fails due to some checks that are done for non-blocking and are not inside Admin Mode contexts.
Steps To ReproducePrepare an environment with Web POS and Retail API modules. It is also reproduceable in livebuilds: https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi [^]

1. Login backend as White Valley Admin
2. Go to Role Access window and add a new record for Vall Blanca User.
  - Table: C_IMPORT_ENTRY
  - Excluded: Checked
2.1. Save this record.
3. Go to External System window and add a new record:
  - Name: TestingExtSystem
  - Protocol: HTTP - Backend
3.1. Save and add a new record in subtab HTTP:
  - URL: Add the url generated in this page[1] or a local webserver for testing.
  - Username: anything
  - Password: anything
  - Leave the rest of the fields with default values, then save.
4. Go to Events Subscription window and add a new record:
  - Event: Web POS Order Creation
  - External System: TestingExtSystem
5. Go to EDL Configuration window and add a new record:
  - EDL Process: Send Business API Event
5.1. In subtab Output add a new record with default values and save.
6. Open WebPOS and login as vallblanca user.
7. Add any product to the ticket and try to complete/pay it.
8. Go to backoffice and login as White Valley Admin, then go to the EDL Request window.
9. Check that the request is either in initial or processing and it doesn't change. In tomcat log we will see the following error:
org.openbravo.base.exception.OBSecurityException: Entity C_IMPORT_ENTRY is not directly readable, only id and identifier properties are readable, property C_IMPORT_ENTRY.isnonblocking is neither of these.


[1] https://webhook.site/#!/d6299bb1-4671-47e7-9488-98388cf8d389/a01672e6-9ac1-45f3-937a-4c232243995b/1 [^]
Proposed SolutionAdd setAdminMode where required to not fail because of missing permissions on the user launching the EDL.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0053749PR23Q4 closedcberner EDL in initial or processing state indefinitely when role has no access to Import Entry table 
caused by feature request 0052614 closedcberner There should be a mechanism to have non-blocking async EDL Requests 

-  Notes
(0155780)
hgbot (developer)
2023-10-11 12:59

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/merge_requests/29 [^]
(0155781)
hgbot (developer)
2023-10-11 13:03

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1014 [^]
(0156252)
hgbot (developer)
2023-10-24 23:48

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/merge_requests/29 [^]
(0156253)
hgbot (developer)
2023-10-24 23:48

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1014 [^]
(0156254)
hgbot (developer)
2023-10-24 23:48

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: edb7237d58f95ef1c34708975bd9ca9766162eb4
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 24-10-2023 16:24:36
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/edb7237d58f95ef1c34708975bd9ca9766162eb4 [^]

Fixes ISSUE-53639: EDL in initial or processing state indefinitely when role has no access to Import Entry table

---
M src/org/openbravo/service/importprocess/NonBlockingImportEntryProcessRunnable.java
---
(0156255)
hgbot (developer)
2023-10-24 23:48

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration [^]
Changeset: 3356d9d25df188d95a1bd6704931155f779d4425
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 24-10-2023 21:47:23
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.externaldata.integration/-/commit/3356d9d25df188d95a1bd6704931155f779d4425 [^]

Fixes ISSUE-53639: EDL in initial or processing state indefinitely when role has no access to Import Entry table

---
M src/org/openbravo/externaldata/integration/process/EDLImportEntryProcessor.java
---

- Issue History
Date Modified Username Field Change
2023-10-11 11:10 cberner New Issue
2023-10-11 11:10 cberner Assigned To => Triage Platform Base
2023-10-11 11:10 cberner OBNetwork customer => No
2023-10-11 11:10 cberner Modules => Core
2023-10-11 11:10 cberner Regression level => Production - QA Approved
2023-10-11 11:10 cberner Regression date => 2023-09-21
2023-10-11 11:10 cberner Regression introduced in release => PR23Q3
2023-10-11 11:10 cberner Regression introduced by commit => https://gitlab.com/openbravo/product/openbravo/-/commit/03fa452e48c60b06e2f1a70f29a093bbf07004d0 [^]
2023-10-11 11:10 cberner Triggers an Emergency Pack => No
2023-10-11 11:11 cberner Assigned To Triage Platform Base => cberner
2023-10-11 12:59 hgbot Merge Request Status => open
2023-10-11 12:59 hgbot Note Added: 0155780
2023-10-11 13:03 hgbot Note Added: 0155781
2023-10-11 13:13 hgbot Merge Request Status open => approved
2023-10-24 16:14 cberner Relationship added caused by 0052614
2023-10-24 16:26 cberner Status new => scheduled
2023-10-24 23:48 hgbot Note Added: 0156252
2023-10-24 23:48 hgbot Note Added: 0156253
2023-10-24 23:48 hgbot Resolution open => fixed
2023-10-24 23:48 hgbot Status scheduled => closed
2023-10-24 23:48 hgbot Fixed in Version => PR24Q1
2023-10-24 23:48 hgbot Note Added: 0156254
2023-10-24 23:48 hgbot Note Added: 0156255
2024-02-22 00:01 eugeni Issue Monitored: eugeni

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker