Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0005366
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] I. Performanceminoralways2008-10-01 18:052009-01-29 18:24
ReporteropabloView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionno change requiredFixed in Version
StatusclosedFix in branch2.40-performanceFixed in SCM revision10661
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseOracleJava version1.5
OS VersionDatabase versionAnt version1.7
Product Version2.40SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0005366: Under some circumstances, DataGrid performs two identical queries to retrieve the data

DescriptionWhen the number of registers of a DataGrid is less than a screen, to fill the DataGrid, two identical requests are issued. Seems that valid data from first request are discarded, and data from second request (same results than the first one) is actually showed in DataGrid.

We see the 2 requests in the server's access log:
127.0.0.1 - - [01/Oct/2008:17:57:16 +0200] "POST /openbravo/utility/DataGrid.html?Command=DATA&inpadTabId=180&inpadWindowId=140&inpAccessLevel=3 HTTP/1.1" 200 689
127.0.0.1 - - [01/Oct/2008:17:57:16 +0200] "POST /openbravo/utility/DataGrid.html?Command=DATA&inpadTabId=180&inpadWindowId=140&inpAccessLevel=3 HTTP/1.1" 200 689

If DataGrid has 0 records, or more records than a screen, only one request is issued to retrieve data.

This behaviour has been tested under Firefox 2.0 and IE 6.0, and occurs in 2.35 and 2.40
Steps To ReproduceNavigate to:
Master Data Management > Product > Grid View

or

General Setup > Application > Currency > Search Records > ISO Code: ESP > OK
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0005365 closedshuehner Under some circumstances, DataGrid performs two identical queries to retrieve the data 

-  Notes
(0010763)
svnbot (reporter)
2008-11-27 11:23

 Repository: openbravo
Revision: 10661
Author: iperdomo
Date: 2008-11-27 11:23:22 +0100 (Thu, 27 Nov 2008)

Fixes issue 5366: Reduced the pageSize to the number of available rows, to prevent the double request

---
U branches/r2.40performance/web/js/openbravo/widget/DataGrid.js
---

https://dev.openbravo.com/websvn/openbravo/?rev=10661&sc=1 [^]
(0012751)
psarobe (manager)
2009-01-28 16:45

 This was committed in trunk + r2.40 but later thrown out again as it had some side-effects (errors).
(0012855)
shuehner (administrator)
2009-01-29 18:24

 We did verify the bug and the datagrid does not request the same data twice and does not discard one of the answers.
This is not directly visible as the interesting parameters are transmitted as post parameters and not visible in the request-url.
When looking at the post parameters it can be seen that the DataGrid.js does request two non-overlapping regions which are centered around the targeted line/offset. This is done to request not only the visible records but also the page before and after the visible records to be able to scroll for one page before requesting new data again.

Thus this issue not as is not valid as two different, adjecent record-range are requested and both are used on the client side.
This is the reason for closing this defect.

However we opened a new feature request (0007242), as using a single bigger request two fetch both regions in one batch will probably/likely improve the performance.

- Issue History
Date Modified Username Field Change
2008-10-01 18:05 cromero New Issue
2008-10-01 18:05 cromero Assigned To => shuehner
2008-10-01 18:05 cromero Status new => scheduled
2008-10-02 09:47 opablo Issue Monitored: opablo
2008-10-02 09:48 opablo Issue End Monitor: opablo
2008-11-26 21:25 iperdomo fix_in_branch 2.40 => 2.40-performance
2008-11-26 21:25 iperdomo Description Updated
2008-11-26 21:25 iperdomo Proposed Solution updated
2008-11-27 11:23 svnbot Checkin
2008-11-27 11:23 svnbot Note Added: 0010763
2008-11-27 11:23 svnbot Status scheduled => resolved
2008-11-27 11:23 svnbot Resolution open => fixed
2008-11-27 11:23 svnbot svn_revision => 10661
2009-01-28 16:45 psarobe Status resolved => new
2009-01-28 16:45 psarobe Resolution fixed => open
2009-01-28 16:45 psarobe Note Added: 0012751
2009-01-29 18:24 shuehner Regression testing => No
2009-01-29 18:24 shuehner Status new => closed
2009-01-29 18:24 shuehner Note Added: 0012855
2009-01-29 18:24 shuehner Resolution open => no change required

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker