Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0005365
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] I. Performanceminoralways2008-10-01 17:582009-01-29 18:24
ReporteropabloView Statuspublic 
Assigned Toshuehner 
PriorityurgentResolutionno change requiredFixed in Version
StatusclosedFix in branchFixed in SCM revision10660
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseOracleJava version1.5
OS VersionDatabase versionAnt version1.7
Product Version2.40SCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0005365: Under some circumstances, DataGrid performs two identical queries to retrieve the data

DescriptionWhen the number of registers of a DataGrid is less than a screen, to fill the DataGrid, two identical requests are issued. Seems that valid data from first request are discarded, and data from second request (same results than the first one) is actually showed in DataGrid.

We see the 2 requests in the server's access log:
127.0.0.1 - - [01/Oct/2008:17:57:16 +0200] "POST /openbravo/utility/DataGrid.html?Command=DATA&inpadTabId=180&inpadWindowId=140&inpAccessLevel=3 HTTP/1.1" 200 689
127.0.0.1 - - [01/Oct/2008:17:57:16 +0200] "POST /openbravo/utility/DataGrid.html?Command=DATA&inpadTabId=180&inpadWindowId=140&inpAccessLevel=3 HTTP/1.1" 200 689

If DataGrid has 0 records, or more records than a screen, only one request is issued to retrieve data.

This behaviour has been tested under Firefox 2.0 and IE 6.0, and occurs in 2.35 and 2.40
Steps To ReproduceNavigate to:
Master Data Management > Product > Grid View

or

General Setup > Application > Currency > Search Records > ISO Code: ESP > OK
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to feature request 0007242 closedshuehner Optimize DataGrid fetch logic to use one bigger request instead of two distinct small request 
depends on backport 0005366 closedshuehner Under some circumstances, DataGrid performs two identical queries to retrieve the data 

-  Notes
(0010059)
pnuding (reporter)
2008-11-07 08:57

Issue is scheduled for resolution in Sprint 3 of the Performance project - as discussed with PJuvara reduced priority to urgent to avoid confusion
(0010762)
svnbot (reporter)
2008-11-27 11:20

Repository: openbravo
Revision: 10660
Author: iperdomo
Date: 2008-11-27 11:20:51 +0100 (Thu, 27 Nov 2008)

Fixes issue 5365: Added reduced the pageSize to the number of available rows, to prevent the double request

---
U trunk/web/js/openbravo/widget/DataGrid.js
---

https://dev.openbravo.com/websvn/openbravo/?rev=10660&sc=1 [^]
(0012753)
psarobe (manager)
2009-01-28 16:45

This was committed in trunk + r2.40 but later thrown out again as it had some side-effects (errors).
(0012854)
shuehner (administrator)
2009-01-29 18:24

We did verify the bug and the datagrid does not request the same data twice and does not discard one of the answers.
This is not directly visible as the interesting parameters are transmitted as post parameters and not visible in the request-url.
When looking at the post parameters it can be seen that the DataGrid.js does request two non-overlapping regions which are centered around the targeted line/offset. This is done to request not only the visible records but also the page before and after the visible records to be able to scroll for one page before requesting new data again.

Thus this issue not as is not valid as two different, adjecent record-range are requested and both are used on the client side.
This is the reason for closing this defect.

However we opened a new feature request (0007242), as using a single bigger request two fetch both regions in one batch will probably/likely improve the performance.

- Issue History
Date Modified Username Field Change
2008-10-01 17:58 opablo New Issue
2008-10-01 17:58 opablo Assigned To => cromero
2008-10-01 17:58 opablo sf_bug_id 0 => 2140621
2008-10-01 18:05 cromero Status new => scheduled
2008-10-01 18:05 cromero Assigned To cromero => shuehner
2008-10-01 18:05 cromero fix_in_branch => trunk
2008-10-02 09:48 opablo Issue Monitored: opablo
2008-10-02 13:58 pjuvara Priority normal => high
2008-10-30 15:15 pjuvara Priority high => immediate
2008-11-07 08:57 pnuding Note Added: 0010059
2008-11-07 08:57 pnuding Priority immediate => urgent
2008-11-07 08:57 pnuding fix_in_branch trunk =>
2008-11-27 11:20 svnbot Checkin
2008-11-27 11:20 svnbot Note Added: 0010762
2008-11-27 11:20 svnbot Status scheduled => resolved
2008-11-27 11:20 svnbot Resolution open => fixed
2008-11-27 11:20 svnbot svn_revision => 10660
2009-01-28 16:45 psarobe Status resolved => new
2009-01-28 16:45 psarobe Resolution fixed => open
2009-01-28 16:45 psarobe Note Added: 0012753
2009-01-29 18:18 shuehner Relationship added related to 0007242
2009-01-29 18:24 shuehner Regression testing => No
2009-01-29 18:24 shuehner Status new => closed
2009-01-29 18:24 shuehner Note Added: 0012854
2009-01-29 18:24 shuehner Resolution open => no change required


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker