Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0053653 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Quotations | major | always | 2023-10-12 18:15 | 2023-11-16 14:25 | |||
| Reporter | Leosbanis | View Status | public | |||||
| Assigned To | Rajesh_18 | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0053653: The ExtraProperties entity is not correctly updated in the response call after a quotation has been transformed into a order | |||||||
| Description | Some months ago, it was requested to include the entity “extraProperties” in the request call (in case it has been previously replied in a response call) so that the middleware receives this information, and they can manage the discounts added properly in any future call for the same order, that has already a external discount added to the ticket. Therefore, if in a “response” call, the extraProperties is filled, this entity will be included in any future request call inside the object “ManualPromotions”. If we create a quotation and we add an automatic discount (which has a extraProperties received in the call), if we transform the quotation into a order and we try to confirm the order or add a discount, in the API Calculate discount request call sent to the middleware, the "extraProperties" entity received previously is not included in the call. | |||||||
| Steps To Reproduce | 1- Create a Quotation including a product that can be added to a discount returned by the external system discount. 2- Click on the payment button to launch the External System Calculate discount API and confirm the quotation. 3- Click on the menu button to transform the quotation into an order "Create Sales Order" 4- Click on the "Discount" button to add a discount - launch "API Calculate discount" | |||||||
| Proposed Solution | When a Quotation is transformed into an Order the ID of the order and lines are changed but the information contained into the "order.cdiscExternalresponse" remains with the old values and this information is used to compose the request to the External System Discount API, so the proposal consist in create a hook implementation for "OBPOS_PreCreateOrderFromQuotation" that update this information with the new values of ID. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  file.pdf [^] (733,322 bytes) 2023-10-12 18:15 | |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0156268) hgbot (developer) 2023-10-25 10:06 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.discounts/-/merge_requests/6 [^] |
|
(0156269) hgbot (developer) 2023-10-25 10:10 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1389 [^] |
|
(0156270) hgbot (developer) 2023-10-25 10:13 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/121 [^] |
|
(0157221) hgbot (developer) 2023-11-16 14:24 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^] Changeset: 48628a91eba9ddd65eb2d2fdf6c1f5631d755ea3 Author: Rajesh Senthilkumar <rajesh@qualiantech.com> Date: 15-11-2023 09:28:15 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/48628a91eba9ddd65eb2d2fdf6c1f5631d755ea3 [^] Related ISSUE-53653: ExtraProperties is updated after quotation converted to order --- M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/interface/discount-posinterface.js --- |
|
(0157222) hgbot (developer) 2023-11-16 14:24 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/121 [^] |
|
(0157223) hgbot (developer) 2023-11-16 14:24 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 4540e20de63cb1e86aa9349ed5bb2b7ff721bd52 Author: Rajesh Senthilkumar <rajesh@qualiantech.com> Date: 16-11-2023 09:12:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/4540e20de63cb1e86aa9349ed5bb2b7ff721bd52 [^] Related ISSUE-53653: ExtraProperties is updated after quotation converted to order --- M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CreateTicketFromQuotation.js --- |
|
(0157224) hgbot (developer) 2023-11-16 14:24 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1389 [^] |
|
(0157225) hgbot (developer) 2023-11-16 14:25 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.discounts [^] Changeset: c440de3e6bb397dad715b407208b60916355445a Author: Rajesh Senthilkumar <rajesh@qualiantech.com> Date: 15-11-2023 09:29:03 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.discounts/-/commit/c440de3e6bb397dad715b407208b60916355445a [^] Fixes ISSUE-53653: ExtraProperties is updated after quotation converted to order --- M web/org.openbravo.events.discounts/app/model/business-object/ticket/actions/CreateTicketFromQuotation.js --- |
|
(0157226) hgbot (developer) 2023-11-16 14:25 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.discounts/-/merge_requests/6 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2023-10-12 18:15 | Leosbanis | New Issue | |
| 2023-10-12 18:15 | Leosbanis | Assigned To | => Retail |
| 2023-10-12 18:15 | Leosbanis | File Added: file.pdf | |
| 2023-10-12 18:15 | Leosbanis | Triggers an Emergency Pack | => No |
| 2023-10-17 12:44 | Rajesh_18 | Assigned To | Retail => Rajesh_18 |
| 2023-10-17 13:05 | Rajesh_18 | Status | new => scheduled |
| 2023-10-25 10:06 | hgbot | Note Added: 0156268 | |
| 2023-10-25 10:10 | hgbot | Note Added: 0156269 | |
| 2023-10-25 10:13 | hgbot | Note Added: 0156270 | |
| 2023-11-16 14:24 | hgbot | Note Added: 0157221 | |
| 2023-11-16 14:24 | hgbot | Note Added: 0157222 | |
| 2023-11-16 14:24 | hgbot | Note Added: 0157223 | |
| 2023-11-16 14:24 | hgbot | Note Added: 0157224 | |
| 2023-11-16 14:25 | hgbot | Resolution | open => fixed |
| 2023-11-16 14:25 | hgbot | Status | scheduled => closed |
| 2023-11-16 14:25 | hgbot | Note Added: 0157225 | |
| 2023-11-16 14:25 | hgbot | Note Added: 0157226 | |
| 2023-11-16 14:35 | aaroncalero | Relationship added | related to 0053965 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |