Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0053582
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Adyenmajoralways2023-10-03 16:422023-10-09 16:51
ReportersofidossantView Statuspublic 
Assigned Toignacio_deandres 
PriorityhighResolutionfixedFixed in VersionRR22Q4.2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Support ticket76857
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0053582: Error in Adyen payment integration after paying with cash

DescriptionIf we apply the patch of the issue https://issues.openbravo.com/view.php?id=51472 [^]

If I first add a cash payment method and then pay by card, the following error occurs:
Cannot read properties of undefined (reading 'provider')
Steps To Reproduce1- Apply issue 51472
2- Go to the webpos
3- Add a product
4- Add a partial payment with cash
5 - Add payment with carte, you can see the error
Proposed SolutionThe error is in this part

      } else {
        adyenPayment = payments.find(
          p =>
            p.paymentData.provider &&
            p.paymentData.provider.provider === 'ADY_ADYENPROVIDER'
        );
        if (adyenPayment) {
          paymentRequest.SaleData.SaleTransactionID.TransactionID =
            adyenPayment.paymentData.informationValues[0].value;
        } else {
          paymentRequest.SaleData.SaleTransactionID.TransactionID = getUUID();
        }


We need to add the control for paymetData
p.paymentData.provider
TagsNo tags attached.
Attached Filespng file icon Captura de pantalla (4).png [^] (577,879 bytes) 2023-10-03 16:42

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by feature request 0051472 closedignacio_deandres Referenced Refund through Adyen 
related to defect 0053707 closedadrianromero Another error next to add this fix https://issues.openbravo.com/view.php?id=53582 [^] 

-  Notes
(0155487)
adrianromero (viewer)
2023-10-04 10:55

 What version or repository is the patch applied?
(0155501)
sofidossant (viewer)
2023-10-04 13:33

 https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.adyenprovider/-/commit/a75c35fc141df03af95829c625fc079591493335 [^]

Version for the module
1.0.233000
(0155645)
hgbot (developer)
2023-10-06 15:22

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.adyenprovider/-/merge_requests/32 [^]
(0155703)
hgbot (developer)
2023-10-09 16:51

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.adyenprovider [^]
Changeset: facdb06606c73ab9ef85b76942002ece7e4aada7
Author: Ignacio De Andres <ignacio.deandres@openbravo.com>
Date: 06-10-2023 15:21:14
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.adyenprovider/-/commit/facdb06606c73ab9ef85b76942002ece7e4aada7 [^]

Fixes ISSUE-53582: fixed error launched when a partial payment was done with another payment method and then the adyen payment method was used to pay the remaining amount.

---
M web/org.openbravo.retail.adyenprovider/source/provider/paymentprovider.js
---
(0155704)
hgbot (developer)
2023-10-09 16:51

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.adyenprovider/-/merge_requests/32 [^]

- Issue History
Date Modified Username Field Change
2023-10-03 16:42 sofidossant New Issue
2023-10-03 16:42 sofidossant Assigned To => Triage Platform Conn
2023-10-03 16:42 sofidossant File Added: Captura de pantalla (4).png
2023-10-03 16:42 sofidossant OBNetwork customer => OBPS
2023-10-03 16:42 sofidossant Support ticket => 76857
2023-10-03 16:42 sofidossant Triggers an Emergency Pack => No
2023-10-03 16:42 sofidossant Fixed in Version => RR22Q4.2
2023-10-04 10:51 adrianromero Assigned To Triage Platform Conn => ignacio_deandres
2023-10-04 10:51 adrianromero Summary Error with issue https://issues.openbravo.com/view.php?id=51472 [^] => Error code in Customer edition window
2023-10-04 10:52 adrianromero Relationship added caused by 0051472
2023-10-04 10:54 adrianromero Summary Error code in Customer edition window => Error in Adyen payment integration after paying with cash
2023-10-04 10:55 adrianromero Note Added: 0155487
2023-10-04 10:55 adrianromero Status new => feedback
2023-10-04 13:33 sofidossant Note Added: 0155501
2023-10-04 13:33 sofidossant Status feedback => new
2023-10-06 15:22 hgbot Merge Request Status => open
2023-10-06 15:22 hgbot Note Added: 0155645
2023-10-09 16:49 hgbot Merge Request Status open => approved
2023-10-09 16:51 hgbot Resolution open => fixed
2023-10-09 16:51 hgbot Status new => closed
2023-10-09 16:51 hgbot Note Added: 0155703
2023-10-09 16:51 hgbot Note Added: 0155704
2023-11-07 12:20 rafaroda Relationship added related to 0053707

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker