Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053582Retail ModulesAdyenpublic2023-10-03 16:422023-10-09 16:51
Reportersofidossant 
Assigned Toignacio_deandres 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR22Q4.2 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053582: Error in Adyen payment integration after paying with cash
DescriptionIf we apply the patch of the issue https://issues.openbravo.com/view.php?id=51472 [^]

If I first add a cash payment method and then pay by card, the following error occurs:
Cannot read properties of undefined (reading 'provider')
Steps To Reproduce1- Apply issue 51472
2- Go to the webpos
3- Add a product
4- Add a partial payment with cash
5 - Add payment with carte, you can see the error
Proposed SolutionThe error is in this part

      } else {
        adyenPayment = payments.find(
          p =>
            p.paymentData.provider &&
            p.paymentData.provider.provider === 'ADY_ADYENPROVIDER'
        );
        if (adyenPayment) {
          paymentRequest.SaleData.SaleTransactionID.TransactionID =
            adyenPayment.paymentData.informationValues[0].value;
        } else {
          paymentRequest.SaleData.SaleTransactionID.TransactionID = getUUID();
        }


We need to add the control for paymetData
p.paymentData.provider
Additional Information
TagsNo tags attached.
Relationships
caused by feature request 0051472 closed ignacio_deandres Referenced Refund through Adyen 
related to defect 0053707 closed adrianromero Another error next to add this fix https://issues.openbravo.com/view.php?id=53582 [^] 
Attached Filespng Captura de pantalla (4).png (577,879) 2023-10-03 16:42
https://issues.openbravo.com/file_download.php?file_id=19008&type=bug
Issue History
Date ModifiedUsernameFieldChange
2023-10-03 16:42sofidossantNew Issue
2023-10-03 16:42sofidossantAssigned To => Triage Platform Conn
2023-10-03 16:42sofidossantFile Added: Captura de pantalla (4).png
2023-10-03 16:42sofidossantTriggers an Emergency Pack => No
2023-10-03 16:42sofidossantFixed in Version => RR22Q4.2
2023-10-04 10:51adrianromeroAssigned ToTriage Platform Conn => ignacio_deandres
2023-10-04 10:51adrianromeroSummaryError with issue https://issues.openbravo.com/view.php?id=51472 [^] => Error code in Customer edition window
2023-10-04 10:52adrianromeroRelationship addedcaused by 0051472
2023-10-04 10:54adrianromeroSummaryError code in Customer edition window => Error in Adyen payment integration after paying with cash
2023-10-04 10:55adrianromeroNote Added: 0155487
2023-10-04 10:55adrianromeroStatusnew => feedback
2023-10-04 13:33sofidossantNote Added: 0155501
2023-10-04 13:33sofidossantStatusfeedback => new
2023-10-06 15:22hgbotNote Added: 0155645
2023-10-09 16:51hgbotResolutionopen => fixed
2023-10-09 16:51hgbotStatusnew => closed
2023-10-09 16:51hgbotNote Added: 0155703
2023-10-09 16:51hgbotNote Added: 0155704
2023-11-07 12:20rafarodaRelationship addedrelated to 0053707

Notes
(0155487)
adrianromero   
2023-10-04 10:55   
What version or repository is the patch applied?
(0155501)
sofidossant   
2023-10-04 13:33   
https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.adyenprovider/-/commit/a75c35fc141df03af95829c625fc079591493335 [^]

Version for the module
1.0.233000
(0155645)
hgbot   
2023-10-06 15:22   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.adyenprovider/-/merge_requests/32 [^]
(0155703)
hgbot   
2023-10-09 16:51   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.adyenprovider [^]
Changeset: facdb06606c73ab9ef85b76942002ece7e4aada7
Author: Ignacio De Andres <ignacio.deandres@openbravo.com>
Date: 06-10-2023 15:21:14
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.adyenprovider/-/commit/facdb06606c73ab9ef85b76942002ece7e4aada7 [^]

Fixes ISSUE-53582: fixed error launched when a partial payment was done with another payment method and then the adyen payment method was used to pay the remaining amount.

---
M web/org.openbravo.retail.adyenprovider/source/provider/paymentprovider.js
---
(0155704)
hgbot   
2023-10-09 16:51   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.adyenprovider/-/merge_requests/32 [^]