Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0053498
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSmajorhave not tried2023-09-20 10:032024-05-07 16:27
ReportercbernerView Statuspublic 
Assigned ToRetail 
PrioritynormalResolutionopenFixed in Version
StatusnewFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version24Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression levelProduction - QA Approved
Regression date2023-08-10
Regression introduced in release23Q3
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/b1b36743cb98217957f2bc92ba97d66c2292935e [^]
Triggers an Emergency PackNo
Summary

0053498: Add and remove service associations does not allow selecting lines

DescriptionIt is not possible to select any line in the process to add or remove service associations, resulting in these processes not working properly.

Two gifs have been provided, showing how it works in 23Q2.3 and how it fails to work starting from 23Q3.
Steps To Reproduce1. Login WebPOS (23Q3+): https://livebuilds.openbravo.com/context/pos2_mp_23Q3/web/pos/?terminal=VBS-2 [^]
2. Add a GPS Mini product to the ticket, and any of the warranty services that appear. Finish the service selection.
3. Click on the Warranty service product ticket line, then click on "Remove Associations", see that lines can't be selected.

An environment where it is working properly is available on version 23Q2.3 -> https://livebuilds.openbravo.com/context/pos2_mp_23Q2.3/web/pos/?terminal=VBS-2 [^]
TagsNo tags attached.
Attached Filesgif file icon removeAssocitionsFailing.gif [^] (442,589 bytes) 2023-09-20 10:03
gif file icon removeAssociationsWorking.gif [^] (876,843 bytes) 2023-09-20 10:05

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by defect 0052435 closedAugustoMauch When a grid has selected records and is sorted, different records are then selected 

-  Notes
(0158183)
sreehari (developer)
2023-12-14 08:53

 After discussing with Guillermo Alvarez, I'm adding my analysis for this issue, and this needs to be fixed by the Platform team.

Related to this issue, trying to fix this, I found the following causes...

Relted to this Issue https://issues.openbravo.com/view.php?id=52435, [^] the following commits
-https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1098/diffs#ab36ba8b39bdb571549e3add9a1411be653d8a73_231_233 [^]
-https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/components/Grid/stories/GridSampleData.js#L402 [^]

the above commits, added a new field id for the rows with checkboxes, and the sample containing id 1,2,3.,,

Due to above fix, in our current issue,
https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/components/Service/ServiceAssociationsGrid/ServiceAssociationsGrid.jsx#L85 [^]
-apiRefs.current -> this object will have keys of the rowIndex selected, which would be 0, 1 2 for number of rows respectively... In our case it would be uuid, and it should expected to work anyways...

But even after my fix, adding the id to the rows, in below commits
https://gitlab.com/openbravo/devel/pmods/org.openbravo.core2/-/commit/1226cdfbfb801aa1a1c84bb42a68cd11adf50937 [^]
https://gitlab.com/openbravo/devel/pmods/org.openbravo.pos2/-/commit/d9d1353baa96cd65a91b7dc0eec950a31562deff [^]

-I'm still unable to fix the issue, since the UUID didnt select all the parent columns respectively.
-The issue after my fixes commits are as follows
    -the collapsible button didnt work to collapse the below rows,
    -the error while clicking the parent checkbox is gone, but still the checkbox remains unchecked
    -though the checkbox is unchecked, it seems when u click the finish button the product gets removed
-Hope this helps.

Video Link after my fix:
https://drive.google.com/file/d/1NaUYtKpYJ0Q85mvu3iUtwm4U3PBLBUuv/view?usp=sharing [^]

- Issue History
Date Modified Username Field Change
2023-09-20 10:03 cberner New Issue
2023-09-20 10:03 cberner Assigned To => Retail
2023-09-20 10:03 cberner File Added: removeAssocitionsFailing.gif
2023-09-20 10:03 cberner Regression level => Production - QA Approved
2023-09-20 10:03 cberner Regression date => 2023-08-10
2023-09-20 10:03 cberner Regression introduced in release => 23Q3
2023-09-20 10:03 cberner Triggers an Emergency Pack => No
2023-09-20 10:05 cberner File Added: removeAssociationsWorking.gif
2023-09-20 10:10 cberner Steps to Reproduce Updated View Revisions
2023-09-20 13:54 sreehari Assigned To Retail => sreehari
2023-09-22 08:24 sreehari Status new => scheduled
2023-09-22 11:10 sreehari Regression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/b1b36743cb98217957f2bc92ba97d66c2292935e [^]
2023-12-14 07:21 sreehari Relationship added caused by 0052435
2023-12-14 08:53 sreehari Note Added: 0158183
2023-12-14 08:54 sreehari Assigned To sreehari => Retail
2023-12-14 08:54 sreehari Status scheduled => acknowledged
2023-12-14 08:55 sreehari Status acknowledged => scheduled
2023-12-14 08:55 sreehari Status scheduled => resolved
2023-12-14 08:55 sreehari Resolution open => fixed
2023-12-14 08:55 sreehari Status resolved => new
2023-12-14 08:55 sreehari Resolution fixed => open
2024-05-07 16:27 lorenzofidalgo Target Version => 24Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker