Openbravo Issue Tracking System - POS2 |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0053498 | POS2 | POS | public | 2023-09-20 10:03 | 2024-06-22 11:11 |
|
| Reporter | cberner | |
| Assigned To | AugustoMauch | |
| Priority | normal | Severity | major | Reproducibility | have not tried |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | 24Q2 | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Support ticket | |
| Regression level | Production - QA Approved |
| Regression date | 2023-08-10 |
| Regression introduced in release | 23Q3 |
| Regression introduced by commit | https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/b1b36743cb98217957f2bc92ba97d66c2292935e [^] |
| Triggers an Emergency Pack | No |
|
| Summary | 0053498: Add and remove service associations does not allow selecting lines |
| Description | It is not possible to select any line in the process to add or remove service associations, resulting in these processes not working properly.
Two gifs have been provided, showing how it works in 23Q2.3 and how it fails to work starting from 23Q3. |
| Steps To Reproduce | 1. Login WebPOS (23Q3+): https://livebuilds.openbravo.com/context/pos2_mp_23Q3/web/pos/?terminal=VBS-2 [^]
2. Add a GPS Mini product to the ticket, and any of the warranty services that appear. Finish the service selection.
3. Click on the Warranty service product ticket line, then click on "Remove Associations", see that lines can't be selected.
An environment where it is working properly is available on version 23Q2.3 -> https://livebuilds.openbravo.com/context/pos2_mp_23Q2.3/web/pos/?terminal=VBS-2 [^] |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | | depends on | backport | 0055814 | 24Q2 | closed | AugustoMauch | Add and remove service associations does not allow selecting lines | | depends on | backport | 0055815 | 24Q1.3 | scheduled | AugustoMauch | Add and remove service associations does not allow selecting lines | | caused by | defect | 0052435 | | closed | AugustoMauch | When a grid has selected records and is sorted, different records are then selected | | Not all the children of this issue are yet resolved or closed. |
|
| Attached Files |  removeAssocitionsFailing.gif (442,589) 2023-09-20 10:03
https://issues.openbravo.com/file_download.php?file_id=18973&type=bug
removeAssociationsWorking.gif (876,843) 2023-09-20 10:05
https://issues.openbravo.com/file_download.php?file_id=18974&type=bug |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2023-09-20 10:03 | cberner | New Issue | |
| 2023-09-20 10:03 | cberner | Assigned To | => Retail |
| 2023-09-20 10:03 | cberner | File Added: removeAssocitionsFailing.gif | |
| 2023-09-20 10:03 | cberner | Regression level | => Production - QA Approved |
| 2023-09-20 10:03 | cberner | Regression date | => 2023-08-10 |
| 2023-09-20 10:03 | cberner | Regression introduced in release | => 23Q3 |
| 2023-09-20 10:03 | cberner | Triggers an Emergency Pack | => No |
| 2023-09-20 10:05 | cberner | File Added: removeAssociationsWorking.gif | |
| 2023-09-20 10:10 | cberner | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=26855#r26855 |
| 2023-09-20 13:54 | sreehari | Assigned To | Retail => sreehari |
| 2023-09-22 08:24 | sreehari | Status | new => scheduled |
| 2023-09-22 11:10 | sreehari | Regression introduced by commit | => https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/b1b36743cb98217957f2bc92ba97d66c2292935e [^] |
| 2023-12-14 07:21 | sreehari | Relationship added | caused by 0052435 |
| 2023-12-14 08:53 | sreehari | Note Added: 0158183 | |
| 2023-12-14 08:54 | sreehari | Assigned To | sreehari => Retail |
| 2023-12-14 08:54 | sreehari | Status | scheduled => acknowledged |
| 2023-12-14 08:55 | sreehari | Status | acknowledged => scheduled |
| 2023-12-14 08:55 | sreehari | Status | scheduled => resolved |
| 2023-12-14 08:55 | sreehari | Resolution | open => fixed |
| 2023-12-14 08:55 | sreehari | Status | resolved => new |
| 2023-12-14 08:55 | sreehari | Resolution | fixed => open |
| 2024-05-07 16:27 | lorenzofidalgo | Target Version | => 24Q2 |
| 2024-05-22 10:45 | guilleaer | Status | new => acknowledged |
| 2024-05-22 10:52 | guilleaer | Status | acknowledged => scheduled |
| 2024-05-22 10:52 | guilleaer | Status | scheduled => resolved |
| 2024-05-22 10:52 | guilleaer | Resolution | open => fixed |
| 2024-05-22 10:53 | guilleaer | Assigned To | Retail => Triage Platform Base |
| 2024-05-22 10:53 | guilleaer | Status | resolved => new |
| 2024-05-22 10:53 | guilleaer | Resolution | fixed => open |
| 2024-05-30 11:23 | hgbot | Note Added: 0165308 | |
| 2024-06-10 12:54 | AugustoMauch | Assigned To | Triage Platform Base => AugustoMauch |
| 2024-06-10 12:54 | AugustoMauch | Status | new => scheduled |
| 2024-06-19 16:23 | hgbot | Note Added: 0166111 | |
| 2024-06-21 11:19 | hgbot | Note Added: 0166191 | |
| 2024-06-21 11:19 | hgbot | Note Added: 0166192 | |
| 2024-06-21 11:19 | hgbot | Note Added: 0166193 | |
| 2024-06-21 11:19 | hgbot | Resolution | open => fixed |
| 2024-06-21 11:19 | hgbot | Status | scheduled => closed |
| 2024-06-21 11:19 | hgbot | Fixed in Version | => 24Q3 |
| 2024-06-21 11:19 | hgbot | Note Added: 0166194 | |
| 2024-06-22 11:11 | AugustoMauch | Status | closed => new |
| 2024-06-22 11:11 | AugustoMauch | Resolution | fixed => open |
| 2024-06-22 11:11 | AugustoMauch | Fixed in Version | 24Q3 => |
| 2024-06-22 11:11 | AugustoMauch | Status | new => scheduled |
| 2024-06-22 11:11 | AugustoMauch | Status | scheduled => resolved |
| 2024-06-22 11:11 | AugustoMauch | Resolution | open => fixed |
| 2024-06-22 11:11 | AugustoMauch | Status | resolved => closed |
|
Notes |
|
|
|
After discussing with Guillermo Alvarez, I'm adding my analysis for this issue, and this needs to be fixed by the Platform team.
Related to this issue, trying to fix this, I found the following causes...
Relted to this Issue https://issues.openbravo.com/view.php?id=52435, [^] the following commits
-https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1098/diffs#ab36ba8b39bdb571549e3add9a1411be653d8a73_231_233 [^]
-https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/components/Grid/stories/GridSampleData.js#L402 [^]
the above commits, added a new field id for the rows with checkboxes, and the sample containing id 1,2,3.,,
Due to above fix, in our current issue,
https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/components/Service/ServiceAssociationsGrid/ServiceAssociationsGrid.jsx#L85 [^]
-apiRefs.current -> this object will have keys of the rowIndex selected, which would be 0, 1 2 for number of rows respectively... In our case it would be uuid, and it should expected to work anyways...
But even after my fix, adding the id to the rows, in below commits
https://gitlab.com/openbravo/devel/pmods/org.openbravo.core2/-/commit/1226cdfbfb801aa1a1c84bb42a68cd11adf50937 [^]
https://gitlab.com/openbravo/devel/pmods/org.openbravo.pos2/-/commit/d9d1353baa96cd65a91b7dc0eec950a31562deff [^]
-I'm still unable to fix the issue, since the UUID didnt select all the parent columns respectively.
-The issue after my fixes commits are as follows
-the collapsible button didnt work to collapse the below rows,
-the error while clicking the parent checkbox is gone, but still the checkbox remains unchecked
-though the checkbox is unchecked, it seems when u click the finish button the product gets removed
-Hope this helps.
Video Link after my fix:
https://drive.google.com/file/d/1NaUYtKpYJ0Q85mvu3iUtwm4U3PBLBUuv/view?usp=sharing [^] |
|
|
|
(0165308)
|
|
hgbot
|
|
2024-05-30 11:23
|
|
|
|
|
(0166111)
|
|
hgbot
|
|
2024-06-19 16:23
|
|
|
|
|
(0166191)
|
|
hgbot
|
|
2024-06-21 11:19
|
|
|
|
|
(0166192)
|
|
hgbot
|
|
2024-06-21 11:19
|
|
|
|
|
(0166193)
|
|
hgbot
|
|
2024-06-21 11:19
|
|
|
|
|
(0166194)
|
|
hgbot
|
|
2024-06-21 11:19
|
|
|