Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0053317

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Gift cards and gift vouchers

major

always

2023-08-29 11:29

2023-09-18 13:15

Reporter

Romain_Gesquiere

View Status

public

Assigned To

Rajesh_18

Priority

high

Resolution

fixed

Fixed in Version

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Linux 64 bit

Database

PostgreSQL

Java version

7.x

OS Version

Openbravo Appliance 14.04

Database version

9.3.x

Ant version

1.9.x

Product Version

main

SCM revision

Review Assigned To

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0053317: Over-consumption of credit note

Description

Reproduced in https://livebuilds.openbravo.com/retail_modules_pgsql_pi [^]

With high latency, we can apply multiple time a credit note and even over-consume it.
Here's the video of reproduction: https://drive.google.com/file/d/1V9KXanLad-vo1LdZlAnt03_ClJkbsb98/view?usp=sharing [^]

We would like to apply a fix in Weldom environment if possible

Steps To Reproduce

-Configure the credit note usage using http://wiki.openbravo.com/wiki/Retail:Gift_Cards/CreditNotes [^]

-Create a credit note
-Set the network in devtool as 'slow 3G'
-Add product and go to payment
-If your credit note is 100€, select for example 95€
-Search the credit note and spam click yours in the list
-Then spam click apply button

Proposed Solution

Setting flag to check if credit note is consuming

Diff:
https://drive.google.com/file/d/1HM1FFN6eIC4FLgVfJOYu8yTdcJi_WYcM/view?usp=sharing [^]

I tested it and it seems to be working, but I am really not sure if this is a good way to fix the problem.

Tags

No tags attached.

68867(1).diff [^] (1,394 bytes) 2023-08-29 11:29 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.giftcards/js/model/GiftCardUtils.js b/web/org.openbravo.retail.giftcards/js/model/GiftCardUtils.js
index 24efadb..ff81715 100644
--- a/web/org.openbravo.retail.giftcards/js/model/GiftCardUtils.js
+++ b/web/org.openbravo.retail.giftcards/js/model/GiftCardUtils.js
@@ -534,6 +534,8 @@
     });
   };
 
+  
+  let isConsumingCreditNote = false;
   var consumeCreditNoteAmount = function(
     keyboard,
     receipt,
@@ -544,6 +546,17 @@
     fail,
     cardId
   ) {
+
+    // Check for ongoing consumption
+  if (isConsumingCreditNote) {
+    if (fail) {
+      fail();
+    }
+    return;
+  }
+  // Set flag
+  isConsumingCreditNote = true;
     if (keyboard && OB.UTIL.isNullOrUndefined(keyboard.model)) {
       if (fail) {
         fail();
@@ -555,6 +568,8 @@
           OB.UTIL.getStackTrace('', false)
       );
       showUnexpectedError();
+      isConsumingCreditNote = false;  // Reset flag
+
       return;
     }
 
@@ -594,6 +609,8 @@
       if (fail) {
         fail();
       }
+      isConsumingCreditNote = false;  // Reset flag
+
     }
 
     function resultConsumeCreditNoteAmount(trx, amt, gftSk, gftId) {
@@ -630,6 +647,8 @@
       if (success) {
         success();
       }
+      isConsumingCreditNote = false;  // Reset flag
+
     }
     OB.UI.GiftCardUtils.service(
       'org.openbravo.retail.giftcards.ConsumeGiftCardAmount',

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0154116) Romain_Gesquiere (developer) 2023-08-29 11:53	Adding Zendesk ticket: https://openbravo.zendesk.com/agent/tickets/73416 [^]

(0154341) hgbot (developer) 2023-09-01 11:32	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/260 [^]

(0154952) hgbot (developer) 2023-09-18 13:15	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^] Changeset: 4e58c9ae96c70ee1b21408967f78129b438f2751 Author: Rajesh Senthilkumar <rajesh@qualiantech.com> Date: 18-09-2023 13:13:16 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/4e58c9ae96c70ee1b21408967f78129b438f2751 [^] Fixes ISSUE-53317: Prevented over-consumption of credit note * Prevented multiple calls while fecthing gift card detail to avoid over-consumption of credit note. --- M web/org.openbravo.retail.giftcards/js/components/GiftCardDialog.js ---

(0154953) hgbot (developer) 2023-09-18 13:15	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/260 [^]

Issue History
Date Modified	Username	Field	Change
2023-08-29 11:29	Romain_Gesquiere	New Issue
2023-08-29 11:29	Romain_Gesquiere	Assigned To	=> Retail
2023-08-29 11:29	Romain_Gesquiere	File Added: 68867(1).diff
2023-08-29 11:29	Romain_Gesquiere	Triggers an Emergency Pack	=> No
2023-08-29 11:53	Romain_Gesquiere	Note Added: 0154116
2023-08-30 08:16	Rajesh_18	Assigned To	Retail => Rajesh_18
2023-08-31 06:38	Rajesh_18	Status	new => scheduled
2023-09-01 09:47	william_vermersch	Issue Monitored: william_vermersch
2023-09-01 11:32	hgbot	Note Added: 0154341
2023-09-18 13:15	hgbot	Resolution	open => fixed
2023-09-18 13:15	hgbot	Status	scheduled => closed
2023-09-18 13:15	hgbot	Note Added: 0154952
2023-09-18 13:15	hgbot	Note Added: 0154953

Copyright © 2000 - 2009 MantisBT Group