Openbravo Issue Tracking System - Retail Modules
View Issue Details
0053317Retail ModulesGift cards and gift voucherspublic2023-08-29 11:292023-09-18 13:15
Romain_Gesquiere 
Rajesh_18 
highmajoralways
closedfixed 
30Openbravo Appliance 14.04
main 
 
approved
Gold
No
0053317: Over-consumption of credit note
Reproduced in https://livebuilds.openbravo.com/retail_modules_pgsql_pi [^]

With high latency, we can apply multiple time a credit note and even over-consume it.
Here's the video of reproduction: https://drive.google.com/file/d/1V9KXanLad-vo1LdZlAnt03_ClJkbsb98/view?usp=sharing [^]

We would like to apply a fix in Weldom environment if possible
-Configure the credit note usage using http://wiki.openbravo.com/wiki/Retail:Gift_Cards/CreditNotes [^]

-Create a credit note
-Set the network in devtool as 'slow 3G'
-Add product and go to payment
-If your credit note is 100€, select for example 95€
-Search the credit note and spam click yours in the list
-Then spam click apply button
Setting flag to check if credit note is consuming

Diff:
https://drive.google.com/file/d/1HM1FFN6eIC4FLgVfJOYu8yTdcJi_WYcM/view?usp=sharing [^]

I tested it and it seems to be working, but I am really not sure if this is a good way to fix the problem.
No tags attached.
diff 68867(1).diff (1,394) 2023-08-29 11:29
https://issues.openbravo.com/file_download.php?file_id=18910&type=bug
Issue History
2023-08-29 11:29Romain_GesquiereNew Issue
2023-08-29 11:29Romain_GesquiereAssigned To => Retail
2023-08-29 11:29Romain_GesquiereFile Added: 68867(1).diff
2023-08-29 11:29Romain_GesquiereOBNetwork customer => Gold
2023-08-29 11:29Romain_GesquiereTriggers an Emergency Pack => No
2023-08-29 11:53Romain_GesquiereNote Added: 0154116
2023-08-30 08:16Rajesh_18Assigned ToRetail => Rajesh_18
2023-08-31 06:38Rajesh_18Statusnew => scheduled
2023-09-01 09:47william_vermerschIssue Monitored: william_vermersch
2023-09-01 11:32hgbotMerge Request Status => open
2023-09-01 11:32hgbotNote Added: 0154341
2023-09-18 13:15hgbotMerge Request Statusopen => approved
2023-09-18 13:15hgbotResolutionopen => fixed
2023-09-18 13:15hgbotStatusscheduled => closed
2023-09-18 13:15hgbotNote Added: 0154952
2023-09-18 13:15hgbotNote Added: 0154953

Notes
(0154116)
Romain_Gesquiere   
2023-08-29 11:53   
Adding Zendesk ticket: https://openbravo.zendesk.com/agent/tickets/73416 [^]
(0154341)
hgbot   
2023-09-01 11:32   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/260 [^]
(0154952)
hgbot   
2023-09-18 13:15   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 4e58c9ae96c70ee1b21408967f78129b438f2751
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 18-09-2023 13:13:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/4e58c9ae96c70ee1b21408967f78129b438f2751 [^]

Fixes ISSUE-53317: Prevented over-consumption of credit note
* Prevented multiple calls while fecthing gift card detail to avoid over-consumption of credit note.

---
M web/org.openbravo.retail.giftcards/js/components/GiftCardDialog.js
---
(0154953)
hgbot   
2023-09-18 13:15   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/260 [^]