Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0052896
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] 00. Application dictionarycriticalalways2023-06-16 02:012023-07-04 07:07
ReporteraxelmercadoView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget VersionPR23Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression levelProduction - QA Approved
Regression date2023-02-15
Regression introduced in releasePR23Q2
Regression introduced by commithttps://gitlab.com/openbravo/product/openbravo/-/commit/ae50b716be895db7f75fad22f3a2cf9bc5981093 [^]
Triggers an Emergency PackNo
Summary

0052896: Problem with 'Product' tab in 'Discounts and promotions' window in a customer without retail

DescriptionA condition corresponding to the Retail Discounts module has been added in the latest versions, it was added in the following issue: https://issues.openbravo.com/view.php?id=50706. [^]
The problem is that it was applied without taking into account the customers that do not have Retail and that can make use of the window.

The filter is 'e.obdiscIsGift=false' and is a where clause found in the 'Product' tab of the 'Discounts and promotions' window.

If an attempt is made to open the window and the tab, an error is generated.
Steps To ReproduceJust try opening the 'Discounts and promotions' window and then the 'Product' tab.

Again to clarify: Only for non-retail customers.
Proposed SolutionThere is no nice way to fix this problem. The proposal would be:
- Remove the display logic from the field in Core
- Add it back for Retail instances, through the Configuration Script in the Retail template.

This will mean that the tabs will not fully work in basic Core, but as those discount filters anyway are not implemented for the backoffice, it should not be a big problem, and in Retail instances it will work correctly.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0052762 closedranjith_qualiantech_com Problem with 'Product' tab in 'Discounts and promotions' window in a customer without retail 

-  Notes
(0152059)
hgbot (developer)
2023-07-03 14:54

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.pack/-/merge_requests/3 [^]
(0152060)
hgbot (developer)
2023-07-03 14:54

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/926 [^]
(0152076)
hgbot (developer)
2023-07-04 07:07

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.pack [^]
Changeset: 8b04fceeb04a498f57955d10081c9ca5c7113894
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 03-07-2023 17:38:53
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.pack/-/commit/8b04fceeb04a498f57955d10081c9ca5c7113894 [^]

Fixed ISSUE-52896: Added HQLWhereClause for Discount Products tab
* Added HQLWhereClause for Discount's Product tab & Gift Products tab
* Discount's Gift Products tab should be displayed if retail pack is present

---
M src-db/database/configScript.xml
---
(0152077)
hgbot (developer)
2023-07-04 07:07

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.pack/-/merge_requests/3 [^]
(0152078)
hgbot (developer)
2023-07-04 07:07

 Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 8da26360e654a707d3b572ebdcafd34ecfb18a8c
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 03-07-2023 17:39:06
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/8da26360e654a707d3b572ebdcafd34ecfb18a8c [^]

Related to ISSUE-52896: Removed HQLWhereCluase from Discounts product tab
* Discount's Gift Products tab should be displayed if retail.pack module is present

---
M src-db/database/sourcedata/AD_TAB.xml
---
(0152079)
hgbot (developer)
2023-07-04 07:07

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/926 [^]

- Issue History
Date Modified Username Field Change
2023-06-30 09:42 marvintm Type defect => backport
2023-06-30 09:42 marvintm Target Version => PR23Q3
2023-07-03 11:42 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2023-07-03 14:54 hgbot Note Added: 0152059
2023-07-03 14:54 hgbot Note Added: 0152060
2023-07-04 07:07 hgbot Resolution open => fixed
2023-07-04 07:07 hgbot Status scheduled => closed
2023-07-04 07:07 hgbot Fixed in Version => RR23Q3
2023-07-04 07:07 hgbot Note Added: 0152076
2023-07-04 07:07 hgbot Note Added: 0152077
2023-07-04 07:07 hgbot Note Added: 0152078
2023-07-04 07:07 hgbot Note Added: 0152079

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker