Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0052762
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 00. Application dictionarycriticalalways2023-06-16 02:012023-07-05 09:09
ReporteraxelmercadoView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Web browser
ModulesCore
Support ticket66717
Regression levelProduction - QA Approved
Regression date2023-02-15
Regression introduced in releasePR23Q2
Regression introduced by commithttps://gitlab.com/openbravo/product/openbravo/-/commit/ae50b716be895db7f75fad22f3a2cf9bc5981093 [^]
Triggers an Emergency PackNo
Summary

0052762: Problem with 'Product' tab in 'Discounts and promotions' window in a customer without retail

DescriptionA condition corresponding to the Retail Discounts module has been added in the latest versions, it was added in the following issue: https://issues.openbravo.com/view.php?id=50706. [^]
The problem is that it was applied without taking into account the customers that do not have Retail and that can make use of the window.

The filter is 'e.obdiscIsGift=false' and is a where clause found in the 'Product' tab of the 'Discounts and promotions' window.

If an attempt is made to open the window and the tab, an error is generated.
Steps To ReproduceJust try opening the 'Discounts and promotions' window and then the 'Product' tab.

Again to clarify: Only for non-retail customers.
Proposed SolutionThere is no nice way to fix this problem. The proposal would be:
- Remove the display logic from the field in Core
- Add it back for Retail instances, through the Configuration Script in the Retail template.

This will mean that the tabs will not fully work in basic Core, but as those discount filters anyway are not implemented for the backoffice, it should not be a big problem, and in Retail instances it will work correctly.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0052896PR23Q3 closedranjith_qualiantech_com Openbravo ERP Problem with 'Product' tab in 'Discounts and promotions' window in a customer without retail 
depends on backport 0052897PR23Q2.2 closedranjith_qualiantech_com Openbravo ERP Problem with 'Product' tab in 'Discounts and promotions' window in a customer without retail 
caused by design defect 0050706 closedprakashmurugesan88 Retail Modules [PROMO] - Product category and Characteristics KO in "Buy X and get Y as a gift" promotion 

-  Notes
(0151995)
hgbot (developer)
2023-07-02 05:40

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/925 [^]
(0151996)
hgbot (developer)
2023-07-02 05:40

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.pack/-/merge_requests/2 [^]
(0152031)
hgbot (developer)
2023-07-03 11:36

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.pack/-/merge_requests/2 [^]
(0152032)
hgbot (developer)
2023-07-03 11:36

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.pack [^]
Changeset: c34a6d7cd4e764c74c09fbd7a9e502ef9e50ec31
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 03-07-2023 11:51:39
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.pack/-/commit/c34a6d7cd4e764c74c09fbd7a9e502ef9e50ec31 [^]

Fixed ISSUE-52762: Added HQLWhereClause for Discount Products tab
* Added HQLWhereClause for Discount's Product tab & Gift Products tab
* Discount's Gift Products tab should be displayed if retail pack is present

---
M src-db/database/configScript.xml
---
(0152033)
hgbot (developer)
2023-07-03 11:36

 Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 3f31f9fc7bbc96e6957e7110bae02149c525ddbc
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 03-07-2023 11:51:33
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/3f31f9fc7bbc96e6957e7110bae02149c525ddbc [^]

Related to ISSUE-52762: Removed HQLWhereCluase from Discounts product tab
* Discount's Gift Products tab should be displayed if retail.pack module is present

---
M src-db/database/sourcedata/AD_TAB.xml
---
(0152034)
hgbot (developer)
2023-07-03 11:36

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/925 [^]

- Issue History
Date Modified Username Field Change
2023-06-16 02:01 axelmercado New Issue
2023-06-16 02:01 axelmercado Assigned To => Triage Platform Base
2023-06-16 02:01 axelmercado OBNetwork customer => OBPS
2023-06-16 02:01 axelmercado Modules => Core
2023-06-16 02:01 axelmercado Support ticket => 66717
2023-06-16 02:01 axelmercado Triggers an Emergency Pack => No
2023-06-21 10:23 AugustoMauch Assigned To Triage Platform Base => Retail
2023-06-23 02:27 axelmercado Priority high => urgent
2023-06-30 09:20 AugustoMauch Regression level => Production - QA Approved
2023-06-30 09:20 AugustoMauch Regression date => 2023-02-15
2023-06-30 09:20 AugustoMauch Regression introduced in release => PR23Q2
2023-06-30 09:20 AugustoMauch Regression introduced by commit => https://gitlab.com/openbravo/product/openbravo/-/commit/ae50b716be895db7f75fad22f3a2cf9bc5981093 [^]
2023-06-30 09:20 AugustoMauch Priority urgent => immediate
2023-06-30 09:20 AugustoMauch Severity major => critical
2023-06-30 09:29 marvintm Proposed Solution updated
2023-06-30 09:42 marvintm Status new => scheduled
2023-06-30 09:42 marvintm Assigned To Retail => ranjith_qualiantech_com
2023-07-02 05:40 hgbot Merge Request Status => open
2023-07-02 05:40 hgbot Note Added: 0151995
2023-07-02 05:40 hgbot Note Added: 0151996
2023-07-03 11:36 hgbot Merge Request Status open => approved
2023-07-03 11:36 hgbot Note Added: 0152031
2023-07-03 11:36 hgbot Resolution open => fixed
2023-07-03 11:36 hgbot Status scheduled => closed
2023-07-03 11:36 hgbot Fixed in Version => RR23Q4
2023-07-03 11:36 hgbot Note Added: 0152032
2023-07-03 11:36 hgbot Note Added: 0152033
2023-07-03 11:36 hgbot Note Added: 0152034
2023-07-05 09:09 rafaroda Relationship added caused by 0050706

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker