0052896: Problem with 'Product' tab in 'Discounts and promotions' window in a customer without retail

Openbravo Issue Tracking System - Openbravo ERP

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0052896

Openbravo ERP

00. Application dictionary

public

2023-06-16 02:01

2023-07-04 07:07

Reporter

axelmercado

Assigned To

ranjith_qualiantech_com

Priority

immediate

Severity

critical

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

PR23Q3

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Web browser

Modules

Core

Support ticket

Regression level

Production - QA Approved

Regression date

2023-02-15

Regression introduced in release

PR23Q2

Regression introduced by commit

https://gitlab.com/openbravo/product/openbravo/-/commit/ae50b716be895db7f75fad22f3a2cf9bc5981093 [^]

Triggers an Emergency Pack

Summary

0052896: Problem with 'Product' tab in 'Discounts and promotions' window in a customer without retail

Description

A condition corresponding to the Retail Discounts module has been added in the latest versions, it was added in the following issue: https://issues.openbravo.com/view.php?id=50706. [^]
The problem is that it was applied without taking into account the customers that do not have Retail and that can make use of the window.

The filter is 'e.obdiscIsGift=false' and is a where clause found in the 'Product' tab of the 'Discounts and promotions' window.

If an attempt is made to open the window and the tab, an error is generated.

Steps To Reproduce

Just try opening the 'Discounts and promotions' window and then the 'Product' tab.

Again to clarify: Only for non-retail customers.

Proposed Solution

There is no nice way to fix this problem. The proposal would be:
- Remove the display logic from the field in Core
- Add it back for Retail instances, through the Configuration Script in the Retail template.

This will mean that the tabs will not fully work in basic Core, but as those discount filters anyway are not implemented for the backoffice, it should not be a big problem, and in Retail instances it will work correctly.

Additional Information