0052863: Change from lodash to underscore causing problems in MessagesManager

Description

Problems occurring in web/org.openbravo.events.client/source/events/messagesmanager.js at processQuery method. The errors occur in two environments so far: POS1 and SMCP test, both with BE Fiscalization. It appears to be caused by the switch from lodash to underscore, specifically the following change: lodash.get() -> _.result().

Steps To Reproduce

1. Configure an Openbravo instance with the Fiscalization BE module (https://docs.google.com/document/d/1XcA_-_RRkVdYDEc3m6RKQmTyRs04pTvnxDTyjUerJ3w/edit [^])
2. Open Chrome dev tools and set a breakpoint in the MessagesManager.processQuery() method wherever the statement 'return _.result()' is executed or execute the statement manually within the method's scope in the following step
3. Attempt a login with the terminal configured in step 1
4. Verify that the function returns 'undefined' for the query

Proposed Solution

Insert a check for string and if so, convert path to array

e.g. return _.result(
          dbobject,
          typeof path === 'string' ? path.split('.') : path
        );

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

caused by	design defect	0051088		closed	adrianromero	Retail Modules	[Payment Limit validation] Event payment limit management should be configurable at organization or touchpoint type level
blocks	defect	0052817		closed	frank_gonzalez	Openbravo Localizations	[BE] MTS appears empty in Sales Order

Notes
(0151719) hgbot (developer) 2023-06-28 10:48	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/merge_requests/32 [^]

(0151925) hgbot (developer) 2023-06-30 09:19	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/merge_requests/32 [^]

(0151926) hgbot (developer) 2023-06-30 09:19	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client [^] Changeset: c84f3ef0dec6e357576484e66324c3f614e5c00d Author: Adrián Romero <adrian.romero@openbravo.com> Date: 28-06-2023 10:47:06 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/commit/c84f3ef0dec6e357576484e66324c3f614e5c00d [^] Fixes ISSUE-52863: Use loadash library to query JS properties using lodash.get() --- M web/org.openbravo.events.client/source/events/messagesmanager.js ---

Issue History
Date Modified	Username	Field	Change
2023-06-27 15:29	frank_gonzalez	New Issue
2023-06-27 15:29	frank_gonzalez	Assigned To	=> Triage Platform Conn
2023-06-27 15:36	frank_gonzalez	Relationship added	caused by 0051088
2023-06-27 16:40	frank_gonzalez	Steps to Reproduce Updated	View Revisions
2023-06-28 10:42	frank_gonzalez	Steps to Reproduce Updated	View Revisions
2023-06-28 10:42	frank_gonzalez	Proposed Solution updated
2023-06-28 10:48	hgbot	Note Added: 0151719
2023-06-28 11:58	psanjuan	Relationship added	blocks 0052817
2023-06-29 10:50	frank_gonzalez	Regression introduced by commit	=> https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/commit/fc6fd1d45c9b21080b0eef91b11b0cfb5bd43e7c [^]
2023-06-30 09:19	hgbot	Note Added: 0151925
2023-06-30 09:19	hgbot	Resolution	open => fixed
2023-06-30 09:19	hgbot	Status	new => closed
2023-06-30 09:19	hgbot	Note Added: 0151926