Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052863ModulesEvents for Clientpublic2023-06-27 15:292023-06-30 09:19
Reporterfrank_gonzalez 
Assigned ToTriage Platform Conn 
PrioritynormalSeveritymajorReproducibilitysometimes
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/commit/fc6fd1d45c9b21080b0eef91b11b0cfb5bd43e7c [^]
Regression level
Review Assigned To
Support ticket
OBNetwork customer
Regression introduced in release
Summary0052863: Change from lodash to underscore causing problems in MessagesManager
DescriptionProblems occurring in web/org.openbravo.events.client/source/events/messagesmanager.js at processQuery method. The errors occur in two environments so far: POS1 and SMCP test, both with BE Fiscalization. It appears to be caused by the switch from lodash to underscore, specifically the following change: lodash.get() -> _.result().
Steps To Reproduce1. Configure an Openbravo instance with the Fiscalization BE module (https://docs.google.com/document/d/1XcA_-_RRkVdYDEc3m6RKQmTyRs04pTvnxDTyjUerJ3w/edit [^])
2. Open Chrome dev tools and set a breakpoint in the MessagesManager.processQuery() method wherever the statement 'return _.result()' is executed or execute the statement manually within the method's scope in the following step
3. Attempt a login with the terminal configured in step 1
4. Verify that the function returns 'undefined' for the query
Proposed SolutionInsert a check for string and if so, convert path to array

e.g. return _.result(
          dbobject,
          typeof path === 'string' ? path.split('.') : path
        );
Additional Information
TagsNo tags attached.
Relationships
caused by design defect 0051088 closed adrianromero Retail Modules [Payment Limit validation] Event payment limit management should be configurable at organization or touchpoint type level 
blocks defect 0052817 closed frank_gonzalez Openbravo Localizations [BE] MTS appears empty in Sales Order 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-06-27 15:29frank_gonzalezNew Issue
2023-06-27 15:29frank_gonzalezAssigned To => Triage Platform Conn
2023-06-27 15:36frank_gonzalezRelationship addedcaused by 0051088
2023-06-27 16:40frank_gonzalezSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=26360#r26360
2023-06-28 10:42frank_gonzalezSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=26367#r26367
2023-06-28 10:42frank_gonzalezProposed Solution updated
2023-06-28 10:48hgbotNote Added: 0151719
2023-06-28 11:58psanjuanRelationship addedblocks 0052817
2023-06-29 10:50frank_gonzalezRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/commit/fc6fd1d45c9b21080b0eef91b11b0cfb5bd43e7c [^]
2023-06-30 09:19hgbotNote Added: 0151925
2023-06-30 09:19hgbotResolutionopen => fixed
2023-06-30 09:19hgbotStatusnew => closed
2023-06-30 09:19hgbotNote Added: 0151926

Notes
(0151719)
hgbot   
2023-06-28 10:48   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/merge_requests/32 [^]
(0151925)
hgbot   
2023-06-30 09:19   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/merge_requests/32 [^]
(0151926)
hgbot   
2023-06-30 09:19   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client [^]
Changeset: c84f3ef0dec6e357576484e66324c3f614e5c00d
Author: Adrián Romero <adrian.romero@openbravo.com>
Date: 28-06-2023 10:47:06
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/commit/c84f3ef0dec6e357576484e66324c3f614e5c00d [^]

Fixes ISSUE-52863: Use loadash library to query JS properties using lodash.get()

---
M web/org.openbravo.events.client/source/events/messagesmanager.js
---