Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0052750
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSmajoralways2023-06-15 12:072023-06-30 08:56
ReporteraaroncaleroView Statuspublic 
Assigned Toaaroncalero 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0052750: [Gift Cards] Implement fixes and improvements related to Gift Certificate creation

DescriptionSeveral small topics need to be reviewed:
* A missing test for the Create Gift Certificate user action
* Amount for last-created giftcard persists on the creation popup
* Missing * to indicate mandatory customer if the GC Reason requires it
* Apply button becomes enabled even if the customer is null (when it is required)
* Missing notification/alert indicating the GC has been created correctly
Steps To ReproduceN/A
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to feature request 0052397 closedrocio_nadal Migrate Gift Certificate feature in REACT 
has duplicate defect 0052636 closedjustin_patterson Gift certificates is missing user action 

-  Notes
(0151228)
hgbot (developer)
2023-06-15 18:16

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/245 [^]
(0151250)
hgbot (developer)
2023-06-16 08:42

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 342a9f824b97861108f06157642b4c36ba26d68d
Author: Aaron Calero <aaron.calero@openbravo.com>
Date: 16-06-2023 06:42:19
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/342a9f824b97861108f06157642b4c36ba26d68d [^]

Fixed ISSUE-52750: [ReactPOS] Fixed several issues of the Gift Certificate Creation popup

---
A src-db/database/sourcedata/OBC2_USER_ACTION.xml
A web-jspack/org.openbravo.retail.giftcards/src/model/ticket/user-actions/__test__/CreateGiftCardCertificate.test.js
M src-db/database/sourcedata/AD_MESSAGE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardDialog/GiftCardDialog.jsx
M web-jspack/org.openbravo.retail.giftcards/src/model/ticket/actions/CreateGiftCardCertificate.js
---
(0151251)
hgbot (developer)
2023-06-16 08:42

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/245 [^]
(0151924)
hgbot (developer)
2023-06-30 08:56

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: c48a1a961f6ca6ceba142394a5e666d2c7ea5d31
Author: Aaron Calero <aaron.calero@openbravo.com>
Date: 30-06-2023 08:32:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/c48a1a961f6ca6ceba142394a5e666d2c7ea5d31 [^]

Related to ISSUE-52750: Prevent error if no reasons are defined

---
M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardDialog/GiftCardDialog.jsx
---

- Issue History
Date Modified Username Field Change
2023-06-15 12:07 aaroncalero New Issue
2023-06-15 12:07 aaroncalero Assigned To => aaroncalero
2023-06-15 12:07 aaroncalero Triggers an Emergency Pack => No
2023-06-15 12:07 aaroncalero Relationship added related to 0052397
2023-06-15 12:07 aaroncalero Relationship added related to 0052636
2023-06-15 18:06 aaroncalero Description Updated View Revisions
2023-06-15 18:16 hgbot Note Added: 0151228
2023-06-15 18:21 aaroncalero Relationship deleted related to 0052636
2023-06-15 18:21 aaroncalero Relationship added has duplicate 0052636
2023-06-16 08:14 aaroncalero Status new => scheduled
2023-06-16 08:42 hgbot Resolution open => fixed
2023-06-16 08:42 hgbot Status scheduled => closed
2023-06-16 08:42 hgbot Note Added: 0151250
2023-06-16 08:42 hgbot Note Added: 0151251
2023-06-30 08:56 hgbot Note Added: 0151924


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker