Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0052486
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorsometimes2023-05-18 23:572023-05-22 08:34
ReporteraxelmercadoView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in VersionRR23Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Support ticket64736
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0052486: Problem with ISSUE 50603 change: If the line has no product, then it fails in custom customer modules.

DescriptionWe have seen that in one of the new updates you have added the following in the ob-keyboard.js file:

      if (actualChar && actualChar.match(this.keyMatcher)) {
        const hasGroupedProduct = this.line
          ? this.line.get('product').get('groupProduct')
          : true;
        if ((actualChar === '+' || actualChar === '-') && hasGroupedProduct) {

The problem is that we have our own module that uses the globalKeypressHandler and when pressing a key it gives error because in the this.line the product attribute does not exist.
Steps To ReproduceN/A
Proposed SolutionTo solve it we have added the attached .diff, this way we ensure that if this attribute does not exist it does not give error.
TagsNo tags attached.
Attached Filesdiff file icon ob-keyboard.diff [^] (837 bytes) 2023-05-18 23:57 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by defect 0050603 closedradhakrishnan + key enabled when typing while editing a line 

-  Notes
(0150006)
hgbot (developer)
2023-05-21 16:35

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/526 [^]
(0150035)
hgbot (developer)
2023-05-22 08:34

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/526 [^]
(0150036)
hgbot (developer)
2023-05-22 08:34

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: d56346627516611900bfdd342678a286b306eadc
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 20-05-2023 15:33:43
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/d56346627516611900bfdd342678a286b306eadc [^]

Fixed ISSUE-52486: Added line validation in the global keypress event handler

---
M web/org.openbravo.mobile.core/source/component/ob-keyboard.js
---

- Issue History
Date Modified Username Field Change
2023-05-18 23:57 axelmercado New Issue
2023-05-18 23:57 axelmercado Assigned To => Retail
2023-05-18 23:57 axelmercado File Added: ob-keyboard.diff
2023-05-18 23:57 axelmercado OBNetwork customer => OBPS
2023-05-18 23:57 axelmercado Support ticket => 64736
2023-05-18 23:57 axelmercado Triggers an Emergency Pack => No
2023-05-18 23:57 axelmercado Relationship added caused by 0050603
2023-05-19 07:06 Practics Issue Monitored: Practics
2023-05-20 11:38 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2023-05-20 11:38 ranjith_qualiantech_com Status new => scheduled
2023-05-21 16:35 hgbot Merge Request Status => open
2023-05-21 16:35 hgbot Note Added: 0150006
2023-05-22 08:34 hgbot Merge Request Status open => approved
2023-05-22 08:34 hgbot Resolution open => fixed
2023-05-22 08:34 hgbot Status scheduled => closed
2023-05-22 08:34 hgbot Note Added: 0150035
2023-05-22 08:34 hgbot Fixed in Version => RR23Q3
2023-05-22 08:34 hgbot Note Added: 0150036

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker