0052486: Problem with ISSUE 50603 change: If the line has no product, then it fails in custom customer modules.

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0052486

Retail Modules

Web POS

public

2023-05-18 23:57

2023-05-22 08:34

Reporter

axelmercado

Assigned To

ranjith_qualiantech_com

Priority

normal

Severity

major

Reproducibility

sometimes

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR23Q3

Merge Request Status

approved

Review Assigned To

OBNetwork customer

OBPS

Support ticket

64736

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0052486: Problem with ISSUE 50603 change: If the line has no product, then it fails in custom customer modules.

Description

We have seen that in one of the new updates you have added the following in the ob-keyboard.js file:

      if (actualChar && actualChar.match(this.keyMatcher)) {
        const hasGroupedProduct = this.line
          ? this.line.get('product').get('groupProduct')
          : true;
        if ((actualChar === '+' || actualChar === '-') && hasGroupedProduct) {

The problem is that we have our own module that uses the globalKeypressHandler and when pressing a key it gives error because in the this.line the product attribute does not exist.

Steps To Reproduce

N/A

Proposed Solution

To solve it we have added the attached .diff, this way we ensure that if this attribute does not exist it does not give error.

Additional Information

Tags

No tags attached.

Relationships

caused by

defect

0050603

closed