0052387: Pager on order level gives javascript error when moving to payment step

Description

When doing pager on order level and paying a js error is thrown.

Steps To Reproduce

1) Setup a pager delivery control method and enforce order consolidation.
2) Add a product to the ticket with pager control method
3) Click pay --> it should ask for pager information but instead gives this [1] js error.

[1]
caught (in promise) TypeError: Cannot read properties of undefined (reading 'some')
    at hasMenuItems (DCMConfigurationExtensions.js:37:1)
    at selector (DCMConfigurationExtensions.js:20:1)
    at getFinishStepUserAction (DeliveryControlMethodConfiguration.js:193:1)
    at buildDCMConfiguration (DeliveryControlMethodConfiguration.js:153:1)
    at buildConfiguration (DeliveryControlMethodConfigurationPanel.jsx:23:1)
    at DeliveryControlMethodConfigurationPanel.jsx:30:1
    at invokePassiveEffectCreate (react-dom.development.js:23487:1)
    at HTMLUnknownElement.callCallback (react-dom.development.js:3945:1)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:3994:1)
    at invokeGuardedCallback (react-dom.development.js:4056:1)
    at flushPassiveEffectsImpl (react-dom.development.js:23574:1)
    at unstable_runWithPriority (scheduler.development.js:468:1)
    at runWithPriority$1 (react-dom.development.js:11276:1)
    at flushPassiveEffects (react-dom.development.js:23447:1)
    at performSyncWorkOnRoot (react-dom.development.js:22269:1)
    at react-dom.development.js:11327:1
    at unstable_runWithPriority (scheduler.development.js:468:1)
    at runWithPriority$1 (react-dom.development.js:11276:1)
    at flushSyncCallbackQueueImpl (react-dom.development.js:11322:1)
    at flushSyncCallbackQueue (react-dom.development.js:11309:1)
    at batchedUpdates$1 (react-dom.development.js:22387:1)
    at Object.notify (Subscription.js:19:1)
    at Subscription.notifyNestedSubs (Subscription.js:90:1)
    at Subscription.handleChangeWrapper (Subscription.js:95:1)
    at Object.dispatch (redux.js:222:1)
    at StatePersistence.dispatch (POS2.js:6062:1)

Proposed Solution

Ask for pager information when paying, without encurring an error

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0052385

closed

mtaal

RM-6259: Pager on order level gives javascript error when moving to payment step

Notes
(0149454) hgbot (developer) 2023-05-09 00:06	Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 5eb1fe35aa7cfdedd964fb0ba6dfa4cdd59d6bae Author: Martin Taal <martin.taal@openbravo.com> Date: 09-05-2023 00:06:16 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/5eb1fe35aa7cfdedd964fb0ba6dfa4cdd59d6bae [^] Fixes ISSUE-52387: pass ticket lines in payload to be used in pager configuration step --- M web-jspack/org.openbravo.pos2/src/core/pickupPoint/deliveryControl/pager/PagerDeliveryControlMethod.js ---

Issue History
Date Modified	Username	Field	Change
2023-05-08 17:29	nicola_uva	Type	defect => backport
2023-05-08 17:29	nicola_uva	Target Version	=> 23Q1.3
2023-05-09 00:06	hgbot	Resolution	open => fixed
2023-05-09 00:06	hgbot	Status	scheduled => resolved
2023-05-09 00:06	hgbot	Fixed in Version	=> 23Q1.3
2023-05-09 00:06	hgbot	Note Added: 0149454
2023-05-09 00:07	mtaal	Status	resolved => closed