0052387: Pager on order level gives javascript error when moving to payment step

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0052387

POS2

POS

public

2023-05-08 17:20

2023-05-09 00:07

Reporter

mtaal

Assigned To

mtaal

Priority

normal

Severity

major

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

23Q1.3

Fixed in Version

23Q1.3

Merge Request Status

open

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0052387: Pager on order level gives javascript error when moving to payment step

Description

When doing pager on order level and paying a js error is thrown.

Steps To Reproduce

1) Setup a pager delivery control method and enforce order consolidation.
2) Add a product to the ticket with pager control method
3) Click pay --> it should ask for pager information but instead gives this [1] js error.

[1]
caught (in promise) TypeError: Cannot read properties of undefined (reading 'some')
    at hasMenuItems (DCMConfigurationExtensions.js:37:1)
    at selector (DCMConfigurationExtensions.js:20:1)
    at getFinishStepUserAction (DeliveryControlMethodConfiguration.js:193:1)
    at buildDCMConfiguration (DeliveryControlMethodConfiguration.js:153:1)
    at buildConfiguration (DeliveryControlMethodConfigurationPanel.jsx:23:1)
    at DeliveryControlMethodConfigurationPanel.jsx:30:1
    at invokePassiveEffectCreate (react-dom.development.js:23487:1)
    at HTMLUnknownElement.callCallback (react-dom.development.js:3945:1)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:3994:1)
    at invokeGuardedCallback (react-dom.development.js:4056:1)
    at flushPassiveEffectsImpl (react-dom.development.js:23574:1)
    at unstable_runWithPriority (scheduler.development.js:468:1)
    at runWithPriority$1 (react-dom.development.js:11276:1)
    at flushPassiveEffects (react-dom.development.js:23447:1)
    at performSyncWorkOnRoot (react-dom.development.js:22269:1)
    at react-dom.development.js:11327:1
    at unstable_runWithPriority (scheduler.development.js:468:1)
    at runWithPriority$1 (react-dom.development.js:11276:1)
    at flushSyncCallbackQueueImpl (react-dom.development.js:11322:1)
    at flushSyncCallbackQueue (react-dom.development.js:11309:1)
    at batchedUpdates$1 (react-dom.development.js:22387:1)
    at Object.notify (Subscription.js:19:1)
    at Subscription.notifyNestedSubs (Subscription.js:90:1)
    at Subscription.handleChangeWrapper (Subscription.js:95:1)
    at Object.dispatch (redux.js:222:1)
    at StatePersistence.dispatch (POS2.js:6062:1)

Proposed Solution

Ask for pager information when paying, without encurring an error

Additional Information