0052376: [23Q2][UX] Unnecessary sidebar in the Approval Required popup with select reason option active

Description

According to https://openbravo.atlassian.net/browse/RM-6152 [^] "Approval Required" popup contents height should be revisited to avoid scrollbar if possible. At the moment if you configure approval required with "Select Reason" an unnecessary sidebar will appears (if you scroll down, no new information will appear)

Steps To Reproduce

0.- Precondition :

  Login on the ERP as Openbravo
  Then change the ERP role to “The White Valley Group Admin” role.
  Navigate to “Role” window
  Select the role Name "VallBlancaUser" and select Tab "User Action Access"
  Search for User Action "Delete line" and change the following options:
    - Approval: "Approval required"
    - Reasons Request Type: "Define Action Reasons (Mandatory)"
    - Confirmation Required should be unchecked.

  Navigate to "User Action Reason" window and create a new record with the following information
    - User Action: "DeleteLine"
    - Text: "Test"
    - Include Additional Comments: "Mandatory"
    - Active: Checked
  Save the changes.

1.- Login in POS as vallblanca
2.- Select "Avalanche Tranceiver" product
3.- Click on the product ticket line then "Delete Line"

The Approval Required pop-up should now appear. Note that an unnecessary sidebar appears to the right of this popup

Proposed Solution

check proper layout in attached image with the "proper_approval_required.png" name

Tags

No tags attached.

Attached Files

approval_required.png [^] (60,063 bytes) 2023-05-08 09:06

proper_approval_required.png [^] (138,313 bytes) 2023-05-08 09:35

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0157603) hgbot (developer) 2023-11-24 09:29	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1295 [^]

(0170761) hgbot (developer) 2024-10-22 16:31	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: bd891ca9956cfea13458c9c30dae62eac9936fd6 Author: Sabarinath <sabarinath.palanisamy.ext@openbravo.com> Date: 22-10-2024 14:30:34 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/bd891ca9956cfea13458c9c30dae62eac9936fd6 [^] Fixed ISSUE-52376: Displayed the approval popover with correct alignment --- M web-jspack/org.openbravo.core2/src/components/InputAndApprovalDialog/InputAndApprovalDialog.scss ---

(0170762) hgbot (developer) 2024-10-22 16:31	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1295 [^]

Issue History
Date Modified	Username	Field	Change
2023-05-08 09:06	Markel_Iruretagoyena	New Issue
2023-05-08 09:06	Markel_Iruretagoyena	Assigned To	=> Retail
2023-05-08 09:06	Markel_Iruretagoyena	File Added: approval_required.png
2023-05-08 09:06	Markel_Iruretagoyena	Triggers an Emergency Pack	=> No
2023-05-08 09:34	Markel_Iruretagoyena	Description Updated	View Revisions
2023-05-08 09:34	Markel_Iruretagoyena	Proposed Solution updated
2023-05-08 09:35	Markel_Iruretagoyena	File Added: proper_approval_required.png
2023-11-22 11:27	SABARINATH P	Assigned To	Retail => SABARINATH P
2023-11-23 13:34	SABARINATH P	Status	new => scheduled
2023-11-24 09:29	hgbot	Note Added: 0157603
2024-10-22 16:31	hgbot	Resolution	open => fixed
2024-10-22 16:31	hgbot	Status	scheduled => closed
2024-10-22 16:31	hgbot	Fixed in Version	=> 25Q1
2024-10-22 16:31	hgbot	Note Added: 0170761
2024-10-22 16:31	hgbot	Note Added: 0170762