Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0052296
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Discounts Engine for Backendmajoralways2023-04-28 21:552023-05-22 09:56
ReportersofidossantView Statuspublic 
Assigned Toradhakrishnan 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket63268
OBNetwork customerOBPS
Regression introduced in release
Summary

0052296: The api always returns the same result without checking if the filters are disabled.

DescriptionThe api always returns the same result without checking if the filters are disabled.
When I use the Free Products per Total Amount discount and I deactivate one of the Free products, the api applies it anyway.
Steps To ReproduceUse the json
{
  "ticket": {
    "id":"79797C77BD274CEBBC4BE58037AB147B",
    "organization": {
 "id": "D270A5AC50874F8BA67A88EE977F8E3B",
                      "_identifier": "Vall Blanca Store"
                          },
    "businessPartner": {
                      "id": "ABD91C9D3BC94175B876FBBE9CACA008",
                      "_identifier": "VBS Customer"
    },
    "orderDate": "2023-03-20T11:54:21",
    "priceIncludesTax": true,
    "discountsFromUser": {},
    "lines": [
      {
        "id": "1",
        "product": {
                      "id": "DEC20EABF33944BA967E24EFF8C244B3",
                      "_identifier": "Torch CB1"
                              },
        "qty": 2,
        "baseGrossUnitPrice": 100
      }
    ]
  }
}

And then use
this discount https://livebuilds.openbravo.com/retail_modules_pgsql_pi/?tabId=800079&recordId=C055AAEEDE764B9B8B597BD45C59F03C [^]

Add the product, test and you can see the discount
Then you desactive the product, and see the discount equals
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0052142 closedradhakrishnan When a Combo discount is used, it is not filtered if the family is active. 

-  Notes
(0149913)
hgbot (developer)
2023-05-18 07:48

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/104 [^]
(0150045)
hgbot (developer)
2023-05-22 09:56

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: aa4b98613e3d964f4ca4ea79313006241142aba1
Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com>
Date: 22-05-2023 07:56:50
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/aa4b98613e3d964f4ca4ea79313006241142aba1 [^]

Fixed ISSUE-52296: Free products should not be applied in when it is in inactive

---
M src-test/org/openbravo/retail/discounts/test/base/model/definition/ByTotalAmountScaled.java
M src-test/org/openbravo/retail/discounts/test/base/model/definition/ByTotalFreeItems.java
M src-test/org/openbravo/retail/discounts/test/base/model/definition/ByTotalPercentageScaled.java
M src/org/openbravo/retail/discounts/ByTotalDataHook.java
---
(0150046)
hgbot (developer)
2023-05-22 09:56

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/104 [^]

- Issue History
Date Modified Username Field Change
2023-04-28 21:55 sofidossant New Issue
2023-04-28 21:55 sofidossant Assigned To => Triage Omni OMS
2023-04-28 21:55 sofidossant Support ticket => 63268
2023-04-28 21:55 sofidossant OBNetwork customer => OBPS
2023-05-08 17:04 aferraz Assigned To Triage Omni OMS => radhakrishnan
2023-05-16 09:28 aferraz Relationship added related to 0052142
2023-05-18 07:48 hgbot Merge Request Status => open
2023-05-18 07:48 hgbot Note Added: 0149913
2023-05-22 09:56 hgbot Merge Request Status open => approved
2023-05-22 09:56 hgbot Resolution open => fixed
2023-05-22 09:56 hgbot Status new => closed
2023-05-22 09:56 hgbot Fixed in Version => RR23Q3
2023-05-22 09:56 hgbot Note Added: 0150045
2023-05-22 09:56 hgbot Note Added: 0150046

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker