0052296: The api always returns the same result without checking if the filters are disabled.

Openbravo Issue Tracking System - Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0052296

Modules

Discounts Engine for Backend

public

2023-04-28 21:55

2023-05-22 09:56

Reporter

sofidossant

Assigned To

radhakrishnan

Priority

high

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

approved

Regression date

Regression introduced by commit

Regression level

Review Assigned To

Support ticket

63268

OBNetwork customer

OBPS

Regression introduced in release

Summary

0052296: The api always returns the same result without checking if the filters are disabled.

Description

The api always returns the same result without checking if the filters are disabled.
When I use the Free Products per Total Amount discount and I deactivate one of the Free products, the api applies it anyway.

Steps To Reproduce

Use the json
{
  "ticket": {
    "id":"79797C77BD274CEBBC4BE58037AB147B",
    "organization": {
"id": "D270A5AC50874F8BA67A88EE977F8E3B",
                      "_identifier": "Vall Blanca Store"
                          },
    "businessPartner": {
                      "id": "ABD91C9D3BC94175B876FBBE9CACA008",
                      "_identifier": "VBS Customer"
    },
    "orderDate": "2023-03-20T11:54:21",
    "priceIncludesTax": true,
    "discountsFromUser": {},
    "lines": [
      {
        "id": "1",
        "product": {
                      "id": "DEC20EABF33944BA967E24EFF8C244B3",
                      "_identifier": "Torch CB1"
                              },
        "qty": 2,
        "baseGrossUnitPrice": 100
      }
    ]
  }
}

And then use
this discount https://livebuilds.openbravo.com/retail_modules_pgsql_pi/?tabId=800079&recordId=C055AAEEDE764B9B8B597BD45C59F03C [^]

Add the product, test and you can see the discount
Then you desactive the product, and see the discount equals

Proposed Solution

Additional Information