Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0052251
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSminorhave not tried2023-04-26 12:132023-05-08 13:58
ReporterablascoView Statuspublic 
Assigned Toablasco 
PrioritynormalResolutionfixedFixed in Version23Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0052251: Dialogs review FullScreen in portrait

DescriptionSome Dialogs are not full screen in portrait due to a restriction in landscape CSS rules. Fixed width and restricted max-width.
Some others should not be in full screen.

FullScreen
- Store Information Dialog
- Service Provider
- Verified Return Dialog

Not fullScreen
- Cashup is mandatory
- Configurator in Generate POP from subtotals
Steps To Reproduce- Login in responsive mode
- Go to Dialog for review.
- Extend width viewport and detect wrong behavior
Proposed Solution
- max width is set in .obpos2TerminalSchedule.MuiDialog-paperWidthSm
- .obpos2VerifiedReturnsDialog-dialog-singleTicket.MuiDialog-paperFullWidth -> max-width
-fullScreenOnPortrait = false in:

   - Proof Of Payment Dialog
   - CashupMandatory Dialog
   - VerifiedReturn Dialog
TagsNo tags attached.
Attached Filespng file icon CashupMandatoryNotFullScreen.png [^] (16,699 bytes) 2023-04-26 13:43


png file icon ServiceProviderFullScreen.png [^] (41,388 bytes) 2023-04-26 13:44


png file icon StoreInformationFullScreen.png [^] (85,290 bytes) 2023-04-26 13:44


png file icon VerifiedReturnsFullScreen.png [^] (51,417 bytes) 2023-04-26 13:44

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0149053)
hgbot (developer)
2023-04-28 09:23

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider/-/merge_requests/24 [^]
(0149054)
hgbot (developer)
2023-04-28 09:24

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1740 [^]
(0149117)
hgbot (developer)
2023-05-02 11:29

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1069 [^]
(0149430)
hgbot (developer)
2023-05-08 13:57

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 92bcbcc25b7ba44ced28328798f6a99a55a4ae69
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 08-05-2023 09:11:10
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/92bcbcc25b7ba44ced28328798f6a99a55a4ae69 [^]

Fixes ISSUE-52251 Verified Returns Dialog and Store Information in Full Screen

---
M web-jspack/org.openbravo.pos2/src/components/TerminalSchedule/TerminalSchedule.scss
M web-jspack/org.openbravo.pos2/src/components/VerifiedReturns/VerifiedReturnsDialog/VerifiedReturnsDialog.scss
---
(0149431)
hgbot (developer)
2023-05-08 13:57

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1740 [^]
(0149432)
hgbot (developer)
2023-05-08 13:57

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: bd6b4f948995bd29c278d9a25774bfb5c28ccef9
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 08-05-2023 09:11:10
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/bd6b4f948995bd29c278d9a25774bfb5c28ccef9 [^]

Fixes ISSUE-52251 CashUp Is Mandatory in CashupOnExitPopup fullScreenOnPortrait to false

---
M web-jspack/org.openbravo.pos2/src/components/Cashup/cashupOnExitPopup.js
---
(0149433)
hgbot (developer)
2023-05-08 13:58

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1069 [^]
(0149434)
hgbot (developer)
2023-05-08 13:58

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: da5462cf06e3f9afbc70fc7f437bd057cdc31f1a
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 08-05-2023 09:10:54
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/da5462cf06e3f9afbc70fc7f437bd057cdc31f1a [^]

Fixes ISSUE-52251 MultiButtonStansardDialog Not Full Screen

---
M web-jspack/org.openbravo.core2/src/components/MultiButtonStandardDialog/MultiButtonStandardDialog.jsx
M web-jspack/org.openbravo.core2/src/components/MultiButtonStandardDialog/MultiButtonStandardDialog.scss
M web-jspack/org.openbravo.core2/src/components/MultiOptionDialog/MultiOptionDialog.jsx
M web-jspack/org.openbravo.core2/src/components/PickAndExecutePopup/PickAndExecutePopup.scss
---
(0149435)
hgbot (developer)
2023-05-08 13:58

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider [^]
Changeset: 770e294ec45802b367cc6d7284b5b7e483d11908
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 08-05-2023 09:11:34
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider/-/commit/770e294ec45802b367cc6d7284b5b7e483d11908 [^]

Related to ISSUE-52251 Service Provide Selector Dialog in Full Screen

---
M web-jspack/org.openbravo.pos2.service.provider/src/components/ServiceProviderSelector/ServiceProviderSelector.scss
---
(0149436)
hgbot (developer)
2023-05-08 13:58

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider/-/merge_requests/24 [^]

- Issue History
Date Modified Username Field Change
2023-04-26 12:13 ablasco New Issue
2023-04-26 12:13 ablasco Assigned To => ablasco
2023-04-26 12:13 ablasco OBNetwork customer => No
2023-04-26 12:13 ablasco Triggers an Emergency Pack => No
2023-04-26 13:43 ablasco File Added: CashupMandatoryNotFullScreen.png
2023-04-26 13:44 ablasco File Added: ServiceProviderFullScreen.png
2023-04-26 13:44 ablasco File Added: StoreInformationFullScreen.png
2023-04-26 13:44 ablasco File Added: VerifiedReturnsFullScreen.png
2023-04-27 18:15 ablasco Description Updated View Revisions
2023-04-27 18:15 ablasco Proposed Solution updated
2023-04-28 09:23 hgbot Merge Request Status => open
2023-04-28 09:23 hgbot Note Added: 0149053
2023-04-28 09:24 hgbot Note Added: 0149054
2023-05-02 11:29 hgbot Note Added: 0149117
2023-05-07 17:51 hgbot Merge Request Status open => approved
2023-05-08 13:57 hgbot Resolution open => fixed
2023-05-08 13:57 hgbot Status new => closed
2023-05-08 13:57 hgbot Fixed in Version => 23Q3
2023-05-08 13:57 hgbot Note Added: 0149430
2023-05-08 13:57 hgbot Note Added: 0149431
2023-05-08 13:57 hgbot Note Added: 0149432
2023-05-08 13:58 hgbot Note Added: 0149433
2023-05-08 13:58 hgbot Note Added: 0149434
2023-05-08 13:58 hgbot Note Added: 0149435
2023-05-08 13:58 hgbot Note Added: 0149436

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker