Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052251POS2POSpublic2023-04-26 12:132023-05-08 13:58
Reporterablasco 
Assigned Toablasco 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version23Q3 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052251: Dialogs review FullScreen in portrait
DescriptionSome Dialogs are not full screen in portrait due to a restriction in landscape CSS rules. Fixed width and restricted max-width.
Some others should not be in full screen.

FullScreen
- Store Information Dialog
- Service Provider
- Verified Return Dialog

Not fullScreen
- Cashup is mandatory
- Configurator in Generate POP from subtotals
Steps To Reproduce- Login in responsive mode
- Go to Dialog for review.
- Extend width viewport and detect wrong behavior
Proposed Solution
- max width is set in .obpos2TerminalSchedule.MuiDialog-paperWidthSm
- .obpos2VerifiedReturnsDialog-dialog-singleTicket.MuiDialog-paperFullWidth -> max-width
-fullScreenOnPortrait = false in:

   - Proof Of Payment Dialog
   - CashupMandatory Dialog
   - VerifiedReturn Dialog
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng CashupMandatoryNotFullScreen.png (16,699) 2023-04-26 13:43
https://issues.openbravo.com/file_download.php?file_id=18441&type=bug
png

png ServiceProviderFullScreen.png (41,388) 2023-04-26 13:44
https://issues.openbravo.com/file_download.php?file_id=18442&type=bug
png

png StoreInformationFullScreen.png (85,290) 2023-04-26 13:44
https://issues.openbravo.com/file_download.php?file_id=18443&type=bug
png

png VerifiedReturnsFullScreen.png (51,417) 2023-04-26 13:44
https://issues.openbravo.com/file_download.php?file_id=18444&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2023-04-26 12:13ablascoNew Issue
2023-04-26 12:13ablascoAssigned To => ablasco
2023-04-26 12:13ablascoOBNetwork customer => No
2023-04-26 12:13ablascoTriggers an Emergency Pack => No
2023-04-26 13:43ablascoFile Added: CashupMandatoryNotFullScreen.png
2023-04-26 13:44ablascoFile Added: ServiceProviderFullScreen.png
2023-04-26 13:44ablascoFile Added: StoreInformationFullScreen.png
2023-04-26 13:44ablascoFile Added: VerifiedReturnsFullScreen.png
2023-04-27 18:15ablascoDescription Updatedbug_revision_view_page.php?rev_id=25982#r25982
2023-04-27 18:15ablascoProposed Solution updated
2023-04-28 09:23hgbotMerge Request Status => open
2023-04-28 09:23hgbotNote Added: 0149053
2023-04-28 09:24hgbotNote Added: 0149054
2023-05-02 11:29hgbotNote Added: 0149117
2023-05-07 17:51hgbotMerge Request Statusopen => approved
2023-05-08 13:57hgbotResolutionopen => fixed
2023-05-08 13:57hgbotStatusnew => closed
2023-05-08 13:57hgbotFixed in Version => 23Q3
2023-05-08 13:57hgbotNote Added: 0149430
2023-05-08 13:57hgbotNote Added: 0149431
2023-05-08 13:57hgbotNote Added: 0149432
2023-05-08 13:58hgbotNote Added: 0149433
2023-05-08 13:58hgbotNote Added: 0149434
2023-05-08 13:58hgbotNote Added: 0149435
2023-05-08 13:58hgbotNote Added: 0149436

Notes
(0149053)
hgbot   
2023-04-28 09:23   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider/-/merge_requests/24 [^]
(0149054)
hgbot   
2023-04-28 09:24   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1740 [^]
(0149117)
hgbot   
2023-05-02 11:29   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1069 [^]
(0149430)
hgbot   
2023-05-08 13:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 92bcbcc25b7ba44ced28328798f6a99a55a4ae69
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 08-05-2023 09:11:10
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/92bcbcc25b7ba44ced28328798f6a99a55a4ae69 [^]

Fixes ISSUE-52251 Verified Returns Dialog and Store Information in Full Screen

---
M web-jspack/org.openbravo.pos2/src/components/TerminalSchedule/TerminalSchedule.scss
M web-jspack/org.openbravo.pos2/src/components/VerifiedReturns/VerifiedReturnsDialog/VerifiedReturnsDialog.scss
---
(0149431)
hgbot   
2023-05-08 13:57   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1740 [^]
(0149432)
hgbot   
2023-05-08 13:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: bd6b4f948995bd29c278d9a25774bfb5c28ccef9
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 08-05-2023 09:11:10
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/bd6b4f948995bd29c278d9a25774bfb5c28ccef9 [^]

Fixes ISSUE-52251 CashUp Is Mandatory in CashupOnExitPopup fullScreenOnPortrait to false

---
M web-jspack/org.openbravo.pos2/src/components/Cashup/cashupOnExitPopup.js
---
(0149433)
hgbot   
2023-05-08 13:58   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1069 [^]
(0149434)
hgbot   
2023-05-08 13:58   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: da5462cf06e3f9afbc70fc7f437bd057cdc31f1a
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 08-05-2023 09:10:54
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/da5462cf06e3f9afbc70fc7f437bd057cdc31f1a [^]

Fixes ISSUE-52251 MultiButtonStansardDialog Not Full Screen

---
M web-jspack/org.openbravo.core2/src/components/MultiButtonStandardDialog/MultiButtonStandardDialog.jsx
M web-jspack/org.openbravo.core2/src/components/MultiButtonStandardDialog/MultiButtonStandardDialog.scss
M web-jspack/org.openbravo.core2/src/components/MultiOptionDialog/MultiOptionDialog.jsx
M web-jspack/org.openbravo.core2/src/components/PickAndExecutePopup/PickAndExecutePopup.scss
---
(0149435)
hgbot   
2023-05-08 13:58   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider [^]
Changeset: 770e294ec45802b367cc6d7284b5b7e483d11908
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 08-05-2023 09:11:34
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider/-/commit/770e294ec45802b367cc6d7284b5b7e483d11908 [^]

Related to ISSUE-52251 Service Provide Selector Dialog in Full Screen

---
M web-jspack/org.openbravo.pos2.service.provider/src/components/ServiceProviderSelector/ServiceProviderSelector.scss
---
(0149436)
hgbot   
2023-05-08 13:58   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.service.provider/-/merge_requests/24 [^]