Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0052210

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Discounts and Promotions

major

always

2023-04-24 12:55

2023-05-22 07:39

Reporter

Lcazaux

View Status

public

Assigned To

sreehari

Priority

high

Resolution

fixed

Fixed in Version

RR23Q3

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

approved

Review Assigned To

OBNetwork customer

Gold

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0052210: [PROMO] " Discretionary " Expired Promotion is displayed on WebPos

Description

In WebPos, the discretionary promotions are displayed even when the promotions are expired, so it should not be displayed, even if it is still active in the BackOffice.
Update: it is not possible to select the expired discretionary promotions in the POS, but it is confusing to have an expired promotion on display for the end user. It should not be displayed if expired.

Steps To Reproduce

- Go to the Backoffice, create a discretionary type of promo and set the end date = start date
The next day, your promo in the BO is still checked as active, but it is now expired

- Go to the POS
- Add some products
- Select the discretionary promo in "discount"
--> the promo is display even though it the end date was yesterday

Proposed Solution

Discretionary promotions should have an ending date that is taking into consideration

Tags

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0149378) hgbot (developer) 2023-05-06 08:57	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/102 [^]

(0150020) hgbot (developer) 2023-05-22 07:39	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/102 [^]

(0150021) hgbot (developer) 2023-05-22 07:39	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^] Changeset: e8f75a2dd274f517a69dc36bd69573128a039910 Author: Sreehari Venkataraman <sreehari@qualiantech.com> Date: 22-05-2023 05:33:19 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/e8f75a2dd274f517a69dc36bd69573128a039910 [^] Fixes ISSUE-52210: Added Expiry date checks before discount listing *Fixed test failures related to discounts --- M web-test/model/business-logic/discounts-engine/engine/optional-discount-engine.test.js M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/optional-discount-engine.js ---

Issue History
Date Modified	Username	Field	Change
2023-04-24 12:55	Lcazaux	New Issue
2023-04-24 12:55	Lcazaux	Assigned To	=> Retail
2023-04-24 12:55	Lcazaux	OBNetwork customer	=> Gold
2023-04-24 12:55	Lcazaux	Triggers an Emergency Pack	=> No
2023-04-24 12:56	Lcazaux	Tag Attached: FASH
2023-04-25 08:29	sreehari	Assigned To	Retail => sreehari
2023-04-25 08:29	sreehari	Status	new => scheduled
2023-05-05 13:55	Lcazaux	Description Updated	View Revisions
2023-05-05 13:55	Lcazaux	Steps to Reproduce Updated	View Revisions
2023-05-06 08:57	hgbot	Merge Request Status	=> open
2023-05-06 08:57	hgbot	Note Added: 0149378
2023-05-22 07:39	hgbot	Merge Request Status	open => approved
2023-05-22 07:39	hgbot	Resolution	open => fixed
2023-05-22 07:39	hgbot	Status	scheduled => closed
2023-05-22 07:39	hgbot	Note Added: 0150020
2023-05-22 07:39	hgbot	Fixed in Version	=> RR23Q3
2023-05-22 07:39	hgbot	Note Added: 0150021

Copyright © 2000 - 2009 MantisBT Group