Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0052210Retail ModulesDiscounts and Promotionspublic2023-04-24 12:552023-05-22 07:39
ReporterLcazaux 
Assigned Tosreehari 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR23Q3 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0052210: [PROMO] " Discretionary " Expired Promotion is displayed on WebPos
DescriptionIn WebPos, the discretionary promotions are displayed even when the promotions are expired, so it should not be displayed, even if it is still active in the BackOffice.
Update: it is not possible to select the expired discretionary promotions in the POS, but it is confusing to have an expired promotion on display for the end user. It should not be displayed if expired.
Steps To Reproduce- Go to the Backoffice, create a discretionary type of promo and set the end date = start date
The next day, your promo in the BO is still checked as active, but it is now expired

- Go to the POS
- Add some products
- Select the discretionary promo in "discount"
--> the promo is display even though it the end date was yesterday
Proposed SolutionDiscretionary promotions should have an ending date that is taking into consideration
Additional Information
TagsFASH
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-04-24 12:55LcazauxNew Issue
2023-04-24 12:55LcazauxAssigned To => Retail
2023-04-24 12:55LcazauxOBNetwork customer => Gold
2023-04-24 12:55LcazauxTriggers an Emergency Pack => No
2023-04-24 12:56LcazauxTag Attached: FASH
2023-04-25 08:29sreehariAssigned ToRetail => sreehari
2023-04-25 08:29sreehariStatusnew => scheduled
2023-05-05 13:55LcazauxDescription Updatedbug_revision_view_page.php?rev_id=26007#r26007
2023-05-05 13:55LcazauxSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=26009#r26009
2023-05-06 08:57hgbotMerge Request Status => open
2023-05-06 08:57hgbotNote Added: 0149378
2023-05-22 07:39hgbotMerge Request Statusopen => approved
2023-05-22 07:39hgbotResolutionopen => fixed
2023-05-22 07:39hgbotStatusscheduled => closed
2023-05-22 07:39hgbotNote Added: 0150020
2023-05-22 07:39hgbotFixed in Version => RR23Q3
2023-05-22 07:39hgbotNote Added: 0150021

Notes
(0149378)
hgbot   
2023-05-06 08:57   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/102 [^]
(0150020)
hgbot   
2023-05-22 07:39   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/102 [^]
(0150021)
hgbot   
2023-05-22 07:39   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: e8f75a2dd274f517a69dc36bd69573128a039910
Author: Sreehari Venkataraman <sreehari@qualiantech.com>
Date: 22-05-2023 05:33:19
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/e8f75a2dd274f517a69dc36bd69573128a039910 [^]

Fixes ISSUE-52210: Added Expiry date checks before discount listing
*Fixed test failures related to discounts

---
M web-test/model/business-logic/discounts-engine/engine/optional-discount-engine.test.js
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/optional-discount-engine.js
---