Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0052136
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[POS2] POSminorhave not tried2023-04-11 10:122023-04-18 15:48
ReporterjayalaView Statuspublic 
Assigned Tojayala 
PrioritynormalResolutionfixedFixed in Version23Q2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version23Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0052136: Check if a color belongs to an active ColorPalette to show in KeymapEditorColorPicker

DescriptionThe logic developed for this issue checks whether the color stored in the browser's database belongs to an active color palette, in addition to checking if the color itself is active. Prior to the change, it simply returned all colors without performing this check.
Also addapted component's tests to new logic to pass.
Steps To Reproduce1. Deactivate a color palette from color palettes in BO.
2. Go to POS2, in the Key map editor > View version > Set layout, right click in any available item.
3. The palette will show all colors, also from the deactivated palette.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0052089 closedjayala Check if a color belongs to an active ColorPalette to show in KeymapEditorColorPicker 

-  Notes
(0148506)
hgbot (developer)
2023-04-17 17:30

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1696 [^]
(0148554)
hgbot (developer)
2023-04-18 15:48

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 0052918e52ef2b97031aa1d2ad1d6ee479d90513
Author: Javier Ayala <javier.ayala@openbravo.com>
Date: 18-04-2023 13:48:36
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0052918e52ef2b97031aa1d2ad1d6ee479d90513 [^]

Fixed ISSUE-52136: Check if a color belongs to an active ColorPalette to show in KeymapEditorColorPicker

---
A web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeymapEditorNewCategoryDialog/getColorPalettesFromMasterData.js
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorLayout/KeymapEditorProductPopover/KeymapEditorColorPicker/KeymapEditorColorPicker.jsx
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorLayout/KeymapEditorProductPopover/KeymapEditorColorPicker/__test__/KeymapEditorColorPicker.test.jsx
---
(0148555)
hgbot (developer)
2023-04-18 15:48

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1696 [^]

- Issue History
Date Modified Username Field Change
2023-04-17 16:30 javierRodriguez Type defect => backport
2023-04-17 16:30 javierRodriguez Target Version => 23Q2
2023-04-17 17:30 hgbot Note Added: 0148506
2023-04-18 15:48 hgbot Resolution open => fixed
2023-04-18 15:48 hgbot Status scheduled => closed
2023-04-18 15:48 hgbot Fixed in Version => 23Q2
2023-04-18 15:48 hgbot Note Added: 0148554
2023-04-18 15:48 hgbot Note Added: 0148555


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker