Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0051931
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2023-03-21 15:372023-03-24 13:48
ReporterjorgewederagoView Statuspublic 
Assigned Toradhakrishnan 
PriorityhighResolutionfixedFixed in VersionRR23Q2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0051931: OB.App.View.DialogUIHandler.askConfirmation should accept non translatable messages in Enyo

DescriptionWhen using the API OB.App.View.DialogUIHandler.askConfirmation, it is not possible to set neither titles nor body messages that are not translatable messages
Steps To Reproduce1.- Open Enyo POS
2.- Open console and write the following code
OB.App.View.DialogUIHandler.askConfirmation({
    title:'test',
    message: 'test'
})

Check that both title and body contain an UNDEFINED
Proposed SolutionParse the incoming title and message to ensure they are translatable labels before applying OB.I18N.getLabel.

In core2 there is some code that is doing the same using the following rule:

if (!key.startsWith('$')) {
  return key;
}

so it would be a nice idea to use it also for this issues
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0147936)
hgbot (developer)
2023-03-24 10:22

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/490 [^]
(0147953)
hgbot (developer)
2023-03-24 13:48

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/490 [^]
(0147954)
hgbot (developer)
2023-03-24 13:48

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: bf8cd3a2f4b34441ea260a3f18bf12a3cdd87114
Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com>
Date: 22-03-2023 15:00:44
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/bf8cd3a2f4b34441ea260a3f18bf12a3cdd87114 [^]

Fixed ISSUE-51931: AskConfirmation should validate the title and message
* If title and message doesn't have the label then it should print title and message
  without the OB.I18N.getLabel

---
M web/org.openbravo.mobile.core/app/view/DialogUIHandler.js
---

- Issue History
Date Modified Username Field Change
2023-03-21 15:37 jorgewederago New Issue
2023-03-21 15:37 jorgewederago Assigned To => Retail
2023-03-21 15:37 jorgewederago OBNetwork customer => No
2023-03-21 15:37 jorgewederago Triggers an Emergency Pack => No
2023-03-22 08:31 radhakrishnan Assigned To Retail => radhakrishnan
2023-03-22 08:31 radhakrishnan Status new => scheduled
2023-03-23 16:28 jorgewederago Proposed Solution updated
2023-03-24 10:22 hgbot Merge Request Status => open
2023-03-24 10:22 hgbot Note Added: 0147936
2023-03-24 13:48 hgbot Merge Request Status open => approved
2023-03-24 13:48 hgbot Resolution open => fixed
2023-03-24 13:48 hgbot Status scheduled => closed
2023-03-24 13:48 hgbot Note Added: 0147953
2023-03-24 13:48 hgbot Fixed in Version => RR23Q2
2023-03-24 13:48 hgbot Note Added: 0147954

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker