Openbravo Issue Tracking System - Retail Modules | |||||
| View Issue Details | |||||
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0051931 | Retail Modules | Web POS | public | 2023-03-21 15:37 | 2023-03-24 13:48 |
| Reporter | jorgewederago | ||||
| Assigned To | radhakrishnan | ||||
| Priority | high | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | OS | 5 | OS Version | ||
| Product Version | |||||
| Target Version | Fixed in Version | RR23Q2 | |||
| Merge Request Status | approved | ||||
| Review Assigned To | |||||
| OBNetwork customer | No | ||||
| Support ticket | |||||
| Regression level | |||||
| Regression date | |||||
| Regression introduced in release | |||||
| Regression introduced by commit | |||||
| Triggers an Emergency Pack | No | ||||
| Summary | 0051931: OB.App.View.DialogUIHandler.askConfirmation should accept non translatable messages in Enyo | ||||
| Description | When using the API OB.App.View.DialogUIHandler.askConfirmation, it is not possible to set neither titles nor body messages that are not translatable messages | ||||
| Steps To Reproduce | 1.- Open Enyo POS 2.- Open console and write the following code OB.App.View.DialogUIHandler.askConfirmation({ title:'test', message: 'test' }) Check that both title and body contain an UNDEFINED | ||||
| Proposed Solution | Parse the incoming title and message to ensure they are translatable labels before applying OB.I18N.getLabel. In core2 there is some code that is doing the same using the following rule: if (!key.startsWith('$')) { return key; } so it would be a nice idea to use it also for this issues | ||||
| Additional Information | |||||
| Tags | No tags attached. | ||||
| Relationships | |||||
| Attached Files | |||||
| Issue History | |||||
| Date Modified | Username | Field | Change | ||
| 2023-03-21 15:37 | jorgewederago | New Issue | |||
| 2023-03-21 15:37 | jorgewederago | Assigned To | => Retail | ||
| 2023-03-21 15:37 | jorgewederago | OBNetwork customer | => No | ||
| 2023-03-21 15:37 | jorgewederago | Triggers an Emergency Pack | => No | ||
| 2023-03-22 08:31 | radhakrishnan | Assigned To | Retail => radhakrishnan | ||
| 2023-03-22 08:31 | radhakrishnan | Status | new => scheduled | ||
| 2023-03-23 16:28 | jorgewederago | Proposed Solution updated | |||
| 2023-03-24 10:22 | hgbot | Merge Request Status | => open | ||
| 2023-03-24 10:22 | hgbot | Note Added: 0147936 | |||
| 2023-03-24 13:48 | hgbot | Merge Request Status | open => approved | ||
| 2023-03-24 13:48 | hgbot | Resolution | open => fixed | ||
| 2023-03-24 13:48 | hgbot | Status | scheduled => closed | ||
| 2023-03-24 13:48 | hgbot | Note Added: 0147953 | |||
| 2023-03-24 13:48 | hgbot | Fixed in Version | => RR23Q2 | ||
| 2023-03-24 13:48 | hgbot | Note Added: 0147954 | |||
| Notes | |||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||
|
|
|||||
|
|
||||