Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0051810 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | major | have not tried | 2023-03-08 13:15 | 2023-03-10 14:57 | |||
| Reporter | meriem_azaf | View Status | public | |||||
| Assigned To | meriem_azaf | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0051810: It is possible to deliver an order without completely paying, it shouldn't be | |||||||
| Description | when you do a ticket with a delivery when you want to totally pay it, you have to change 2 things : - Indicate this orders is delivered. - Finalize the payment. The request here is to block the ability of marked as delivered while the payment is not totally finalize. | |||||||
| Steps To Reproduce | 1- Open a new ticket (pickup in store). 2- Select several products. 3- Switch to payment mode and only prepay the ticket. 4- Finalize the payment. 5- Go to sales history screen. 6- Click in 3 dots button. → KO you can click “issue order”, you shouldn’t be able to do that because the payment for this order is not totally done. OR 6- Open the order. 7- Click in 3 dots button. → KO you can click “issue order”,you shouldn’t be able to do that because the payment for this order is not totally done | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0147380) hgbot (developer) 2023-03-08 13:43 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1582 [^] |
|
(0147383) hgbot (developer) 2023-03-08 13:51 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1087 [^] |
|
(0147446) hgbot (developer) 2023-03-10 14:56 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 2f69ab0bf43294fa13f9733a52f66c63f6bbead7 Author: Meriem Azaf <meriem.azaf@openbravo.com> Date: 10-03-2023 12:41:59 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/2f69ab0bf43294fa13f9733a52f66c63f6bbead7 [^] Fixes ISSUE-51810: It is possible to deliver an order without completely paying, it shouldn't be The problem here that we can change the status delivery to delivered even the Ticket is not fully paid. To fix this, we added a new rule in the executability rule related to the user action "IssueTicket" and to be able to enable/disable the button "Issue Order" without opening the Ticket. So, in this part we don't have these ticket properties grossAmount and payment and these two ones are defined when we load the Ticket (that means when we open the Ticket) but when we click in tree dots that we have in the row to have the popup another user-action executed its selectRemoteTicket and in this one we don't define these properties, so for that we decided to add these properties. For the payment property, we defined like that "ticket.payment: ticket.paidAmount" because to define this property we need the ticket.payments array and we don't have because we don't have this "receiptPayments" in this part. --- M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/IssueTicket.js M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/__test__/IssueTicket.test.js M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/SelectRemoteTicket.js M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/__test__/SelectRemoteTicket.test.js --- |
|
(0147447) hgbot (developer) 2023-03-10 14:56 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1582 [^] |
|
(0147448) hgbot (developer) 2023-03-10 14:57 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1087 [^] |
|
(0147449) hgbot (developer) 2023-03-10 14:57 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 5b7dfe7ab4e7089e109a2583cc2ea5d1bea31181 Author: Meriem Azaf <meriem.azaf@openbravo.com> Date: 10-03-2023 14:57:20 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/5b7dfe7ab4e7089e109a2583cc2ea5d1bea31181 [^] Fixes ISSUE-51810: It is possible to deliver an order without completely paying, it shouldn't be The problem here that we can change the status delivery to delivered even the Ticket is not fully paid. To fix this, we added a new rule in the executability rule related to the user action "IssueTicket" and to be able to enable/disable the button "Issue Order" without opening the Ticket. So, in this part we don't have these ticket properties grossAmount and payment and these two ones are defined when we load the Ticket (that means when we open the Ticket) but when we click in tree dots that we have in the row to have the popup another user-action executed its selectRemoteTicket and in this one we don't define these properties, so for that we decided to add these properties. For the payment property, we defined like that "ticket.payment: ticket.paidAmount" because to define this property we need the ticket.payments array and we don't have because we don't have this "receiptPayments" in this part. --- M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/TicketUtils.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2023-03-08 13:15 | meriem_azaf | New Issue | |
| 2023-03-08 13:15 | meriem_azaf | Assigned To | => Retail |
| 2023-03-08 13:15 | meriem_azaf | Triggers an Emergency Pack | => No |
| 2023-03-08 13:15 | meriem_azaf | Assigned To | Retail => meriem_azaf |
| 2023-03-08 13:15 | meriem_azaf | Status | new => scheduled |
| 2023-03-08 13:43 | hgbot | Note Added: 0147380 | |
| 2023-03-08 13:51 | hgbot | Note Added: 0147383 | |
| 2023-03-10 12:12 | guilleaer | Status | scheduled => acknowledged |
| 2023-03-10 12:12 | guilleaer | Status | acknowledged => scheduled |
| 2023-03-10 14:56 | hgbot | Resolution | open => fixed |
| 2023-03-10 14:56 | hgbot | Status | scheduled => closed |
| 2023-03-10 14:56 | hgbot | Fixed in Version | => 23Q2 |
| 2023-03-10 14:56 | hgbot | Note Added: 0147446 | |
| 2023-03-10 14:56 | hgbot | Note Added: 0147447 | |
| 2023-03-10 14:57 | hgbot | Note Added: 0147448 | |
| 2023-03-10 14:57 | hgbot | Fixed in Version | 23Q2 => RR23Q2 |
| 2023-03-10 14:57 | hgbot | Note Added: 0147449 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |