Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051810POS2POSpublic2023-03-08 13:152023-03-10 14:57
Reportermeriem_azaf 
Assigned Tomeriem_azaf 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0051810: It is possible to deliver an order without completely paying, it shouldn't be
Descriptionwhen you do a ticket with a delivery when you want to totally pay it, you have to change 2 things :

- Indicate this orders is delivered.

- Finalize the payment.

The request here is to block the ability of marked as delivered while the payment is not totally finalize.
Steps To Reproduce1- Open a new ticket (pickup in store).

2- Select several products.

3- Switch to payment mode and only prepay the ticket.

4- Finalize the payment.

5- Go to sales history screen.

6- Click in 3 dots button.

→ KO you can click “issue order”, you shouldn’t be able to do that because the payment for this order is not totally done.

OR

6- Open the order.

7- Click in 3 dots button.

→ KO you can click “issue order”,you shouldn’t be able to do that because the payment for this order is not totally done
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005183123Q1.1 closed meriem_azaf It is possible to deliver an order without completely paying, it shouldn't be 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-03-08 13:15meriem_azafNew Issue
2023-03-08 13:15meriem_azafAssigned To => Retail
2023-03-08 13:15meriem_azafOBNetwork customer => No
2023-03-08 13:15meriem_azafTriggers an Emergency Pack => No
2023-03-08 13:15meriem_azafAssigned ToRetail => meriem_azaf
2023-03-08 13:15meriem_azafStatusnew => scheduled
2023-03-08 13:43hgbotMerge Request Status => open
2023-03-08 13:43hgbotNote Added: 0147380
2023-03-08 13:51hgbotNote Added: 0147383
2023-03-10 12:12guilleaerStatusscheduled => acknowledged
2023-03-10 12:12guilleaerStatusacknowledged => scheduled
2023-03-10 12:34hgbotMerge Request Statusopen => approved
2023-03-10 14:56hgbotResolutionopen => fixed
2023-03-10 14:56hgbotStatusscheduled => closed
2023-03-10 14:56hgbotFixed in Version => 23Q2
2023-03-10 14:56hgbotNote Added: 0147446
2023-03-10 14:56hgbotNote Added: 0147447
2023-03-10 14:57hgbotNote Added: 0147448
2023-03-10 14:57hgbotFixed in Version23Q2 => RR23Q2
2023-03-10 14:57hgbotNote Added: 0147449

Notes
(0147380)
hgbot   
2023-03-08 13:43   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1582 [^]
(0147383)
hgbot   
2023-03-08 13:51   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1087 [^]
(0147446)
hgbot   
2023-03-10 14:56   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 2f69ab0bf43294fa13f9733a52f66c63f6bbead7
Author: Meriem Azaf <meriem.azaf@openbravo.com>
Date: 10-03-2023 12:41:59
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/2f69ab0bf43294fa13f9733a52f66c63f6bbead7 [^]

Fixes ISSUE-51810: It is possible to deliver an order without completely paying, it shouldn't be

The problem here that we can change the status delivery to delivered even the Ticket is not fully paid.

To fix this, we added a new rule in the executability rule related to the user action "IssueTicket" and to be able to enable/disable the button "Issue Order" without opening the Ticket.

So, in this part we don't have these ticket properties grossAmount and payment and these two ones are defined when we load the Ticket (that means when we open the Ticket) but when we click in tree dots that we have in the row to have the popup another user-action executed its selectRemoteTicket and in this one we don't define these properties, so for that we decided to add these properties.

For the payment property, we defined like that "ticket.payment: ticket.paidAmount" because to define this property we need the ticket.payments array and we don't have because we don't have this "receiptPayments" in this part.

---
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/IssueTicket.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/__test__/IssueTicket.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/SelectRemoteTicket.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/__test__/SelectRemoteTicket.test.js
---
(0147447)
hgbot   
2023-03-10 14:56   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1582 [^]
(0147448)
hgbot   
2023-03-10 14:57   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1087 [^]
(0147449)
hgbot   
2023-03-10 14:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 5b7dfe7ab4e7089e109a2583cc2ea5d1bea31181
Author: Meriem Azaf <meriem.azaf@openbravo.com>
Date: 10-03-2023 14:57:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/5b7dfe7ab4e7089e109a2583cc2ea5d1bea31181 [^]

Fixes ISSUE-51810: It is possible to deliver an order without completely paying, it shouldn't be

The problem here that we can change the status delivery to delivered even the Ticket is not fully paid.

To fix this, we added a new rule in the executability rule related to the user action "IssueTicket" and to be able to enable/disable the button "Issue Order" without opening the Ticket.

So, in this part we don't have these ticket properties grossAmount and payment and these two ones are defined when we load the Ticket (that means when we open the Ticket) but when we click in tree dots that we have in the row to have the popup another user-action executed its selectRemoteTicket and in this one we don't define these properties, so for that we decided to add these properties.

For the payment property, we defined like that "ticket.payment: ticket.paidAmount" because to define this property we need the ticket.payments array and we don't have because we don't have this "receiptPayments" in this part.

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/TicketUtils.js
---