Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0051652 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | trivial | always | 2023-02-21 09:28 | 2023-02-21 16:08 | |||
| Reporter | migueldejuana | View Status | public | |||||
| Assigned To | migueldejuana | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 23Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0051652: Small UI errors in margins | |||||||
| Description | Fix UI errors in POS2 to follow the rule of 8 with margins. - Set 2.4rem margin(bottom) between components in a form. For DatePicker, take into account submessage. - In Search window, characteristic popup must have 2.4rem margin between values. - Adjust Approval popup to fit to defined margins. - Customer form must have 2.4rem margin(bottom) in all the components. - In Key Map Editor, New Category popup must have also the defined margins. - In Print/Email popup, when confirming an order, the input need to have the proper margin. - Customer button in the Ticket Header must have a differente icon. Same icon but without the surrounding circle. - Ticket properties popover has no enough margin between the components. - Improve margins in Print Product Labels - Ensure Giftcard popup has input with correct margin | |||||||
| Steps To Reproduce | n/a | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0146807) hgbot (developer) 2023-02-21 09:58 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/984 [^] |
|
(0146809) hgbot (developer) 2023-02-21 10:11 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1538 [^] |
|
(0146810) hgbot (developer) 2023-02-21 10:31 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.product.label.printing/-/merge_requests/9 [^] |
|
(0146811) hgbot (developer) 2023-02-21 10:37 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/191 [^] |
|
(0146816) hgbot (developer) 2023-02-21 16:06 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/984 [^] |
|
(0146817) hgbot (developer) 2023-02-21 16:06 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: abcf1f048d770bc706f658a75d131990cd71ad8b Author: miguel.dejuana <miguel.dejuana@openbravo.com> Date: 21-02-2023 09:57:51 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/abcf1f048d770bc706f658a75d131990cd71ad8b [^] Fixes ISSUE-0051652: Small UI errors in margins Fix UI errors in POS2 to follow the rule of 8 with margins. - Set 2.4rem margin(bottom) between components in a form. For DatePicker, take into account submessage. - In Search window, characteristic popup must have 2.4rem margin between values. - Adjust Approval popup to fit to defined margins. --- M web-jspack/org.openbravo.core2/src/components/Form/BaseFormContent.scss M web-jspack/org.openbravo.core2/src/components/PickAndExecutePopup/PickAndExecuteOptionTree/PickAndExecuteOptionTree.scss M web-jspack/org.openbravo.core2/src/components/PickAndExecutePopup/PickAndExecuteOptionTreeList/PickAndExecuteOptionTreeList.scss M web-jspack/org.openbravo.core2/src/components/PickAndExecutePopup/PickAndExecutePopup.config.json M web-jspack/org.openbravo.core2/src/components/ReasonAndApprovalDialog/ReasonAndApprovalDialog.scss --- |
|
(0146818) hgbot (developer) 2023-02-21 16:06 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: e3476e9bcaea76a3cb7c6d8816fe07a2ecb06452 Author: miguel.dejuana <miguel.dejuana@openbravo.com> Date: 21-02-2023 15:55:16 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/e3476e9bcaea76a3cb7c6d8816fe07a2ecb06452 [^] Fixes ISSUE-0051652: Small UI errors in margins - Add copyrights --- M web-jspack/org.openbravo.core2/src/components/Form/BaseFormContent.scss M web-jspack/org.openbravo.core2/src/components/PickAndExecutePopup/PickAndExecuteOptionTree/PickAndExecuteOptionTree.scss M web-jspack/org.openbravo.core2/src/components/PickAndExecutePopup/PickAndExecuteOptionTreeList/PickAndExecuteOptionTreeList.scss M web-jspack/org.openbravo.core2/src/components/ReasonAndApprovalDialog/ReasonAndApprovalDialog.scss --- |
|
(0146819) hgbot (developer) 2023-02-21 16:08 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1538 [^] |
|
(0146820) hgbot (developer) 2023-02-21 16:08 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: f2678cf620243c231b957cb62b36620556c14aa0 Author: miguel.dejuana <miguel.dejuana@openbravo.com> Date: 21-02-2023 10:08:32 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/f2678cf620243c231b957cb62b36620556c14aa0 [^] Fixes ISSUE-0051652: Small UI errors in margins - Customer form must have 2.4rem margin(bottom) in all the components. - In Key Map Editor, New Category popup must have also the defined margins. - In Print/Email popup, when confirming an order, the input need to have the proper margin. - Customer button in the Ticket Header must have a differente icon. Same icon but without the surrounding circle. - Ticket properties popover has no enough margin between the components. --- M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerForm/CustomerForm.scss M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerSelector/CustomerSelector.scss M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeymapEditorNewCategoryDialog/KeymapEditorCategoryDialog.jsx M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeymapEditorNewCategoryDialog/KeymapEditorCategoryDialog.scss M web-jspack/org.openbravo.pos2/src/components/ReceiptDeliveryOptions/SharedReceiptDeliveryOptions/ReceiptDeliveryOptionsEmailInput/ReceiptDeliveryOptionsEmailInput.scss M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPButton/TicketBPButton.config.json M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketPropertiesPopover/TicketPropertiesPopover.scss --- |
|
(0146821) hgbot (developer) 2023-02-21 16:08 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 9c5c058ed8501a2524c97b05f53e4a469d569540 Author: miguel.dejuana <miguel.dejuana@openbravo.com> Date: 21-02-2023 16:02:20 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/9c5c058ed8501a2524c97b05f53e4a469d569540 [^] Fixes ISSUE-0051652: Small UI errors in margins - Add copyrights --- M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerForm/CustomerForm.scss M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerSelector/CustomerSelector.scss M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeymapEditorNewCategoryDialog/KeymapEditorCategoryDialog.jsx M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeymapEditorNewCategoryDialog/KeymapEditorCategoryDialog.scss M web-jspack/org.openbravo.pos2/src/components/ReceiptDeliveryOptions/SharedReceiptDeliveryOptions/ReceiptDeliveryOptionsEmailInput/ReceiptDeliveryOptionsEmailInput.scss M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketPropertiesPopover/TicketPropertiesPopover.scss --- |
|
(0146822) hgbot (developer) 2023-02-21 16:08 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.product.label.printing [^] Changeset: 6677a15c835ce568fde05689f744d81be9b44a7f Author: miguel.dejuana <miguel.dejuana@openbravo.com> Date: 21-02-2023 10:29:36 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.product.label.printing/-/commit/6677a15c835ce568fde05689f744d81be9b44a7f [^] Fixes ISSUE-0051652: Small UI errors in margins - Improve margins in Print Product Labels --- M web-jspack/org.openbravo.pos2.product.label.printing/src/components/PrintProductLabel/PrintProductLabelSelectProdStep/PrintProductLabelSelectProdFilters/PrintProductLabelSelectProdFilters.jsx M web-jspack/org.openbravo.pos2.product.label.printing/src/components/PrintProductLabel/PrintProductLabelSelectProdStep/PrintProductLabelSelectProdFilters/PrintProductLabelSelectProdFilters.scss --- |
|
(0146823) hgbot (developer) 2023-02-21 16:08 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.product.label.printing [^] Changeset: aaf5617c0572cf780aa45298ddfb7884dd0b5e4f Author: miguel.dejuana <miguel.dejuana@openbravo.com> Date: 21-02-2023 16:03:52 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.product.label.printing/-/commit/aaf5617c0572cf780aa45298ddfb7884dd0b5e4f [^] Fixes ISSUE-0051652: Small UI errors in margins - Add copyrights --- M web-jspack/org.openbravo.pos2.product.label.printing/src/components/PrintProductLabel/PrintProductLabelSelectProdStep/PrintProductLabelSelectProdFilters/PrintProductLabelSelectProdFilters.jsx M web-jspack/org.openbravo.pos2.product.label.printing/src/components/PrintProductLabel/PrintProductLabelSelectProdStep/PrintProductLabelSelectProdFilters/PrintProductLabelSelectProdFilters.scss --- |
|
(0146824) hgbot (developer) 2023-02-21 16:08 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.product.label.printing/-/merge_requests/9 [^] |
|
(0146825) hgbot (developer) 2023-02-21 16:08 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^] Changeset: 1f1c84c32a69a997411fae0d512f42d7295f1550 Author: miguel.dejuana <miguel.dejuana@openbravo.com> Date: 21-02-2023 15:06:08 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/1f1c84c32a69a997411fae0d512f42d7295f1550 [^] Fixes ISSUE-0051652: Small UI errors in margins - Ensure Giftcard popup has input with correct margin --- M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardDialog/GiftCardDialog.scss --- |
|
(0146826) hgbot (developer) 2023-02-21 16:08 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^] Changeset: ce6ba759cecb0159a1e100a2d42a1feecfd6abf2 Author: miguel.dejuana <miguel.dejuana@openbravo.com> Date: 21-02-2023 15:06:08 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/ce6ba759cecb0159a1e100a2d42a1feecfd6abf2 [^] Fixes ISSUE-0051652: Small UI errors in margins - Add copyrights --- M web-jspack/org.openbravo.retail.giftcards/src/components/GiftCardDialog/GiftCardDialog.scss --- |
|
(0146827) hgbot (developer) 2023-02-21 16:08 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/191 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2023-02-21 09:28 | migueldejuana | New Issue | |
| 2023-02-21 09:28 | migueldejuana | Assigned To | => migueldejuana |
| 2023-02-21 09:28 | migueldejuana | OBNetwork customer | => No |
| 2023-02-21 09:28 | migueldejuana | Triggers an Emergency Pack | => No |
| 2023-02-21 09:57 | migueldejuana | Description Updated | View Revisions |
| 2023-02-21 09:58 | hgbot | Merge Request Status | => open |
| 2023-02-21 09:58 | hgbot | Note Added: 0146807 | |
| 2023-02-21 10:08 | migueldejuana | Description Updated | View Revisions |
| 2023-02-21 10:11 | hgbot | Note Added: 0146809 | |
| 2023-02-21 10:16 | migueldejuana | Description Updated | View Revisions |
| 2023-02-21 10:31 | hgbot | Note Added: 0146810 | |
| 2023-02-21 10:36 | migueldejuana | Description Updated | View Revisions |
| 2023-02-21 10:37 | hgbot | Note Added: 0146811 | |
| 2023-02-21 10:40 | migueldejuana | Description Updated | View Revisions |
| 2023-02-21 13:51 | hgbot | Merge Request Status | open => approved |
| 2023-02-21 16:06 | hgbot | Note Added: 0146816 | |
| 2023-02-21 16:06 | hgbot | Resolution | open => fixed |
| 2023-02-21 16:06 | hgbot | Status | new => closed |
| 2023-02-21 16:06 | hgbot | Fixed in Version | => 23Q2 |
| 2023-02-21 16:06 | hgbot | Note Added: 0146817 | |
| 2023-02-21 16:06 | hgbot | Note Added: 0146818 | |
| 2023-02-21 16:08 | hgbot | Note Added: 0146819 | |
| 2023-02-21 16:08 | hgbot | Note Added: 0146820 | |
| 2023-02-21 16:08 | hgbot | Note Added: 0146821 | |
| 2023-02-21 16:08 | hgbot | Note Added: 0146822 | |
| 2023-02-21 16:08 | hgbot | Note Added: 0146823 | |
| 2023-02-21 16:08 | hgbot | Note Added: 0146824 | |
| 2023-02-21 16:08 | hgbot | Note Added: 0146825 | |
| 2023-02-21 16:08 | hgbot | Note Added: 0146826 | |
| 2023-02-21 16:08 | hgbot | Note Added: 0146827 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |