Openbravo Issue Tracking System - POS2 |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0051652 | POS2 | POS | public | 2023-02-21 09:28 | 2023-02-21 16:08 |
|
| Reporter | migueldejuana | |
| Assigned To | migueldejuana | |
| Priority | normal | Severity | trivial | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | 23Q2 | |
| Merge Request Status | approved |
| Review Assigned To | |
| OBNetwork customer | No |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0051652: Small UI errors in margins |
| Description | Fix UI errors in POS2 to follow the rule of 8 with margins.
- Set 2.4rem margin(bottom) between components in a form. For DatePicker, take into account submessage.
- In Search window, characteristic popup must have 2.4rem margin between values.
- Adjust Approval popup to fit to defined margins.
- Customer form must have 2.4rem margin(bottom) in all the components.
- In Key Map Editor, New Category popup must have also the defined margins.
- In Print/Email popup, when confirming an order, the input need to have the proper margin.
- Customer button in the Ticket Header must have a differente icon. Same icon but without the surrounding circle.
- Ticket properties popover has no enough margin between the components.
- Improve margins in Print Product Labels
- Ensure Giftcard popup has input with correct margin
|
| Steps To Reproduce | n/a |
| Proposed Solution | |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2023-02-21 09:28 | migueldejuana | New Issue | |
| 2023-02-21 09:28 | migueldejuana | Assigned To | => migueldejuana |
| 2023-02-21 09:28 | migueldejuana | OBNetwork customer | => No |
| 2023-02-21 09:28 | migueldejuana | Triggers an Emergency Pack | => No |
| 2023-02-21 09:57 | migueldejuana | Description Updated | bug_revision_view_page.php?rev_id=25554#r25554 |
| 2023-02-21 09:58 | hgbot | Merge Request Status | => open |
| 2023-02-21 09:58 | hgbot | Note Added: 0146807 | |
| 2023-02-21 10:08 | migueldejuana | Description Updated | bug_revision_view_page.php?rev_id=25555#r25555 |
| 2023-02-21 10:11 | hgbot | Note Added: 0146809 | |
| 2023-02-21 10:16 | migueldejuana | Description Updated | bug_revision_view_page.php?rev_id=25556#r25556 |
| 2023-02-21 10:31 | hgbot | Note Added: 0146810 | |
| 2023-02-21 10:36 | migueldejuana | Description Updated | bug_revision_view_page.php?rev_id=25557#r25557 |
| 2023-02-21 10:37 | hgbot | Note Added: 0146811 | |
| 2023-02-21 10:40 | migueldejuana | Description Updated | bug_revision_view_page.php?rev_id=25558#r25558 |
| 2023-02-21 13:51 | hgbot | Merge Request Status | open => approved |
| 2023-02-21 16:06 | hgbot | Note Added: 0146816 | |
| 2023-02-21 16:06 | hgbot | Resolution | open => fixed |
| 2023-02-21 16:06 | hgbot | Status | new => closed |
| 2023-02-21 16:06 | hgbot | Fixed in Version | => 23Q2 |
| 2023-02-21 16:06 | hgbot | Note Added: 0146817 | |
| 2023-02-21 16:06 | hgbot | Note Added: 0146818 | |
| 2023-02-21 16:08 | hgbot | Note Added: 0146819 | |
| 2023-02-21 16:08 | hgbot | Note Added: 0146820 | |
| 2023-02-21 16:08 | hgbot | Note Added: 0146821 | |
| 2023-02-21 16:08 | hgbot | Note Added: 0146822 | |
| 2023-02-21 16:08 | hgbot | Note Added: 0146823 | |
| 2023-02-21 16:08 | hgbot | Note Added: 0146824 | |
| 2023-02-21 16:08 | hgbot | Note Added: 0146825 | |
| 2023-02-21 16:08 | hgbot | Note Added: 0146826 | |
| 2023-02-21 16:08 | hgbot | Note Added: 0146827 | |
|
Notes |
|
|
(0146807)
|
|
hgbot
|
|
2023-02-21 09:58
|
|
|
|
|
(0146809)
|
|
hgbot
|
|
2023-02-21 10:11
|
|
|
|
|
(0146810)
|
|
hgbot
|
|
2023-02-21 10:31
|
|
|
|
|
(0146811)
|
|
hgbot
|
|
2023-02-21 10:37
|
|
|
|
|
(0146816)
|
|
hgbot
|
|
2023-02-21 16:06
|
|
|
|
|
(0146817)
|
|
hgbot
|
|
2023-02-21 16:06
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: abcf1f048d770bc706f658a75d131990cd71ad8b
Author: miguel.dejuana <miguel.dejuana@openbravo.com>
Date: 21-02-2023 09:57:51
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/abcf1f048d770bc706f658a75d131990cd71ad8b [^]
Fixes ISSUE-0051652: Small UI errors in margins
Fix UI errors in POS2 to follow the rule of 8 with margins.
- Set 2.4rem margin(bottom) between components in a form. For DatePicker, take into account submessage.
- In Search window, characteristic popup must have 2.4rem margin between values.
- Adjust Approval popup to fit to defined margins.
---
M web-jspack/org.openbravo.core2/src/components/Form/BaseFormContent.scss
M web-jspack/org.openbravo.core2/src/components/PickAndExecutePopup/PickAndExecuteOptionTree/PickAndExecuteOptionTree.scss
M web-jspack/org.openbravo.core2/src/components/PickAndExecutePopup/PickAndExecuteOptionTreeList/PickAndExecuteOptionTreeList.scss
M web-jspack/org.openbravo.core2/src/components/PickAndExecutePopup/PickAndExecutePopup.config.json
M web-jspack/org.openbravo.core2/src/components/ReasonAndApprovalDialog/ReasonAndApprovalDialog.scss
---
|
|
|
|
(0146818)
|
|
hgbot
|
|
2023-02-21 16:06
|
|
|
|
|
(0146819)
|
|
hgbot
|
|
2023-02-21 16:08
|
|
|
|
|
(0146820)
|
|
hgbot
|
|
2023-02-21 16:08
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: f2678cf620243c231b957cb62b36620556c14aa0
Author: miguel.dejuana <miguel.dejuana@openbravo.com>
Date: 21-02-2023 10:08:32
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/f2678cf620243c231b957cb62b36620556c14aa0 [^]
Fixes ISSUE-0051652: Small UI errors in margins
- Customer form must have 2.4rem margin(bottom) in all the components.
- In Key Map Editor, New Category popup must have also the defined margins.
- In Print/Email popup, when confirming an order, the input need to have the proper margin.
- Customer button in the Ticket Header must have a differente icon. Same icon but without the surrounding circle.
- Ticket properties popover has no enough margin between the components.
---
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerForm/CustomerForm.scss
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerSelector/CustomerSelector.scss
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeymapEditorNewCategoryDialog/KeymapEditorCategoryDialog.jsx
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeymapEditorNewCategoryDialog/KeymapEditorCategoryDialog.scss
M web-jspack/org.openbravo.pos2/src/components/ReceiptDeliveryOptions/SharedReceiptDeliveryOptions/ReceiptDeliveryOptionsEmailInput/ReceiptDeliveryOptionsEmailInput.scss
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPButton/TicketBPButton.config.json
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketPropertiesPopover/TicketPropertiesPopover.scss
---
|
|
|
|
(0146821)
|
|
hgbot
|
|
2023-02-21 16:08
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 9c5c058ed8501a2524c97b05f53e4a469d569540
Author: miguel.dejuana <miguel.dejuana@openbravo.com>
Date: 21-02-2023 16:02:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/9c5c058ed8501a2524c97b05f53e4a469d569540 [^]
Fixes ISSUE-0051652: Small UI errors in margins
- Add copyrights
---
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerForm/CustomerForm.scss
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerSelector/CustomerSelector.scss
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeymapEditorNewCategoryDialog/KeymapEditorCategoryDialog.jsx
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeymapEditorNewCategoryDialog/KeymapEditorCategoryDialog.scss
M web-jspack/org.openbravo.pos2/src/components/ReceiptDeliveryOptions/SharedReceiptDeliveryOptions/ReceiptDeliveryOptionsEmailInput/ReceiptDeliveryOptionsEmailInput.scss
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketPropertiesPopover/TicketPropertiesPopover.scss
---
|
|
|
|
(0146822)
|
|
hgbot
|
|
2023-02-21 16:08
|
|
|
|
|
(0146823)
|
|
hgbot
|
|
2023-02-21 16:08
|
|
|
|
|
(0146824)
|
|
hgbot
|
|
2023-02-21 16:08
|
|
|
|
|
(0146825)
|
|
hgbot
|
|
2023-02-21 16:08
|
|
|
|
|
(0146826)
|
|
hgbot
|
|
2023-02-21 16:08
|
|
|
|
|
(0146827)
|
|
hgbot
|
|
2023-02-21 16:08
|
|
|