Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0051628
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] External Integration Infrastructureminorhave not tried2023-02-16 13:282023-02-17 07:59
ReportercaristuView Statuspublic 
Assigned Tocaristu 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Regression introduced in release
Summary

0051628: OSP.getBOBInClosestOrg should return null when no bob is found in the natural tree of the organization

DescriptionOSP.getBOBInClosestOrg which we introduced with the fix of 0051547 should return null if any of the bobs in the provided list is in the natural tree of the given org.
Steps To ReproduceIn description
Proposed Solution- Change the OSP.getBOBInClosestOrg method to return null in the mentioned case
- Adapt the DirectPropertyMapping to take into account this case, which affects to the mapping of cross organization properties. In that case we'll return the first record found ordering the records by ID
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0051547pi closedcaristu Retail Modules PriceList API - Product price is wrongly added when same products searchKey on different Orgs are in OB backoffice 

-  Notes
(0146638)
hgbot (developer)
2023-02-16 13:36

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/826 [^]
(0146639)
hgbot (developer)
2023-02-16 13:41

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.external.integration/-/merge_requests/32 [^]
(0146674)
hgbot (developer)
2023-02-17 07:58

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.external.integration [^]
Changeset: 3e4bc7b812ef95a86c93f4589acb8884d22f7165
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 16-02-2023 13:39:57
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.external.integration/-/commit/3e4bc7b812ef95a86c93f4589acb8884d22f7165 [^]

related to BUG-51628: use getBOBInClosestOrg only when pre-filtering by natural tree

---
M src/org/openbravo/service/external/integration/mapping/DirectPropertyMapping.java
---
(0146675)
hgbot (developer)
2023-02-17 07:58

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.external.integration/-/merge_requests/32 [^]
(0146676)
hgbot (developer)
2023-02-17 07:59

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/826 [^]
(0146677)
hgbot (developer)
2023-02-17 07:59

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 2a4c4491db9cfa8e4f3dd2f66c918f7effc530a6
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 17-02-2023 06:59:16
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/2a4c4491db9cfa8e4f3dd2f66c918f7effc530a6 [^]

fixes BUG-51628: getBOBInClosestOrg should return null if bobs are not in org natural tree

---
A src-test/src/org/openbravo/test/security/BOBInClosestOrgTest.java
M src-test/src/org/openbravo/test/StandaloneTestSuite.java
M src/org/openbravo/dal/security/OrganizationStructureProvider.java
---

- Issue History
Date Modified Username Field Change
2023-02-16 13:28 caristu New Issue
2023-02-16 13:28 caristu Assigned To => caristu
2023-02-16 13:28 caristu Triggers an Emergency Pack => No
2023-02-16 13:28 caristu Issue generated from 0051547
2023-02-16 13:28 caristu Relationship added related to 0051547
2023-02-16 13:30 caristu Project Retail Modules => Modules
2023-02-16 13:30 caristu Category Retail API => External Integration Infrastructure
2023-02-16 13:30 caristu version pi =>
2023-02-16 13:30 caristu Description Updated View Revisions
2023-02-16 13:34 caristu Proposed Solution updated
2023-02-16 13:36 hgbot Note Added: 0146638
2023-02-16 13:41 hgbot Note Added: 0146639
2023-02-16 13:51 rafademiguel Issue Monitored: rafademiguel
2023-02-17 07:58 hgbot Note Added: 0146674
2023-02-17 07:58 hgbot Note Added: 0146675
2023-02-17 07:59 hgbot Resolution open => fixed
2023-02-17 07:59 hgbot Status new => closed
2023-02-17 07:59 hgbot Note Added: 0146676
2023-02-17 07:59 hgbot Fixed in Version => PR23Q2
2023-02-17 07:59 hgbot Note Added: 0146677

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker