Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051628ModulesExternal Integration Infrastructurepublic2023-02-16 13:282023-02-17 07:59
Reportercaristu 
Assigned Tocaristu 
PriorityhighSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customer
Regression introduced in release
Summary0051628: OSP.getBOBInClosestOrg should return null when no bob is found in the natural tree of the organization
DescriptionOSP.getBOBInClosestOrg which we introduced with the fix of 0051547 should return null if any of the bobs in the provided list is in the natural tree of the given org.
Steps To ReproduceIn description
Proposed Solution- Change the OSP.getBOBInClosestOrg method to return null in the mentioned case
- Adapt the DirectPropertyMapping to take into account this case, which affects to the mapping of cross organization properties. In that case we'll return the first record found ordering the records by ID
Additional Information
TagsNo tags attached.
Relationships
related to defect 0051547pi closed caristu Retail Modules PriceList API - Product price is wrongly added when same products searchKey on different Orgs are in OB backoffice 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-02-16 13:28caristuNew Issue
2023-02-16 13:28caristuAssigned To => caristu
2023-02-16 13:28caristuTriggers an Emergency Pack => No
2023-02-16 13:28caristuIssue generated from0051547
2023-02-16 13:28caristuRelationship addedrelated to 0051547
2023-02-16 13:30caristuProjectRetail Modules => Modules
2023-02-16 13:30caristuCategoryRetail API => External Integration Infrastructure
2023-02-16 13:30caristuversionpi =>
2023-02-16 13:30caristuDescription Updatedbug_revision_view_page.php?rev_id=25548#r25548
2023-02-16 13:34caristuProposed Solution updated
2023-02-16 13:36hgbotNote Added: 0146638
2023-02-16 13:41hgbotNote Added: 0146639
2023-02-16 13:51rafademiguelIssue Monitored: rafademiguel
2023-02-17 07:58hgbotNote Added: 0146674
2023-02-17 07:58hgbotNote Added: 0146675
2023-02-17 07:59hgbotResolutionopen => fixed
2023-02-17 07:59hgbotStatusnew => closed
2023-02-17 07:59hgbotNote Added: 0146676
2023-02-17 07:59hgbotFixed in Version => PR23Q2
2023-02-17 07:59hgbotNote Added: 0146677

Notes
(0146638)
hgbot   
2023-02-16 13:36   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/826 [^]
(0146639)
hgbot   
2023-02-16 13:41   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.external.integration/-/merge_requests/32 [^]
(0146674)
hgbot   
2023-02-17 07:58   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.external.integration [^]
Changeset: 3e4bc7b812ef95a86c93f4589acb8884d22f7165
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 16-02-2023 13:39:57
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.external.integration/-/commit/3e4bc7b812ef95a86c93f4589acb8884d22f7165 [^]

related to BUG-51628: use getBOBInClosestOrg only when pre-filtering by natural tree

---
M src/org/openbravo/service/external/integration/mapping/DirectPropertyMapping.java
---
(0146675)
hgbot   
2023-02-17 07:58   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.service.external.integration/-/merge_requests/32 [^]
(0146676)
hgbot   
2023-02-17 07:59   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/826 [^]
(0146677)
hgbot   
2023-02-17 07:59   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 2a4c4491db9cfa8e4f3dd2f66c918f7effc530a6
Author: Carlos Aristu <carlos.aristu@openbravo.com>
Date: 17-02-2023 06:59:16
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/2a4c4491db9cfa8e4f3dd2f66c918f7effc530a6 [^]

fixes BUG-51628: getBOBInClosestOrg should return null if bobs are not in org natural tree

---
A src-test/src/org/openbravo/test/security/BOBInClosestOrgTest.java
M src-test/src/org/openbravo/test/StandaloneTestSuite.java
M src/org/openbravo/dal/security/OrganizationStructureProvider.java
---