Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0051594
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] Remittancemajorhave not tried2023-02-14 13:302023-03-07 18:15
ReportershuehnerView Statuspublic 
Assigned Tofrancisco_ofarril 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Regression introduced in release
Summary

0051594: Several files in org.openbravo.module.remittance are not using bind-params and are not following HQL-style

DescriptionList of file-location with non-constant HQL
# CancelReturnRemittance.java:598
# CancelReturnRemittance.java:747
org.openbravo.module.remittance.ad_forms.DocREMRemittance.java:287
org.openbravo.module.remittance.ad_forms.DocREMRemittance.java:346
org.openbravo.module.remittance.ad_forms.DocREMRemittance.java:361
org.openbravo.module.remittance.ad_forms.DocREMRemittance.java:743
org.openbravo.module.remittance.ad_forms.DocREMRemittanceCancel.java:115
org.openbravo.module.remittance.ad_forms.DocREMRemittanceCancel.java:130
org.openbravo.module.remittance.ad_forms.DocREMRemittanceReturn.java:241
org.openbravo.module.remittance.ad_forms.DocREMRemittanceReturn.java:256
org.openbravo.module.remittance.event.PaymentEventHandler.java:53
org.openbravo.module.remittance.hooks.REMModifyPaymentPlanHook.java:64
org.openbravo.module.remittance.process.REM_AddRemittance.java:688
org.openbravo.module.remittance.process.REM_RemittanceProcess.java:480
org.openbravo.module.remittance.process.REM_RemittanceProcess.java:1297
org.openbravo.module.remittance.process.REM_RemittanceProcess.java:1444
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0051796 newTriage Omni OMS Modules Several files in org.openbravo.module.remittance not following HQL-style 
blocks design defect 0038136 acknowledgedTriage Platform Base Openbravo ERP Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
causes defect 0052767 closedfrank_gonzalez Modules orgdsIds parameter wrongly spelled in REM_AddRemittance.java 
causes defect 0052771 closedfrank_gonzalez Modules Cannot reactivate any Payment if 3.2.232000 version of Remittance Infrastructure module is installed 
causes defect 0053554 closedifernandez Modules Problem in mantis patch parameters 51594 

-  Notes
(0146559)
hgbot (developer)
2023-02-15 10:56

Merge Request created: https://gitlab.com/openbravo/product/mods/org.openbravo.module.remittance/-/merge_requests/8 [^]
(0147342)
hgbot (developer)
2023-03-07 18:14

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.module.remittance [^]
Changeset: 008fd4a7e3fa3e551357e76c11705c461ced12a3
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 07-03-2023 17:14:45
URL: https://gitlab.com/openbravo/product/mods/org.openbravo.module.remittance/-/commit/008fd4a7e3fa3e551357e76c11705c461ced12a3 [^]

Fixes ISSUE-51594: Apply HQL style and use bind-params

---
M src/org/openbravo/module/remittance/ad_forms/CancelReturnRemittance.java
M src/org/openbravo/module/remittance/ad_forms/DocREMRemittance.java
M src/org/openbravo/module/remittance/ad_forms/DocREMRemittanceCancel.java
M src/org/openbravo/module/remittance/ad_forms/DocREMRemittanceReturn.java
M src/org/openbravo/module/remittance/event/PaymentEventHandler.java
M src/org/openbravo/module/remittance/hooks/REMModifyPaymentPlanHook.java
M src/org/openbravo/module/remittance/process/REM_AddRemittance.java
M src/org/openbravo/module/remittance/process/REM_RemittanceProcess.java
---
(0147343)
hgbot (developer)
2023-03-07 18:14

Merge request merged: https://gitlab.com/openbravo/product/mods/org.openbravo.module.remittance/-/merge_requests/8 [^]

- Issue History
Date Modified Username Field Change
2023-02-14 13:30 shuehner New Issue
2023-02-14 13:30 shuehner Assigned To => Triage Omni OMS
2023-02-14 13:31 shuehner Relationship added blocks 0038136
2023-02-15 10:56 hgbot Note Added: 0146559
2023-02-20 12:13 aferraz Assigned To Triage Omni OMS => francisco_ofarril
2023-03-01 23:36 francisco_ofarril Status new => scheduled
2023-03-07 18:13 aferraz Issue cloned 0051796
2023-03-07 18:14 hgbot Resolution open => fixed
2023-03-07 18:14 hgbot Status scheduled => closed
2023-03-07 18:14 hgbot Note Added: 0147342
2023-03-07 18:14 hgbot Note Added: 0147343
2023-03-07 18:15 aferraz Relationship added related to 0051796
2023-06-16 12:08 ngarcia Relationship added causes 0052767
2023-06-16 14:21 ngarcia Relationship added causes 0052771
2023-09-26 18:07 axelmercado Relationship added causes 0053554


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker