Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0051594ModulesRemittancepublic2023-02-14 13:302023-03-07 18:15
Reportershuehner 
Assigned Tofrancisco_ofarril 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Support ticket
OBNetwork customerOBPS
Regression introduced in release
Summary0051594: Several files in org.openbravo.module.remittance are not using bind-params and are not following HQL-style
DescriptionList of file-location with non-constant HQL
# CancelReturnRemittance.java:598
# CancelReturnRemittance.java:747
org.openbravo.module.remittance.ad_forms.DocREMRemittance.java:287
org.openbravo.module.remittance.ad_forms.DocREMRemittance.java:346
org.openbravo.module.remittance.ad_forms.DocREMRemittance.java:361
org.openbravo.module.remittance.ad_forms.DocREMRemittance.java:743
org.openbravo.module.remittance.ad_forms.DocREMRemittanceCancel.java:115
org.openbravo.module.remittance.ad_forms.DocREMRemittanceCancel.java:130
org.openbravo.module.remittance.ad_forms.DocREMRemittanceReturn.java:241
org.openbravo.module.remittance.ad_forms.DocREMRemittanceReturn.java:256
org.openbravo.module.remittance.event.PaymentEventHandler.java:53
org.openbravo.module.remittance.hooks.REMModifyPaymentPlanHook.java:64
org.openbravo.module.remittance.process.REM_AddRemittance.java:688
org.openbravo.module.remittance.process.REM_RemittanceProcess.java:480
org.openbravo.module.remittance.process.REM_RemittanceProcess.java:1297
org.openbravo.module.remittance.process.REM_RemittanceProcess.java:1444
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0051796 new Triage Omni OMS Modules Several files in org.openbravo.module.remittance not following HQL-style 
blocks design defect 0038136 acknowledged Triage Platform Base Openbravo ERP Tracking issue: Find & Fix queries not using bind-params but embedding values into query string 
causes defect 0052767 closed frank_gonzalez Modules orgdsIds parameter wrongly spelled in REM_AddRemittance.java 
causes defect 0052771 closed frank_gonzalez Modules Cannot reactivate any Payment if 3.2.232000 version of Remittance Infrastructure module is installed 
causes defect 0053554 closed ifernandez Modules Problem in mantis patch parameters 51594 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-02-14 13:30shuehnerNew Issue
2023-02-14 13:30shuehnerAssigned To => Triage Omni OMS
2023-02-14 13:30shuehnerOBNetwork customer => No
2023-02-14 13:31shuehnerRelationship addedblocks 0038136
2023-02-14 13:31shuehnerOBNetwork customerNo => OBPS
2023-02-15 10:56hgbotMerge Request Status => open
2023-02-15 10:56hgbotNote Added: 0146559
2023-02-20 12:13aferrazAssigned ToTriage Omni OMS => francisco_ofarril
2023-03-01 23:36francisco_ofarrilStatusnew => scheduled
2023-03-07 18:13aferrazIssue cloned0051796
2023-03-07 18:14hgbotMerge Request Statusopen => approved
2023-03-07 18:14hgbotResolutionopen => fixed
2023-03-07 18:14hgbotStatusscheduled => closed
2023-03-07 18:14hgbotNote Added: 0147342
2023-03-07 18:14hgbotNote Added: 0147343
2023-03-07 18:15aferrazRelationship addedrelated to 0051796
2023-06-16 12:08ngarciaRelationship addedcauses 0052767
2023-06-16 14:21ngarciaRelationship addedcauses 0052771
2023-09-26 18:07axelmercadoRelationship addedcauses 0053554

Notes
(0146559)
hgbot   
2023-02-15 10:56   
Merge Request created: https://gitlab.com/openbravo/product/mods/org.openbravo.module.remittance/-/merge_requests/8 [^]
(0147342)
hgbot   
2023-03-07 18:14   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/mods/org.openbravo.module.remittance [^]
Changeset: 008fd4a7e3fa3e551357e76c11705c461ced12a3
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 07-03-2023 17:14:45
URL: https://gitlab.com/openbravo/product/mods/org.openbravo.module.remittance/-/commit/008fd4a7e3fa3e551357e76c11705c461ced12a3 [^]

Fixes ISSUE-51594: Apply HQL style and use bind-params

---
M src/org/openbravo/module/remittance/ad_forms/CancelReturnRemittance.java
M src/org/openbravo/module/remittance/ad_forms/DocREMRemittance.java
M src/org/openbravo/module/remittance/ad_forms/DocREMRemittanceCancel.java
M src/org/openbravo/module/remittance/ad_forms/DocREMRemittanceReturn.java
M src/org/openbravo/module/remittance/event/PaymentEventHandler.java
M src/org/openbravo/module/remittance/hooks/REMModifyPaymentPlanHook.java
M src/org/openbravo/module/remittance/process/REM_AddRemittance.java
M src/org/openbravo/module/remittance/process/REM_RemittanceProcess.java
---
(0147343)
hgbot   
2023-03-07 18:14   
Merge request merged: https://gitlab.com/openbravo/product/mods/org.openbravo.module.remittance/-/merge_requests/8 [^]